From patchwork Tue Dec 5 12:33:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Bogendoerfer X-Patchwork-Id: 844724 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yrh4t4dywz9tB4 for ; Tue, 5 Dec 2017 23:34:06 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752589AbdLEMdy (ORCPT ); Tue, 5 Dec 2017 07:33:54 -0500 Received: from mx2.suse.de ([195.135.220.15]:56604 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752149AbdLEMdw (ORCPT ); Tue, 5 Dec 2017 07:33:52 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id F17ECAD51; Tue, 5 Dec 2017 12:33:50 +0000 (UTC) From: Thomas Bogendoerfer To: Michael Chan , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next] bnxt: Don't print message, if DAC isn't connected on both ends Date: Tue, 5 Dec 2017 13:33:40 +0100 Message-Id: <20171205123340.3307-1-tbogendoerfer@suse.de> X-Mailer: git-send-email 2.12.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org bnxt driver spams logfiles with [ 541.003065] bnxt_en 0000:5d:00.1 eth5: Link speed -1 no longer supported if a direct attached cable (DAC) is plugged into the bnxt card and is unplugged on the other side. This patch removes the code printing this message, since it doesn't provide any useful information. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 8c1dd60eab6f..8a2319ed79dc 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -1701,18 +1701,9 @@ static int bnxt_async_event_process(struct bnxt *bp, /* TODO CHIMP_FW: Define event id's for link change, error etc */ switch (event_id) { case ASYNC_EVENT_CMPL_EVENT_ID_LINK_SPEED_CFG_CHANGE: { - u32 data1 = le32_to_cpu(cmpl->event_data1); - struct bnxt_link_info *link_info = &bp->link_info; - if (BNXT_VF(bp)) goto async_event_process_exit; - if (data1 & 0x20000) { - u16 fw_speed = link_info->force_link_speed; - u32 speed = bnxt_fw_to_ethtool_speed(fw_speed); - netdev_warn(bp->dev, "Link speed %d no longer supported\n", - speed); - } set_bit(BNXT_LINK_SPEED_CHNG_SP_EVENT, &bp->sp_event); /* fall thru */ }