| Message ID | 20171130195744.17743-4-f.fainelli@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | PHYLINK preparatory patches for DSA | expand |
On Thu, Nov 30, 2017 at 11:57:42AM -0800, Florian Fainelli wrote: > Some subsystems like DSA may be trying to connect to a PHY through OF first, > and then attempt a connect using a local MDIO bus, demote the error message: > "unable to find PHY node" into a debug print. Maybe it would be better to push this out to the drivers to print if they wish?
On 11/30/2017 03:26 PM, Russell King - ARM Linux wrote: > On Thu, Nov 30, 2017 at 11:57:42AM -0800, Florian Fainelli wrote: >> Some subsystems like DSA may be trying to connect to a PHY through OF first, >> and then attempt a connect using a local MDIO bus, demote the error message: >> "unable to find PHY node" into a debug print. > > Maybe it would be better to push this out to the drivers to print > if they wish? > Sure, I will just drop that message then.
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 8a30ea8873af..a41f0a224512 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -694,7 +694,7 @@ int phylink_of_phy_connect(struct phylink *pl, struct device_node *dn, if (!phy_node) { if (pl->link_an_mode == MLO_AN_PHY) { - netdev_err(pl->netdev, "unable to find PHY node\n"); + netdev_dbg(pl->netdev, "unable to find PHY node\n"); return -ENODEV; } return 0;
Some subsystems like DSA may be trying to connect to a PHY through OF first, and then attempt a connect using a local MDIO bus, demote the error message: "unable to find PHY node" into a debug print. Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- drivers/net/phy/phylink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)