| Message ID | 20171108155010.23997-1-vivien.didelot@savoirfairelinux.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] net: dsa: return after vlan prepare phase | expand |
On Wed, Nov 08, 2017 at 10:50:10AM -0500, Vivien Didelot wrote: > The current code does not return after successfully preparing the VLAN > addition on every ports member of a it. Fix this. > > Fixes: 1ca4aa9cd4cc ("net: dsa: check VLAN capability of every switch") > Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com> Date: Wed, 8 Nov 2017 10:50:10 -0500 > The current code does not return after successfully preparing the VLAN > addition on every ports member of a it. Fix this. > > Fixes: 1ca4aa9cd4cc ("net: dsa: check VLAN capability of every switch") > Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> Applied.
diff --git a/net/dsa/switch.c b/net/dsa/switch.c index 73746fa148f1..1e2929f4290a 100644 --- a/net/dsa/switch.c +++ b/net/dsa/switch.c @@ -182,6 +182,8 @@ static int dsa_switch_vlan_add(struct dsa_switch *ds, if (err) return err; } + + return 0; } for_each_set_bit(port, members, ds->num_ports)
The current code does not return after successfully preparing the VLAN addition on every ports member of a it. Fix this. Fixes: 1ca4aa9cd4cc ("net: dsa: check VLAN capability of every switch") Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> --- net/dsa/switch.c | 2 ++ 1 file changed, 2 insertions(+)