From patchwork Wed Nov 8 07:21:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saeed Mahameed X-Patchwork-Id: 835685 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yWySK2gC8z9sNw for ; Wed, 8 Nov 2017 18:22:57 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756026AbdKHHWg (ORCPT ); Wed, 8 Nov 2017 02:22:36 -0500 Received: from mail-il-dmz.mellanox.com ([193.47.165.129]:46422 "EHLO mellanox.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753677AbdKHHWP (ORCPT ); Wed, 8 Nov 2017 02:22:15 -0500 Received: from Internal Mail-Server by MTLPINE1 (envelope-from saeedm@mellanox.com) with ESMTPS (AES256-SHA encrypted); 8 Nov 2017 09:22:11 +0200 Received: from mti-swat15.mti.labs.mlnx. (mti-swat15.mti.labs.mlnx [10.20.1.123]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id vA87M47M029318; Wed, 8 Nov 2017 09:22:09 +0200 From: Saeed Mahameed To: "David S. Miller" Cc: netdev@vger.kernel.org, Kamal Heib , Saeed Mahameed Subject: [net 3/6] net/mlx5: FPGA, return -EINVAL if size is zero Date: Tue, 7 Nov 2017 23:21:39 -0800 Message-Id: <20171108072142.30870-4-saeedm@mellanox.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20171108072142.30870-1-saeedm@mellanox.com> References: <20171108072142.30870-1-saeedm@mellanox.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Kamal Heib In the current code, if a size of zero is passed to mlx5_fpga_mem_{read|write}_i2c() functions the "err" return value will not initialized. Fixes: a9956d35d199 ('net/mlx5: FPGA, Add SBU infrastructure') Signed-off-by: Kamal Heib Reviewed-by: Yevgeny Kliteynik Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/fpga/sdk.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fpga/sdk.c b/drivers/net/ethernet/mellanox/mlx5/core/fpga/sdk.c index 3c11d6e2160a..14962969c5ba 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/fpga/sdk.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/fpga/sdk.c @@ -66,6 +66,9 @@ static int mlx5_fpga_mem_read_i2c(struct mlx5_fpga_device *fdev, size_t size, u8 actual_size; int err; + if (!size) + return -EINVAL; + if (!fdev->mdev) return -ENOTCONN; @@ -95,6 +98,9 @@ static int mlx5_fpga_mem_write_i2c(struct mlx5_fpga_device *fdev, size_t size, u8 actual_size; int err; + if (!size) + return -EINVAL; + if (!fdev->mdev) return -ENOTCONN;