From patchwork Mon Oct 23 23:17:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 829740 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="ByoxeUEV"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yLXPw5tgqz9s1h for ; Tue, 24 Oct 2017 10:18:12 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751407AbdJWXSJ (ORCPT ); Mon, 23 Oct 2017 19:18:09 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:53473 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751344AbdJWXSF (ORCPT ); Mon, 23 Oct 2017 19:18:05 -0400 Received: by mail-io0-f195.google.com with SMTP id 189so21925089iow.10 for ; Mon, 23 Oct 2017 16:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=n1RjgdGbtQ+g5ItliYsf4H9r28PAE1mEDowrYteFFI0=; b=ByoxeUEV7gO1ZXkNsBHvnNzSFN8HMc0pdm2omvmEHb80WSS0E5YOeBhPmVNgUjHoh6 a1Nlgf4GYUjpYZR3rNSdUY2I5SVNAs9dd2l3QU/XK0TtZqKZR5hzy7K3ecZTA/f7jGVF 9l2FdcWDoRtf6pV3MQt/CzUjI6ULqgf5AVNRw8U/o0kPk+6QnCakSs5c3BaCSf6riFgT eC+N/t4b/Q/pTinhz6jRpxsxIqBeU7668eyNw47RUYNOIS3SUaH4E0ujxNklk42C6srm Y1SOmZdCmp1hDmjUyJI/UMG+bYKHhaNg9oU+z66pZ3cAoj2ELacZprj+FJAllzph3v3W W6tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=n1RjgdGbtQ+g5ItliYsf4H9r28PAE1mEDowrYteFFI0=; b=PSjyRonRvFztOZYOMlbjLFn1kAF1nOt4pYJ0PvzJ3Oo/bnCD8/3h/GR6FZ7bE7Vwao DIVqqj5fDKkabh3AVaOy5UUfakCywWjyH0os/KODuRhpYYveWSUyqF1diEAuK5CBU3E3 6pG7iabUTj+QwrnEN4qPY8uWxLReeCpa41nUx26Bq7uEu7Pqvr4sFH1P1ZoBz+hN2jcx C0bsq3TIYTxuqC3uRstJwUaSjlbzbtLERXJzu7UljqFRbi8wpyX42RkYH9Yq5VmL2mnz 0uRftJzk5E4K1yt+yhkKM4TDE4KK+xOghsou/pEZdEei2RJYvmEo2wNkYq7rvbIfzUhq Dnqw== X-Gm-Message-State: AMCzsaVWbmBWpDSrwPEs42bd4puWGlCL0I9e6lmTK3473w6KkfHEv0qA U1HBF3FhDYARHE02VIp0lclzvA== X-Google-Smtp-Source: ABhQp+QZpUjLd6sbV+dmjNTlYhYMDPwEdV3u9wl1RTHS/fMdekTWhGb8Ehj5nxzcQ7PbbJqM0yfykw== X-Received: by 10.107.69.14 with SMTP id s14mr19615209ioa.113.1508800684478; Mon, 23 Oct 2017 16:18:04 -0700 (PDT) Received: from localhost ([2620:15c:2c4:201:4c03:660f:f523:6474]) by smtp.gmail.com with ESMTPSA id h20sm3571587iob.65.2017.10.23.16.18.03 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 23 Oct 2017 16:18:03 -0700 (PDT) From: Eric Dumazet To: "David S . Miller" Cc: netdev , Eric Dumazet , Eric Dumazet Subject: [PATCH net-next 4/7] ipv6: addrconf: do not block BH in ipv6_chk_addr_and_flags() Date: Mon, 23 Oct 2017 16:17:48 -0700 Message-Id: <20171023231751.29530-5-edumazet@google.com> X-Mailer: git-send-email 2.15.0.rc0.271.g36b669edcc-goog In-Reply-To: <20171023231751.29530-1-edumazet@google.com> References: <20171023231751.29530-1-edumazet@google.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org rcu_read_lock() is enough here, as inet6_ifa_finish_destroy() uses kfree_rcu() Signed-off-by: Eric Dumazet --- net/ipv6/addrconf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index d70d98122053652b4f4420786de8788c6c9385ff..a6cf37b7e34c461e204153078be92c3e297b3ec2 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -1844,7 +1844,7 @@ int ipv6_chk_addr_and_flags(struct net *net, const struct in6_addr *addr, struct inet6_ifaddr *ifp; u32 ifp_flags; - rcu_read_lock_bh(); + rcu_read_lock(); hlist_for_each_entry_rcu(ifp, &inet6_addr_lst[hash], addr_lst) { if (!net_eq(dev_net(ifp->idev->dev), net)) continue; @@ -1858,12 +1858,12 @@ int ipv6_chk_addr_and_flags(struct net *net, const struct in6_addr *addr, !(ifp_flags&banned_flags) && (!dev || ifp->idev->dev == dev || !(ifp->scope&(IFA_LINK|IFA_HOST) || strict))) { - rcu_read_unlock_bh(); + rcu_read_unlock(); return 1; } } - rcu_read_unlock_bh(); + rcu_read_unlock(); return 0; } EXPORT_SYMBOL(ipv6_chk_addr_and_flags);