From patchwork Thu Oct 19 22:46:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Kicinski X-Patchwork-Id: 828400 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="dulsspji"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yJ3wb470Fz9t7V for ; Fri, 20 Oct 2017 09:47:43 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753465AbdJSWrl (ORCPT ); Thu, 19 Oct 2017 18:47:41 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:52068 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752285AbdJSWrH (ORCPT ); Thu, 19 Oct 2017 18:47:07 -0400 Received: by mail-pf0-f193.google.com with SMTP id n14so8101535pfh.8 for ; Thu, 19 Oct 2017 15:47:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=R8J4375TB/WS/z0nUUV4ASAQ1WvX08Wq20fDFt7Ir3Y=; b=dulsspjiUfVRW6ePYgpwMVzzXz0yarlKzEklZbz13Yi0dpmbKx4I3EPzykeHxvg1s8 xNGxJHwzD89UE3jSAzpOcPgrub2gv8SbMsTpMeXJDz1EfTh/92+Q4Gz+Es9iUe7GMWwA YU2Kw2GRBmkkkN6ZxKgZE8bAkit2/HRFMEktympiwqWYWNoG5zB/8tbRGYItnuvfqcIq 6xKfTJjZD1Wcm/o9uZKAvY+g1qBqfopQokH5Drp97YRi8XzUPUmk43OR94zHLMYahuqT YaTXcXBiM2ubaZatcPPUAI/hCONWawCfhqrZ3K1YpHgaG5B4fXYq4jnSPx/IHeSa96sl +g3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=R8J4375TB/WS/z0nUUV4ASAQ1WvX08Wq20fDFt7Ir3Y=; b=q67oSmIbPD/PIde5i7kmOxQoSD9vksr0UpUqXfPrtvTqwaFbWGno0ARZuTjxbBuh7p A9hsRl8oGHnPgLTQ0sKGcZScHUdotAQWR4vgzTPFgTd8siHT1O0kkRzaagzh6POl+A1K cTTSAl4umUldQAgyafVyykJJVBZObYHtMrYvmbPXT+yYLdP3fxYmQ93tvA/QHhaYEAIX wi5Z/KnPjio3UAR5/uw7t2hZ0jtbyvxCA8L++Iyckrxe9yGrUrj+b6yMf5tqh3oMRzwG lGXt3QbpgU5d1JjnyMmk8qA3jrgFkVpdI5hozhYaKRSjYOt2FqHqqmiHJx3uLGbLz1ib Yt2w== X-Gm-Message-State: AMCzsaU5VOTLNVA9Y95fJYFsPECcY28Cchr2L/8KgpmiGb+78/og9A/X YZXQx9NcbO92/PFNGlVQD7gggRn9 X-Google-Smtp-Source: ABhQp+QonyNPqKgFQ5Pc1nNMilO/edukquURwMhmf6vvvP+Nj6CavaoEmUbF/NzrToJB/jagc1QZGw== X-Received: by 10.99.3.213 with SMTP id 204mr2578545pgd.407.1508453226966; Thu, 19 Oct 2017 15:47:06 -0700 (PDT) Received: from jkicinski-Precision-T1700.netronome.com ([75.53.12.129]) by smtp.gmail.com with ESMTPSA id c185sm16969156pfb.112.2017.10.19.15.47.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 19 Oct 2017 15:47:06 -0700 (PDT) From: Jakub Kicinski To: netdev@vger.kernel.org Cc: oss-drivers@netronome.com, Quentin Monnet , Jakub Kicinski Subject: [PATCH net-next 3/8] tools: bpftool: use err() instead of info() if there are too many insns Date: Thu, 19 Oct 2017 15:46:21 -0700 Message-Id: <20171019224626.31608-4-jakub.kicinski@netronome.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20171019224626.31608-1-jakub.kicinski@netronome.com> References: <20171019224626.31608-1-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Quentin Monnet Make error messages and return codes more consistent. Specifically, replace the use of info() macro with err() when too many eBPF instructions are received to be dumped, given that bpftool returns with a non-null exit value in that case. Signed-off-by: Quentin Monnet Signed-off-by: Jakub Kicinski Acked-by: Daniel Borkmann --- tools/bpf/bpftool/prog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c index ede7957adcd9..6c03d2ea3f79 100644 --- a/tools/bpf/bpftool/prog.c +++ b/tools/bpf/bpftool/prog.c @@ -416,7 +416,7 @@ static int do_dump(int argc, char **argv) } if (*member_len > buf_size) { - info("too many instructions returned\n"); + err("too many instructions returned\n"); goto err_free; }