From patchwork Wed Oct 11 06:45:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 824252 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="JksIELn6"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yBl0p1fN1z9t7X for ; Wed, 11 Oct 2017 17:47:54 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757215AbdJKGrv (ORCPT ); Wed, 11 Oct 2017 02:47:51 -0400 Received: from mail-pf0-f180.google.com ([209.85.192.180]:48613 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751704AbdJKGp2 (ORCPT ); Wed, 11 Oct 2017 02:45:28 -0400 Received: by mail-pf0-f180.google.com with SMTP id b79so654326pfk.5 for ; Tue, 10 Oct 2017 23:45:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tom3zK/GFw6uChMa7PbJyymdKgx1ATdTjjhFDCuYEuU=; b=JksIELn6lNP5XLtRV+AYHsEtkzK5RQmLdzp1B6bZuv6mydUd9hsM6Ix4j9Txi6uZsu e6rDvjoFmqumc8Y9tkS2YQQr5UjB9Z+OQGoW2ggSPiKFioJ1RWA3Tquf+2VmFDhqCTw2 /78ymiYCHqci7Ae/bXVrQEi6TNtnt7TnZtJiI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tom3zK/GFw6uChMa7PbJyymdKgx1ATdTjjhFDCuYEuU=; b=ac6MMd8kxxpw00UD6K1O4loDOIiogFnJ69PQ8CrvXk0bg83Y2R4UPGpk7YCdnvmv5y sortYHiZbblek2htBYZV4k/Hiwi3eFhQ6FwKSdrKwQPHxpzbP50GfxPy0rLW3anE4zLb toAJSBbdeZImszXi+Jf3YZZTT86ykm+e77RdVX63vIrLiZbYubL4DU88BwU12KbuLEnX Wiwk4HjaTndewpkzcPe/GXZaVoMp9H+jcdQiovHqiljvLjZQbSJ02dbl3T41Dk3ikQ5r AozLe2HEoJyiZGAMP0C7wEzNkHufWFaSU+Yzn5E6mZsa9knrbwSYRBpr8ZPoAIKn6Lra jybg== X-Gm-Message-State: AMCzsaXmVBNYJQ/P6qQay/ZE7N7ZbW8koyrWyum3SSbyztqwmLSAVHYn 44Jvs/Po/TpnsjksbEC0UrfuoSJfn1E= X-Google-Smtp-Source: AOwi7QDL6mk4t0dsTf5de1FDG2B+OE+27V0xVxoGzltoW509FqK61RpBaZH4Zk+pP9eF1QwiDR50Zg== X-Received: by 10.84.192.3 with SMTP id b3mr14664066pld.118.1507704328263; Tue, 10 Oct 2017 23:45:28 -0700 (PDT) Received: from localhost.localdomain (ip68-111-217-79.sd.sd.cox.net. [68.111.217.79]) by smtp.gmail.com with ESMTPSA id l79sm411779pfb.33.2017.10.10.23.45.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Oct 2017 23:45:27 -0700 (PDT) From: Bjorn Andersson To: "David S. Miller" Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Chris Lew Subject: [PATCH v2 1/7] net: qrtr: Invoke sk_error_report() after setting sk_err Date: Tue, 10 Oct 2017 23:45:17 -0700 Message-Id: <20171011064523.7902-2-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20171011064523.7902-1-bjorn.andersson@linaro.org> References: <20171011064523.7902-1-bjorn.andersson@linaro.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Rather than manually waking up any context sleeping on the sock to signal an error we should call sk_error_report(). This has the added benefit that in-kernel consumers can override this notification with its own callback. Signed-off-by: Bjorn Andersson --- Changes since v1: - None net/qrtr/qrtr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c index c2f5c13550c0..7e4b49a8349e 100644 --- a/net/qrtr/qrtr.c +++ b/net/qrtr/qrtr.c @@ -541,7 +541,7 @@ static void qrtr_reset_ports(void) sock_hold(&ipc->sk); ipc->sk.sk_err = ENETRESET; - wake_up_interruptible(sk_sleep(&ipc->sk)); + ipc->sk.sk_error_report(&ipc->sk); sock_put(&ipc->sk); } mutex_unlock(&qrtr_port_lock);