| Message ID | 20170830065055.419-1-stefan.sorensen@spectralink.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] net: cpsw: Don't handle SIOC[GS]HWTSTAMP when CPTS is disabled | expand |
From: Stefan Sørensen <stefan.sorensen@spectralink.com> Date: Wed, 30 Aug 2017 08:50:55 +0200 > There is no reason to handle SIOC[GS]HWTSTAMP and return -EOPNOTSUPP when > CPTS is disabled, so just pass them on to the phy. This will allow PTP > timestamping on a capable phy by disabling CPTS. > > Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com> It should not be required to disable a Kconfig option just to get PHY timestamping to work properly. Rather, if the CPTS code returns -EOPNOTSUPP we should try to fallthrough to the PHY library based methods. Thanks.
On Wed, Aug 30, 2017 at 02:47:45PM -0700, David Miller wrote: > It should not be required to disable a Kconfig option just to get PHY > timestamping to work properly. Well, if the MAC driver handles the ioctl and enables time stamping, then the PHY driver's time stamping remains disabled. We don't have a way to choose PHY time stamping at run time. > Rather, if the CPTS code returns -EOPNOTSUPP we should try to > fallthrough to the PHY library based methods. I agree that it would be better for the core (rather than the individual drivers) to handle this case. There are a few callers of .ndo_do_ioctl to consider. Besides dev_ifsioc() there is at least vlan_dev_ioctl() that needs to handle the EOPNOTSUPP. Thanks, Richard
Hi On 08/31/2017 02:48 AM, Richard Cochran wrote: > On Wed, Aug 30, 2017 at 02:47:45PM -0700, David Miller wrote: >> It should not be required to disable a Kconfig option just to get PHY >> timestamping to work properly. > > Well, if the MAC driver handles the ioctl and enables time stamping, > then the PHY driver's time stamping remains disabled. We don't have a > way to choose PHY time stamping at run time. > >> Rather, if the CPTS code returns -EOPNOTSUPP we should try to >> fallthrough to the PHY library based methods. > > I agree that it would be better for the core (rather than the > individual drivers) to handle this case. I'd like to clarify one thing here - what is the preferable time-stamping device: PHY over MAC, or MAC over PHY? my understanding it's PHY and ethtool_get_ts_info() seems already implemented this way. > > There are a few callers of .ndo_do_ioctl to consider. Besides > dev_ifsioc() there is at least vlan_dev_ioctl() that needs to handle > the EOPNOTSUPP. Sry, I've not tried to do solution in Net core, but below patch updates CPSW driver to selected PHY time-stamping over MAC if supported without disabling CPTS in Kconfig (at least it's expected to fix it) - not tested as I do not have HW with dp83640 phy. ----------------------------------------------------------------------- From 51347692087732320f2f5615030f5f36ed3c7724 Mon Sep 17 00:00:00 2001 From: Grygorii Strashko <grygorii.strashko@ti.com> Date: Tue, 5 Sep 2017 15:24:44 -0500 Subject: [PATCH] net: ethernet: cpsw: allow phy timestamping over mac Allow phy timestamping to be used over mac timestamping if supported. Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> --- drivers/net/ethernet/ti/cpsw.c | 21 +++++++++++++++++---- drivers/net/ethernet/ti/cpts.c | 2 ++ 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index 95ac926..8831cb9 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -291,6 +291,10 @@ struct cpsw_ss_regs { #define CPSW_MAX_BLKS_TX_SHIFT 4 #define CPSW_MAX_BLKS_RX 5 +#define HAS_PHY_TXTSTAMP(p) ((p) && (p)->drv && (p)->drv->txtstamp) +#define HAS_PHY_TSTAMP(p) ((p) && (p)->drv && \ + ((p)->drv->rxtstamp || (p)->drv->rxtstamp)) + struct cpsw_host_regs { u32 max_blks; u32 blk_cnt; @@ -1600,6 +1604,8 @@ static netdev_tx_t cpsw_ndo_start_xmit(struct sk_buff *skb, { struct cpsw_priv *priv = netdev_priv(ndev); struct cpsw_common *cpsw = priv->cpsw; + int slave_no = cpsw_slave_index(cpsw, priv); + struct phy_device *phy = cpsw->slaves[slave_no].phy; struct cpts *cpts = cpsw->cpts; struct netdev_queue *txq; struct cpdma_chan *txch; @@ -1611,8 +1617,9 @@ static netdev_tx_t cpsw_ndo_start_xmit(struct sk_buff *skb, return NET_XMIT_DROP; } - if (skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP && - cpts_is_tx_enabled(cpts) && cpts_can_timestamp(cpts, skb)) + if ((skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP) && + cpts_can_timestamp(cpts, skb) && + (cpts_is_tx_enabled(cpts) || HAS_PHY_TXTSTAMP(phy))) skb_shinfo(skb)->tx_flags |= SKBTX_IN_PROGRESS; q_idx = skb_get_queue_mapping(skb); @@ -1810,20 +1817,26 @@ static int cpsw_ndo_ioctl(struct net_device *dev, struct ifreq *req, int cmd) struct cpsw_priv *priv = netdev_priv(dev); struct cpsw_common *cpsw = priv->cpsw; int slave_no = cpsw_slave_index(cpsw, priv); + struct phy_device *phy = cpsw->slaves[slave_no].phy; + if (!netif_running(dev)) return -EINVAL; switch (cmd) { case SIOCSHWTSTAMP: + if (HAS_PHY_TSTAMP(phy)) + break; return cpsw_hwtstamp_set(dev, req); case SIOCGHWTSTAMP: + if (HAS_PHY_TSTAMP(phy)) + break; return cpsw_hwtstamp_get(dev, req); } - if (!cpsw->slaves[slave_no].phy) + if (!phy) return -EOPNOTSUPP; - return phy_mii_ioctl(cpsw->slaves[slave_no].phy, req, cmd); + return phy_mii_ioctl(phy, req, cmd); } static void cpsw_ndo_tx_timeout(struct net_device *ndev) diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c index c2121d2..f257f54 100644 --- a/drivers/net/ethernet/ti/cpts.c +++ b/drivers/net/ethernet/ti/cpts.c @@ -421,6 +421,8 @@ void cpts_tx_timestamp(struct cpts *cpts, struct sk_buff *skb) u64 ns; struct skb_shared_hwtstamps ssh; + if (!cpts->rx_enable) + return; if (!(skb_shinfo(skb)->tx_flags & SKBTX_IN_PROGRESS)) return; ns = cpts_find_ts(cpts, skb, CPTS_EV_TX);
On Tue, Sep 05, 2017 at 04:25:22PM -0500, Grygorii Strashko wrote: > I'd like to clarify one thing here - what is the preferable time-stamping > device: PHY over MAC, or MAC over PHY? > my understanding it's PHY and ethtool_get_ts_info() seems already implemented this way. We simply do not have a way to support MAC and PHY time stamping and PTP Hardware Clocks at the same time. Sure, it must be somehow possible, but that would involve extending SO_TIMESTAMPING yet again, and this is not worth the effort, IMHO. There is exactly one PHY on the market that supports time stamping, and yes, people who design their boards with it generally want to use it. They have to enable CONFIG_NETWORK_PHY_TIMESTAMPING and disable MAC time stamping. Thanks, Richard
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index db8a4bcfc6c7..4413a669fd79 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -1791,16 +1791,6 @@ static int cpsw_hwtstamp_get(struct net_device *dev, struct ifreq *ifr) return copy_to_user(ifr->ifr_data, &cfg, sizeof(cfg)) ? -EFAULT : 0; } -#else -static int cpsw_hwtstamp_get(struct net_device *dev, struct ifreq *ifr) -{ - return -EOPNOTSUPP; -} - -static int cpsw_hwtstamp_set(struct net_device *dev, struct ifreq *ifr) -{ - return -EOPNOTSUPP; -} #endif /*CONFIG_TI_CPTS*/ static int cpsw_ndo_ioctl(struct net_device *dev, struct ifreq *req, int cmd) @@ -1813,10 +1803,12 @@ static int cpsw_ndo_ioctl(struct net_device *dev, struct ifreq *req, int cmd) return -EINVAL; switch (cmd) { +#if IS_ENABLED(CONFIG_TI_CPTS) case SIOCSHWTSTAMP: return cpsw_hwtstamp_set(dev, req); case SIOCGHWTSTAMP: return cpsw_hwtstamp_get(dev, req); +#endif } if (!cpsw->slaves[slave_no].phy)
There is no reason to handle SIOC[GS]HWTSTAMP and return -EOPNOTSUPP when CPTS is disabled, so just pass them on to the phy. This will allow PTP timestamping on a capable phy by disabling CPTS. Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com> --- drivers/net/ethernet/ti/cpsw.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)