From patchwork Thu Aug 3 14:47:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?UTF-8?q?Jo=C3=A3o=20Paulo=20Rechi=20Vita?= X-Patchwork-Id: 797245 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="H7rlEhKC"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xNXwM4sGbz9s81 for ; Fri, 4 Aug 2017 00:47:47 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751236AbdHCOrf (ORCPT ); Thu, 3 Aug 2017 10:47:35 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:36994 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751010AbdHCOrd (ORCPT ); Thu, 3 Aug 2017 10:47:33 -0400 Received: by mail-pg0-f66.google.com with SMTP id 83so1695384pgb.4; Thu, 03 Aug 2017 07:47:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=m7mSGytmYa6lDOSBXNC25cjc8KCEs001uyIwGN3wIdE=; b=H7rlEhKCojTXqPOHm7tq/ymDd92c6ua0nAi9u5vsXUwKUYdUMveXDA3y44PHMt2wY+ OboOGc8s/BnENbUuC/XY5G7bk3YL2rtgA6hRnQ+7Xga2PDA2sMxL2V9uMAjKhisVKBQm F9DEbpddT7aajrlFq5uBWmyewhe9omqxMLfFxdwJ91vyytNAfseMoFmjTsxKJDOSaQJX 5Mmq0+Pv9KEUFeJ4TC7fcbaEoyu40tlJBSBvZmR6AH1WgOvkaGP/8HaLHOjKpznu1T9n UrSRM/ICYRrL91DpPnyOK42I6XkMXWvSyNpK5Hbl1sd6EabmiW0OoPbejgZkcSiosj6j 670g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=m7mSGytmYa6lDOSBXNC25cjc8KCEs001uyIwGN3wIdE=; b=BSYVCQ9hQsACKUsEiwfwvtp0O7IVnYwxiq8QM5X9XY3Lx78AtnQViZ7lMGOtj3CqqG Om7Puofm4d3RdwrvtExYAOiuW6Z6Bge47TkeiihVNBgqfvjATsoVX9fsoNGXQOLNeLT2 ySUFRmHmtswExIynCgf622U5WTMQq2hE1gesT5FC5uEt3PSciC1CySMw30xd99YDxCh7 T/DoO2ha5xLHZ+/lGR1/E0m5fx4/bFvtQKRulXhVGOirliTuNLd8K5wAFqHxYFGwdB19 BA5fM/AksjGh83usJHOMGf1gLQ1CiTp5rBrv0bfBDzoGsWJ6+IKgol/oJtl/3V0J6CUY U8kg== X-Gm-Message-State: AIVw1112Xagb03vHMEy7immiFQgAvKvS7x1PohY6nKUPNP0bbp8EimP4 WuT59QsH9biZ+Q== X-Received: by 10.84.229.5 with SMTP id b5mr2243725plk.216.1501771652580; Thu, 03 Aug 2017 07:47:32 -0700 (PDT) Received: from kiddo.endlessm-sf.com ([2601:602:9602:62b7:9d4e:d979:4672:3ce]) by smtp.gmail.com with ESMTPSA id z189sm55586092pgb.12.2017.08.03.07.47.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Aug 2017 07:47:31 -0700 (PDT) From: "=?UTF-8?q?Jo=C3=A3o=20Paulo=20Rechi=20Vita?=" X-Google-Original-From: =?UTF-8?q?Jo=C3=A3o=20Paulo=20Rechi=20Vita?= To: Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , Kalle Valo Cc: linux@endlessm.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Jo=C3=A3o=20Paulo=20Rechi=20Vita?= Subject: [PATCH v3] iwlwifi: Demote messages about fw flags size to info Date: Thu, 3 Aug 2017 07:47:28 -0700 Message-Id: <20170803144728.32305-1-jprvita@endlessm.com> X-Mailer: git-send-email 2.13.2 In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6DD004A3CC@AcuExch.aculab.com> References: <063D6719AE5E284EB5DD2968C1650D6DD004A3CC@AcuExch.aculab.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org These messages are not reporting a real error, just the fact that the firmware knows about more flags than the driver. Currently these messages are presented to the user during boot if there is no bootsplash covering the console, even when booting the kernel with "quiet". Demoting it to the warn level helps having a clean boot process. Signed-off-by: João Paulo Rechi Vita --- v2 changes: - Set to warn level instead of info v3 changes: - Fix commit message typo drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c index be466a074c1d..c98a254bbd4d 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c +++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c @@ -461,9 +461,9 @@ static int iwl_set_ucode_api_flags(struct iwl_drv *drv, const u8 *data, int i; if (api_index >= DIV_ROUND_UP(NUM_IWL_UCODE_TLV_API, 32)) { - IWL_ERR(drv, - "api flags index %d larger than supported by driver\n", - api_index); + IWL_WARN(drv, + "api flags index %d larger than supported by driver\n", + api_index); /* don't return an error so we can load FW that has more bits */ return 0; } @@ -485,9 +485,9 @@ static int iwl_set_ucode_capabilities(struct iwl_drv *drv, const u8 *data, int i; if (api_index >= DIV_ROUND_UP(NUM_IWL_UCODE_TLV_CAPA, 32)) { - IWL_ERR(drv, - "capa flags index %d larger than supported by driver\n", - api_index); + IWL_WARN(drv, + "capa flags index %d larger than supported by driver\n", + api_index); /* don't return an error so we can load FW that has more bits */ return 0; }