From patchwork Fri Jul 28 14:40:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Pirko X-Patchwork-Id: 794940 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="W+15c6Aj"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xJs5B28sTz9s5L for ; Sat, 29 Jul 2017 00:42:38 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752330AbdG1Omf (ORCPT ); Fri, 28 Jul 2017 10:42:35 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:38389 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752141AbdG1OlT (ORCPT ); Fri, 28 Jul 2017 10:41:19 -0400 Received: by mail-wm0-f68.google.com with SMTP id y206so4645411wmd.5 for ; Fri, 28 Jul 2017 07:41:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ca/msDVKhEwx1uyxw71o72eo26Lgq/NoSV1Fq2hQaS4=; b=W+15c6AjZp9h1vKC/vgp2ynlj+9ETxoS49XFFAunAvyMYMhzgQe1EvLW6cztgSl6bP wfeIm8A3vLDgxPwu/T3bg3OqvQiC0JfrkBazgd0Vymqh7PGmWTIs4CEojsAN8xV5/ynT etJzLxyjK2qL12oBr6kmF8tEdVypMRGw2qJFj/qGo2B/rB6jnbSzxGpG9NXn+2aWC+SY S2VHiPDs2yO6FXkqMR89lJSKRJxjy13cZNV7y2SMIphyjtpe7lO/f9vekSHXxc0WoHEg /N2cuHYrKgbSNbz5DnAu2zWUZCB2oRnN0uUb6orrpU/Y9vdjh+q5yl83Ehu2yc3XTB2Y crYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ca/msDVKhEwx1uyxw71o72eo26Lgq/NoSV1Fq2hQaS4=; b=pe390ew2gV/MYvx6o/3r2I/PDhIlB+qQqd0KhjGYj6/tjw/HWdrYu1gNwWjneZOKEx Oz8px5YhcjIO0k43osioYlG6f1Fjzh0ADYmfZS3oNiisnTAhvUpcH8ee/QW/5VZ0iD4F FvQcN3RjANFQ+N42wRbiEZv+jBCBUCYfexUmaIDk9zg9KhfXrHRFHrlEUuF5GDxvXu7o G5gGAH8VbflcOTiEm785rz+8vqqfSr2TpZwBHPXPNAk4gdgnoewE7EbGeWK/ZaQUDhsG 7RlAs6ngnivef+jmZp2MuARFO7S1k882XDuPukQzAnGs4pMbXRxIWN0kExiykEr0vqGc 6J7Q== X-Gm-Message-State: AIVw113GBrTncNnrmznqB2DmCEWnRcLJCRfBZQb+WYY7WIv8KOYcXNzD V/jT6xm+iaEtLFmoqFA= X-Received: by 10.28.23.11 with SMTP id 11mr6101486wmx.125.1501252877678; Fri, 28 Jul 2017 07:41:17 -0700 (PDT) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id m78sm1949160wmc.16.2017.07.28.07.41.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 28 Jul 2017 07:41:17 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com, daniel@iogearbox.net, mlxsw@mellanox.com Subject: [patch net-next 11/20] net: sched: cls_fw: rename fw_change_attrs function Date: Fri, 28 Jul 2017 16:40:33 +0200 Message-Id: <20170728144042.6380-12-jiri@resnulli.us> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170728144042.6380-1-jiri@resnulli.us> References: <20170728144042.6380-1-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko Since the function name is misleading since it is not changing anything, name it similarly to other cls. Signed-off-by: Jiri Pirko --- net/sched/cls_fw.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/net/sched/cls_fw.c b/net/sched/cls_fw.c index 46a0e32..a30a098 100644 --- a/net/sched/cls_fw.c +++ b/net/sched/cls_fw.c @@ -190,10 +190,9 @@ static const struct nla_policy fw_policy[TCA_FW_MAX + 1] = { [TCA_FW_MASK] = { .type = NLA_U32 }, }; -static int -fw_change_attrs(struct net *net, struct tcf_proto *tp, struct fw_filter *f, - struct nlattr **tb, struct nlattr **tca, unsigned long base, - bool ovr) +static int fw_set_parms(struct net *net, struct tcf_proto *tp, + struct fw_filter *f, struct nlattr **tb, + struct nlattr **tca, unsigned long base, bool ovr) { struct fw_head *head = rtnl_dereference(tp->root); struct tcf_exts e; @@ -276,7 +275,7 @@ static int fw_change(struct net *net, struct sk_buff *in_skb, tcf_exts_init(&fnew->exts, TCA_FW_ACT, TCA_FW_POLICE); - err = fw_change_attrs(net, tp, fnew, tb, tca, base, ovr); + err = fw_set_parms(net, tp, fnew, tb, tca, base, ovr); if (err < 0) { tcf_exts_destroy(&fnew->exts); kfree(fnew); @@ -322,7 +321,7 @@ static int fw_change(struct net *net, struct sk_buff *in_skb, f->id = handle; f->tp = tp; - err = fw_change_attrs(net, tp, f, tb, tca, base, ovr); + err = fw_set_parms(net, tp, f, tb, tca, base, ovr); if (err < 0) goto errout;