From patchwork Thu Jul 27 10:29:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sathya Perla X-Patchwork-Id: 794333 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=broadcom.com header.i=@broadcom.com header.b="n8TF7Bge"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xJ7X90W03z9s5L for ; Thu, 27 Jul 2017 20:30:01 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751546AbdG0K37 (ORCPT ); Thu, 27 Jul 2017 06:29:59 -0400 Received: from lpdvsmtp02.broadcom.com ([192.19.232.149]:43102 "EHLO relay.smtp.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750997AbdG0K36 (ORCPT ); Thu, 27 Jul 2017 06:29:58 -0400 Received: from Sathya-S84.localdomain (unknown [10.192.238.84]) by relay.smtp.broadcom.com (Postfix) with ESMTP id 731C11A0022; Thu, 27 Jul 2017 03:29:54 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 731C11A0022 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1501151396; bh=XS3G8kqAR2iKn72F66EYrnrzr6Q3cqIruvMa2lxk/Lo=; h=From:To:Cc:Subject:Date:From; b=n8TF7BgeQRFXczp8MHvFFZrLImvsDEYAyARpZqITgJyp192zowXo9qHq6Dmnnu195 yS2n1WPKa+Olz5O+quKkdyZIDJlrZw2cTF1BPdb6G6pBWL45U2Ia60S8ZmMjkh4tCb uqybRAacJsPeIMke9Ua81Mpglpy59JMqGMb18/Oc= From: Sathya Perla To: netdev@vger.kernel.org Cc: selvin.xavier@broadcom.com, devesh.sharma@broadcom.com, arnd@arndb.de, michael.chan@broadcom.com Subject: [PATCH net-next] bnxt_re: add MAY_USE_DEVLINK dependency Date: Thu, 27 Jul 2017 06:29:51 -0400 Message-Id: <20170727102951.26964-1-sathya.perla@broadcom.com> X-Mailer: git-send-email 2.10.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org bnxt_en depends on MAY_USE_DEVLINK; this is used to force bnxt_en to be =m when DEVLINK is =m. Now, bnxt_re selects bnxt_en. Unless bnxt_re also explicitly calls out dependency on MAY_USE_DEVLINK, Kconfig does not force bnxt_re to be =m when DEVLINK is =m, causing the following error: drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.o: In function `bnxt_dl_register': bnxt_vfr.c:(.text+0x1440): undefined reference to `devlink_alloc' bnxt_vfr.c:(.text+0x14c0): undefined reference to `devlink_register' bnxt_vfr.c:(.text+0x14e0): undefined reference to `devlink_free' drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.o: In function `bnxt_dl_unregister': bnxt_vfr.c:(.text+0x1534): undefined reference to `devlink_unregister' bnxt_vfr.c:(.text+0x153c): undefined reference to `devlink_free' Fix this by adding MAY_USE_DEVLINK dependency in bnxt_re. Fixes: 4ab0c6a8ffd7 ("bnxt_en: add support to enable VF-representors") Suggested-by: Arnd Bergmann Signed-off-by: Sathya Perla --- drivers/infiniband/hw/bnxt_re/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/bnxt_re/Kconfig b/drivers/infiniband/hw/bnxt_re/Kconfig index 19982a4..18f5ed0 100644 --- a/drivers/infiniband/hw/bnxt_re/Kconfig +++ b/drivers/infiniband/hw/bnxt_re/Kconfig @@ -1,6 +1,7 @@ config INFINIBAND_BNXT_RE tristate "Broadcom Netxtreme HCA support" depends on ETHERNET && NETDEVICES && PCI && INET && DCB + depends on MAY_USE_DEVLINK select NET_VENDOR_BROADCOM select BNXT ---help---