| Message ID | 20170723145613.14007-1-paul.gortmaker@windriver.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
Hi Paul
mark sent the same patch a couple of days ago [1]
John
[1] https://patchwork.ozlabs.org/patch/791550/
On 23/07/17 16:56, Paul Gortmaker wrote:
> To fix:
>
> drivers/net/ethernet/mediatek/mtk_eth_soc.c:1685:1: error: unknown type name 'irqreturn_t'
> drivers/net/ethernet/mediatek/mtk_eth_soc.c: In function 'mtk_handle_irq_rx':
> drivers/net/ethernet/mediatek/mtk_eth_soc.c:1694:9: error: 'IRQ_HANDLED' undeclared (first use in this function)
> drivers/net/ethernet/mediatek/mtk_eth_soc.c:1694:9: note: each undeclared identifier is reported only once for each function it appears in
>
> and similar follow-on errors as seen in arm allmodconfig builds.
>
> Cc: Sean Wang <sean.wang@mediatek.com>
> Cc: Felix Fietkau <nbd@openwrt.org>
> Cc: John Crispin <blogic@openwrt.org>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: linux-mediatek@lists.infradead.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
>
> [Seen on current linux-next, where similar implicit irq includes
> were recently revealed by some header shuffle somewhere.]
>
> drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> index 7e95cf547ff1..ea15eb095d83 100644
> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> @@ -16,6 +16,7 @@
> #include <linux/of_mdio.h>
> #include <linux/of_net.h>
> #include <linux/mfd/syscon.h>
> +#include <linux/interrupt.h>
> #include <linux/regmap.h>
> #include <linux/clk.h>
> #include <linux/pm_runtime.h>
[Re: [PATCH-next] net: ethernet: mediatek: fix implicit irq include causing build fails] On 23/07/2017 (Sun 17:16) John Crispin wrote: > Hi Paul > > mark sent the same patch a couple of days ago [1] OK, thanks -- I searched for mediatek in my mail and scanned netdev patchworks for patches in "New" state but didn't see it because it is apparently already in "In review" state. Paul. -- > > John > > [1] https://patchwork.ozlabs.org/patch/791550/ > > > On 23/07/17 16:56, Paul Gortmaker wrote: > >To fix: > > > >drivers/net/ethernet/mediatek/mtk_eth_soc.c:1685:1: error: unknown type name 'irqreturn_t' > >drivers/net/ethernet/mediatek/mtk_eth_soc.c: In function 'mtk_handle_irq_rx': > >drivers/net/ethernet/mediatek/mtk_eth_soc.c:1694:9: error: 'IRQ_HANDLED' undeclared (first use in this function) > >drivers/net/ethernet/mediatek/mtk_eth_soc.c:1694:9: note: each undeclared identifier is reported only once for each function it appears in > > > >and similar follow-on errors as seen in arm allmodconfig builds. > > > >Cc: Sean Wang <sean.wang@mediatek.com> > >Cc: Felix Fietkau <nbd@openwrt.org> > >Cc: John Crispin <blogic@openwrt.org> > >Cc: Matthias Brugger <matthias.bgg@gmail.com> > >Cc: linux-mediatek@lists.infradead.org > >Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> > >--- > > > >[Seen on current linux-next, where similar implicit irq includes > > were recently revealed by some header shuffle somewhere.] > > > > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > >index 7e95cf547ff1..ea15eb095d83 100644 > >--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c > >+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > >@@ -16,6 +16,7 @@ > > #include <linux/of_mdio.h> > > #include <linux/of_net.h> > > #include <linux/mfd/syscon.h> > >+#include <linux/interrupt.h> > > #include <linux/regmap.h> > > #include <linux/clk.h> > > #include <linux/pm_runtime.h> >
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index 7e95cf547ff1..ea15eb095d83 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -16,6 +16,7 @@ #include <linux/of_mdio.h> #include <linux/of_net.h> #include <linux/mfd/syscon.h> +#include <linux/interrupt.h> #include <linux/regmap.h> #include <linux/clk.h> #include <linux/pm_runtime.h>
To fix: drivers/net/ethernet/mediatek/mtk_eth_soc.c:1685:1: error: unknown type name 'irqreturn_t' drivers/net/ethernet/mediatek/mtk_eth_soc.c: In function 'mtk_handle_irq_rx': drivers/net/ethernet/mediatek/mtk_eth_soc.c:1694:9: error: 'IRQ_HANDLED' undeclared (first use in this function) drivers/net/ethernet/mediatek/mtk_eth_soc.c:1694:9: note: each undeclared identifier is reported only once for each function it appears in and similar follow-on errors as seen in arm allmodconfig builds. Cc: Sean Wang <sean.wang@mediatek.com> Cc: Felix Fietkau <nbd@openwrt.org> Cc: John Crispin <blogic@openwrt.org> Cc: Matthias Brugger <matthias.bgg@gmail.com> Cc: linux-mediatek@lists.infradead.org Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> --- [Seen on current linux-next, where similar implicit irq includes were recently revealed by some header shuffle somewhere.] drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 + 1 file changed, 1 insertion(+)