From patchwork Mon Jun 26 15:36:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dave Watson X-Patchwork-Id: 780763 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wxCpp4zlKz9s03 for ; Tue, 27 Jun 2017 01:37:06 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=fb.com header.i=@fb.com header.b="HUzTiflz"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=fb.onmicrosoft.com header.i=@fb.onmicrosoft.com header.b="KxD3O/zW"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751476AbdFZPhE (ORCPT ); Mon, 26 Jun 2017 11:37:04 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:44750 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751366AbdFZPhC (ORCPT ); Mon, 26 Jun 2017 11:37:02 -0400 Received: from pps.filterd (m0044008.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v5QFYOj6009073; Mon, 26 Jun 2017 08:36:57 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=date : from : to : subject : message-id : mime-version : content-type; s=facebook; bh=QTnILfbm4yKpWH7R9z7udwFRNsUQlCEN1LB06ymit0U=; b=HUzTiflzYUhYH93EcP9wy67ag+51jqgpi8kODr3HiPYsG9xPulApJeg2R+EO8CEZQ/mi bUuBFzGtcOGnK4yBlzVy9NP+euzdbLieNv6tJ+RMOB2Qgr0qTDU+qUuWdc/T0kbYkdlY OMyxRp4Bapm/XP+ydTEsnhhRcO9LKodzF5k= Received: from mail.thefacebook.com ([199.201.64.23]) by mx0a-00082601.pphosted.com with ESMTP id 2bb0ft0rp8-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 26 Jun 2017 08:36:57 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (192.168.54.28) by o365-in.thefacebook.com (192.168.16.13) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 26 Jun 2017 08:36:55 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector1-fb-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=QTnILfbm4yKpWH7R9z7udwFRNsUQlCEN1LB06ymit0U=; b=KxD3O/zWDMaK4y1b8u6w/ld6T4YL7VsdSUfnnMZ5RBzEYaJDPAx2KtGhWd2ZMASK3zVjRWJuuNKQlmE9A1jpeRNvEK26gNdWOZCNb36hFF8QdZiXYjjaZTAEKJ5y7A17qoakCJbcrvcttmlZI4Q+zQqKorrweOQJlnRTLbGqOhQ= Received: from localhost (2620:10d:c090:180::1:7df9) by BN6PR15MB1748.namprd15.prod.outlook.com (10.174.238.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1199.15; Mon, 26 Jun 2017 15:36:53 +0000 Date: Mon, 26 Jun 2017 08:36:47 -0700 From: Dave Watson To: Ilya Lesokhin , Aviad Yehezkel , Boris Pismenny , "Levin, Alexander (Sasha Levin)" , David Miller , "netdev@vger.kernel.org" Subject: [PATCH net-next] tcp: fix null ptr deref in getsockopt(..., TCP_ULP, ...) Message-ID: <20170626153647.GA15170@achao-mbp1.DHCP.thefacebook.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.6.0 (2016-04-01) X-Originating-IP: [2620:10d:c090:180::1:7df9] X-ClientProxiedBy: CO2PR04CA0059.namprd04.prod.outlook.com (10.166.88.27) To BN6PR15MB1748.namprd15.prod.outlook.com (10.174.238.138) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7ff9a57f-038c-449e-17ad-08d4bca92bae X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506067)(300135500095); SRVR:BN6PR15MB1748; X-Microsoft-Exchange-Diagnostics: 1; BN6PR15MB1748; 3:jr/wc1J8ZZ+o5un0OuDIivLPmpzK5oJVtg9oVXQ6dC567F9/jvduxDBs4jpkjGa3zfQmHIn1KPvGVbKBRSqIo6EYp63qbGxGE/RlZpp0X1XIgAujO81hzFdPIUUq+GSe5d3XQtgvtcVD9Y3v4topfzRC1zovkEUxkcS99U523MSyY2EhxC7wXWDv4xIiKETA4vrdJNiy2d5z2E1uVVYOrorOdPdGOCa7kMUh0LvHIr6JaYqn0JdEVrQ/r+jETe9owk675PNo+5xoxIUqhBpAjmTGQIk4ycxQtlNdDcWbx4WHuoGGAzgJ+2IPViPoUDOj4ti6BjeUWEEdrDtBFTbkptImMB05cJ8U+ple4hTR5StfLlMzXJpRduyZOOl3M4/JjIniqxy5fOOR1CbcJ4EMXsCWHSdlOCYyhmwl1TVhUHUVXKLhMgazxa3xSLCkAvYrxRsB4HBsQZpgxp8lt5QyVtJERShzjEZxwvEj2lN+HTY64Xh9etTE2G2WbDrPBew1in+EuNscUtc1Qz/7gbfiJa7IhIreSSHeJrmEWpNIbESP+dkctfga1DuAzFo0l0byJ+S2pKrYKxjdjnLYC63bRGb2BgJNP4bw+DjsP8eNQ0hSyHK+YS+k28bifv6qXKm45gQ5IQiu8Sg9AiKYB2UKdSdDh8+p5uoe13yjlE3vngDMIsGjmehh3lPk1vV+qiUyyHkvleToBGlVD7EDFO841UtJIENteCHGfsXbANWsQM8= X-MS-TrafficTypeDiagnostic: BN6PR15MB1748: X-Microsoft-Exchange-Diagnostics: 1; BN6PR15MB1748; 25:1dHDmOVsJ1vTnj36DzU8dLIuKBKTeTkxvZYE7IknsuH2dr68sGl75fi0KOHcI85l2Axl4ThvB3uiRJdwUOsHepdsankvqc1sV0du3EYmhrLTjq98Bg7OBbOtDnLXgzW/XbL2/tHb9v5/q7R9kfAP7gQoX/5/WQBlDlYEpq5HoHalTv1tUw+NIro1lWprDtyZiGCjfbgu59PdFK6P6mnO5olyGEMDztRcGi7MUkUEcf0/RxrPwO1aKF4QvTv32y4mTokJF/rsv40/yLeH2mplwanEs8VphoympZxZwpu48sW3tNL2axjXn3Ka4bemPc+xodm0lpmugB7K/rEkY47LaLOB0Ai9nqQ1tTDA/oX4kCZdEDM4jdJoY2S/zOdXB+Nh6we//ieBpNEBG6hJbwNWnFdnFYfF8InGssv/MnuovjHlzO70t/G9IVZig2iZUgFKykIw6ftj0hjHjx3e0/Tt4O2KQJ7pqkMrXnEgeGfFjLRbCI47BCMvYvpv2ecVPc0iIhmlPyY1l6R+v1qUYVCr/ToYAMJhUXi/KBJWt4MU9KarPL6APfEQUWCgko+Ig4FKBplCn6iGK3wnDK+jwgoBaJngnI4Z7/wJi3gE+Wh2WmqVUNZlIYgcIGbf5T/yreemYwLajLnSuMDyFjnL2my8PyPSyVHpXYqIHBd/9EgxdcQA9tDABmqF1euuLF+kUJLDrF7F7J0lKEjNqJTWO60rj857k41nE2rFNufaaG6zxx47ha06YpJTiUMSR9FZLQlexjalhZLCRlAHS/ZbobXtuJRfwjStA7F4m3TdlzzNfef/MXd5+K8wVfeEm51g8pNkil5yPVBJv/nKDHlKf48L+ALb6xnxAiDuf7kuT/gCgk8UgpLTbxSJuGzdYoBurpsgUMGFdQSBnj9w0R8hsk6eTdRoq86sXATGYDUB/uUWTTo= X-Microsoft-Exchange-Diagnostics: 1; BN6PR15MB1748; 31:pc6dlzbV+ImKQcMcLangXko1nidNHUAiHE3W5sCRU9tSs57gMM4nQP0J12NVXIqd08iQsa6/5+kevP+1CsVQjwXupAwNGs5MU4emmSbc86OQfi9segbtPk6XU4UMA5Merbzk949owe+1dhxIVO3AjYvDg3ziwiVuD7/gSghhbSPXUFauXDCq52FDIFp8XY8LjP/ct6dwYIQxKAOI/sGqCqCoUIlgLSkWJ44xgkaRow8Q8SHB7JlrFpNLnTzbvx88z8LwCoiKDwmRGEy9fnWCRFy4J93ioIL4HpAWz7GaZXfhbjGGf9rnMFabIdlEeZZulh+mFx4/k1HTlFlbrbNoHILmaaEiF70VrLgXgGR6fYLQnuByLBplXLSdK8o/gpqqjjD1qhWKCnL92em2phBhQQ2bfAKUEA0h35TSjVpF1HVIGKTlmsdp/pXhuxHola8m4cioJlDk/iWZMAAc34v6TIrxz7SZbBMtq1mzVc4GOYhVvPhgiRB3tJMcA+hCNIaPi/+WfEqx5EAMfOsAfzRJ6zwSSx35adZMKYxOkHsOHAplZIvUMdPqQ3Tg4wUF90YId0KrFcfaLHfxS1KSl6JHSweroIQMOkAnp2YtBo3uqus76M0FFdYVL4YwPyc6upsVfk4RNPUh8UPGcPuqXwtuoX9Q9yYayYRhDx7DDBJgP9F3TT73gjKTtfG4vefiTJMoDfMJC2Eq9ezXib8cVfT6KA== X-Microsoft-Exchange-Diagnostics: 1; BN6PR15MB1748; 20:jnUvfsNUKpidtvHpiY9F5lcYJn5jCEqr8lixJt4e1aqOGS4acXlIHetxxMDHu70JMX0tjbKNh8w3POL7opiltv17t3N/pPMiEXYNQOhtRFwkf2SPJEkn8K3qML01Ons/OZ6rv8GZbsmZxM6OlQxOZ+ANpGSMvaLM5SZb8ijUtAzBBXQ30qxKgQhMZ5w2pU1aqMrOGsN3C7eLvQPkqGKmnFsTveiAns4ZmatKdMaDF6RYCxJOfUj9ACIWZhtiprVi9yIZ25v88E/VYY0cRt3igGyPd3KhdmhDRGP9UREiCxf4dJOvkkmFqeWzB7bRfMANqxe8/NqSVb/nM9Rmvpi4xP0SNfi1j29RlGX/2QCHshHbxHrBR3iufsVVSwwzgukgUO7aXGEmEgppA88TkN7XK8GOHOUT+RS6ZH3Rs4OOpkVByn2Q0v2q/u6Ok0HbwaaVRJlzw4ser2t9da1shj7J4N80991E6nD6swfOnQ+ibQyg24nmD0NlaAFscyIVbyLJ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(67672495146484)(154440410675630)(266576461109395); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(3002001)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123558100)(20161123555025)(20161123564025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN6PR15MB1748; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN6PR15MB1748; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR15MB1748; 4:j0wNM/2WCt2B/qGLQRr1A2DOKy6WLWTJloIDNdOXzP?= =?us-ascii?Q?BZsKLKWTP8iR78A0rkT7BpXvCFBue1sA76edKCBDi5PGQdekSnXJ5LxATu6I?= =?us-ascii?Q?rZJTHkAWvqszlb19l8aYInMCN9R8W4jmCkt0wmB6m3hEibmGmNqLwOkY55EA?= =?us-ascii?Q?pfkNISULqKRxg/XDrboW+iIuz6BbM5It7oVNPNCL06O1marZLpTsf0beUdO4?= =?us-ascii?Q?E6WEOT1mkTHNezAGMb0gj91yJunay5RLGTr07f/49DJ2PxrUqvz+hzyHCsIr?= =?us-ascii?Q?z9eULmrpkvDHSgIWdjmPo4TZYoBhZWESt41Yr3yNVO6pBHVqkgZgq2CACFnf?= =?us-ascii?Q?SYn8m85Y/51f6XmcTNdgUALwhtQKD0bZs6td+VGcLY2rtGV96Ph9ovKOs7bY?= =?us-ascii?Q?GHC9bQd8O2d5O//Zk2U6mdz/BmCeOu8ASm8n2VRv61KZE9c9Bg4uLQW5p3Jg?= =?us-ascii?Q?HLyvJ//mtq/oKQ1V8OOhPD4kwHlIPUHiwZOvmDl9o4DhOnT8RlrARjlc08Sn?= =?us-ascii?Q?XtBbYe8ba9+dHL7D8eO5ljxftQrIccb0gKHl/WhAMvyzy3niDb5Uw+mnbPxb?= =?us-ascii?Q?DmDiX6xrQ5wWocQMPISNsxAQ0BvbPqo2oiPwOwhArbiDZAGuf9vydAK9ENiY?= =?us-ascii?Q?Q2vQL+3kZkklzI8pNh2P1XES9h06e6302vPf+7YT9yC/yRCsUZneMVkW00Sr?= =?us-ascii?Q?35JxktwG37HWqIDQlyH3FEItxxHLgr6CEe1SQeRMHRSfmGIZs/0fC6d2ULz2?= =?us-ascii?Q?8CRj4USHhzJjRIvDTtaTrp20bORX6Od2QzV1HuJTOkwJdzcISquwf7fqGWVR?= =?us-ascii?Q?TMtu6TEhbbNOLZoKH+HJecxP6amMF7ZRG8N7pFHrsRKJGMZUiYg508AkBr+H?= =?us-ascii?Q?OSrYQq+8f4Q6McJcNXfOkwglK+Ly6shyhLStjwpgysUbLGQ8N+fidBejXzlM?= =?us-ascii?Q?8qsf5q6/s7C6ESWLXCmulGagaOaQ9Eokj+Asuiw0S/dFEZu9J+wwGuNsKoW1?= =?us-ascii?Q?9LI+yzDseijl5Lx/HCu0qDfvryW3SvkeuQpS+o2e0sNwZZF0B1bprY3Th8iu?= =?us-ascii?Q?qYC2WdFYlYjdFG5KTuUQmksCYiX/1qScily6WnWpIyXt3K0tP3plT6/70b5d?= =?us-ascii?Q?W4prCNNNa+okDicJFpyHrU/VxPls5MI0DuEOY/igaQBWHUsPP5DGkU5vORiC?= =?us-ascii?Q?bKXWGkuoAE9jmKv8OP9GXUrVnT8THWT3gB9KQns/+guncCmbgwZEGiIktscu?= =?us-ascii?Q?y/pVsY3rC7wJYoi3DrGW3QIUtq/J0DzTZbljZb?= X-Forefront-PRVS: 0350D7A55D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6069001)(6009001)(39400400002)(39410400002)(39850400002)(39840400002)(39450400003)(6496005)(38730400002)(5660300001)(2906002)(6486002)(33656002)(4001350100001)(83506001)(6666003)(25786009)(50466002)(81166006)(8676002)(9686003)(7736002)(305945005)(189998001)(53936002)(6116002)(23726003)(1076002)(50986999)(54356999)(101416001)(2501003)(42186005)(47776003)(76506005)(86362001)(478600001)(18370500001); DIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR15MB1748; H:localhost; FPR:; SPF:None; MLV:nov; PTR:InfoNoRecords; LANG:en; Received-SPF: None (protection.outlook.com: fb.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR15MB1748; 23:YWvunu/doP43vwWx0BYqYxWjx7/tPstXF6NesEzm0?= =?us-ascii?Q?hsqLj6GIzYZh1N63buVi9NMkRA4+LreGbfVInGCoCstt0hm5G/lGJ49WSnm9?= =?us-ascii?Q?NU1yRmlWHgchJ0QpKUBSN5XsthkMy/+GnIt8earEPEcy6XUVzbd+qPWJAnqF?= =?us-ascii?Q?hJjAnTaMB8NGt3prgsnOOmDCK5XpLYkTFBwkrTwv+obUr9XNBZ5VV4yEPhhj?= =?us-ascii?Q?5T6Fyz1PhxAGiUaiS6FQZZ163zy1kQSUWXMC31zQf/GtazqAi/gLil0MQOaW?= =?us-ascii?Q?39PBUwNA2ESKinAxOW3wtN86WS/H7jG4DxRnTGkSGHi0PYSphzP/YQVYZmON?= =?us-ascii?Q?V5MlaSd/n+WeutZyPcbzyE22l/TjEnEE6M38RiFKpXiq47UIFJMAvriIW/E8?= =?us-ascii?Q?MHah9sB8JKxEv05rGhrdwlsJUcXcgzdNZO12mXCvOE1uq8iGQWsw9tZocRMZ?= =?us-ascii?Q?5bohLgQkGuIGsFRhC0mnjAjNKdg1u751IykKHVfAEVJUakpsNKMVS/OAF1Kv?= =?us-ascii?Q?O61Pg/Z8UIl8n4hdESQ5uCNm/3YXrH0ji7sG5lQK6v/zgLmfIDu8PmNw3G4N?= =?us-ascii?Q?6BLtPLEZL7bl5QYaVmJM0V7yuqqGDeV8YQ62MXg+MK/VCpJpNOkHFdHI+Ihp?= =?us-ascii?Q?tWYxMBu16EhMK2qi0clBZyqXYKGjPAHmgfTWLbgP3V29FwFmjooGElZ5wXz2?= =?us-ascii?Q?OW3ppKwJ9FpSXDv2sVe/lH+sAJhiGDdHQY/R15yZOlDkor7ZbDfSV4L793K2?= =?us-ascii?Q?pfw6WC24UyTgCrz487R5ql7h65adVWpdRBOKutpGwZnZFzgiQ7qVB0TFQcwD?= =?us-ascii?Q?bE1DLCiOBRMh5dO8TqzKrqC5qhQ4Ebtid/5yH+XpzB7NmV6ebVtqMt0C6Cif?= =?us-ascii?Q?cfGQu05BwgiPNazholicINyWBhTKaxPHC6o56Ib1/nayY96BIwQGonVFLi8k?= =?us-ascii?Q?rzZ76nM7V8mKrEIuXjdgyNIf6G8C+C/DRFRbkRPe9KO7VyN+VauzxdYhAn0K?= =?us-ascii?Q?0a0+0+gpXi93wUMzk33qE0a?= X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR15MB1748; 6:/HWNCibWJ41fjvbKrhrJG7HGda/OdxNSAkWcuMkSdS?= =?us-ascii?Q?H0uqB4gpYSTBf/ShyKbSOOvzk7ps6TmiSodtmVRVOhor3CzA1bGnWtZp/Bee?= =?us-ascii?Q?jsq0YS1Cs96ynHPVnBFUZEbAzDpGQhnFwJ3S1/NYqTPpQ7eVop3OEbZW2mst?= =?us-ascii?Q?R6cAEVNqOsUFJRzJpAjGT2WLM8U2FfQep8wnXnvi3odMQyaJQssY2tc9LE2e?= =?us-ascii?Q?kos54A/CooFl2+c3h2aAd/ypAvfIK/26F9/oVubMMsWFJBS+Qo0uyd29rnXs?= =?us-ascii?Q?VNGIc0rpzrxlZbHdlci6wf01492qlmKeRf4dv/mur+ZbUnU2t08biwUWhzFQ?= =?us-ascii?Q?jIqnDqmKJhQF0v6C7JNTgU/Kwwr70jZVJURF/CmavqzDpEJXLmP/MvS8c1rm?= =?us-ascii?Q?QrDJxK7aPgvdhWspeA0HPmbuXXe7qOrVjityxPZ2Jz6rqn5RlAdQIwsZRNu9?= =?us-ascii?Q?dcDOOb4o76MzPXf1AkVxOxpFXsrUXiz6yziaNkousSJGxJWiQDi6beyNIk7i?= =?us-ascii?Q?owaTuFJ2WkZombjmTXacjoDIqvTLrV3ARxHb/gFUDc4M5wIBaeYr29tmfptL?= =?us-ascii?Q?2cDyVH+wooMuGn/mOy55nIW/9WUWTIbInA3Eu5ghI0NaE6tithIQSEyvSZo0?= =?us-ascii?Q?QpzNh2Si3p0r7A0ZB2OtLCs+Pp3EdU7IhB5PbcYRReH0p3Q5JHUeSZc9VPlp?= =?us-ascii?Q?+ftebLIKqoOrOvB/zo5BZSRdf1qlZK1PbSnyEfw+vuLWOdVBoCTD4Fy3mV9D?= =?us-ascii?Q?fPRkFPqsoX3HltOiifa05k/uxKbC5lxaMTBjxC6gK1DEdmnXn3v41iUG5qX1?= =?us-ascii?Q?vnsh75TRzZzWEdsaqwCVc0fytI6ZwdfCt15xjpMFAs4NgpBp3RpEBVwipMS3?= =?us-ascii?Q?6q2LfiFW568/LlqVxuOza+FXjvXRC+VQy/CnSdWlZ45+GmJEEJ9t+nruZzXo?= =?us-ascii?Q?85CO4cF+57gYgqgGLmFeZ5IHLCVfOA/4TiLsChPcsRfvEQdxuGTH6eLezEjc?= =?us-ascii?Q?Q=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR15MB1748; 5:8g8aPlvmeOlAqGRzXJ49aQitk2zc+2Ol3yvqZBPmx1EUu5UsZqKn08aEKpZh4/o4v7tUeIas+JFh9FknTz1M0VJM0JvRECEY3ch9eHvTzxrrBX5YGm7ZzkfH9VB3hyxhzxJWKnnfSJfdIHN9INJiT+GTGGZ2QpncPFJmYW02ocNUq6rWIEWFcFuqq7I0vRHCveIaQryl24p6zIXbn7/25QC13k2FgonY88KHjXVkM93Cn4RkqmwQEiQNdqef4y1pICdElneSA8c4EtTlHFvDoyYwHqrfdfqXG8AMHJJivgutp+PBw0Y8Sm/eBZBSXDbX9ig5L2OkGLb+8o8HqhCqxcNEiVocrsQvwt8DtH4qr1pnr05T8QZH8tr7IlARXm4kWdpeWYWPVZzP5MUNoTqNW4JgD6580u/0fkRLlNgNvU2Tt/hiUNMnlqdbCrR+8uzED9FdEutoAnN2sKIZGIZEm0XMq7KpyouA3+a1lXUNUpTwnssl5USS4DEPm+aCy7kw; 24:06mVyL1nucvmLUQOicPMogMmOPFGurJkv47jXos2iGbZUylcQEpEcOe/WzYp7ckGxJ+vNeoSKeWJVBCamCXu5tIDIyCSd3Q0qYtuY4DiUsE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR15MB1748; 7:5gKxUhGzOobteINTc1rXYU/OF1TJvKJF9H+KiALbMvQJXwjZ30sUFvkqXL5E/PloJ4/Vk3AOLBm+r9sbYkUW/xald4OZRlbZoxj15oTgXIzb/tsmEwzugkyMsyRk++YlvflM8BFdTx2o3csaE0nUweBipH4kY9+6N3jfUTwToxfVw11ZRaqCHnm+KO51syNd8Gn7ff94fa32cFLHOuwhOdg5WM6bTbbwtQJNHBihVggn+LlVgOO2lfQvSUnaLGtaPCGOa/42ZKb0fLt00a6pbVKy1Ob7grFeS8jmxuQOEFBOH3ERBv+Xsyq9FV8I1MYU4uW7jmjv673ppJoNSFR2eGIgvnFpsvkjjtf/56ylLhkI+S5cqEPOix2PskSalhvrsDBQDOc0dJ8wMUxdoJD58zp3rTvJxRRkaOcS1PbpWF0kjP6aGCUT9hz+5Ay87IaOLy1M975eb5MZ2ot3CZ5eh94I1v100Qtg6bgu3sYOvev/dFn82ZLytjDUqnfTzh5OJTQjT61XymoSwsRijlx4a/zD0k+dtaQm8xAu1Xwm5NGjA/mj+dMAwWkkW1IV+PAok3TELBfg+ixI5ZBwl/c8TrOA4v68bFEzIl2eJmkzGCjEsTmniiafhINp5dZhzYTUsbS96MEasD4FD+EZHRAhqhpk6SOtj95RGGj6ituO0Xe/Q+cLhy9kwlpfHyVYdakEgDy0jLapi3Hx64on+tpyvG2elKyVIzLzu8d8S3IsUEQrF5YYROF12u9Y8KNWWz3ECGOQZhYr3W+BmWypd1kvc8zuxakYbvgQWzuGnepDQIU= X-Microsoft-Exchange-Diagnostics: 1; BN6PR15MB1748; 20:4WOh3M5bbOhtBJ+IrACXVlXaYHWHzhRxgSoQ7J3VXI1kdTXTF0AUUe8HkTa5lnGLHcG8e7mw7NaQtMHZTfag7AGv8LJ3HeKX+0SyN1jV1NgkYjqDTLoZhsnELIKcQmpArrD4UISLBjDl4AGtQQRkPU+J8taFu9MC7uO/vML6DDQ= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2017 15:36:53.0744 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1748 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-06-26_11:, , signatures=0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org If icsk_ulp_ops is unset, it dereferences a null ptr. Add a null ptr check. BUG: KASAN: null-ptr-deref in copy_to_user include/linux/uaccess.h:168 [inline] BUG: KASAN: null-ptr-deref in do_tcp_getsockopt.isra.33+0x24f/0x1e30 net/ipv4/tcp.c:3057 Read of size 4 at addr 0000000000000020 by task syz-executor1/15452 Signed-off-by: Dave Watson Reported-by: "Levin, Alexander (Sasha Levin)" --- net/ipv4/tcp.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index 058f509..4c88d20 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -3062,6 +3062,11 @@ static int do_tcp_getsockopt(struct sock *sk, int level, if (get_user(len, optlen)) return -EFAULT; len = min_t(unsigned int, len, TCP_ULP_NAME_MAX); + if (!icsk->icsk_ulp_ops) { + if (put_user(0, optlen)) + return -EFAULT; + return 0; + } if (put_user(len, optlen)) return -EFAULT; if (copy_to_user(optval, icsk->icsk_ulp_ops->name, len))