From patchwork Fri Jun 16 17:24:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Andrzej Siewior X-Patchwork-Id: 776878 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wq6fy6F2Tz9s8N for ; Sat, 17 Jun 2017 03:24:10 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751958AbdFPRYJ (ORCPT ); Fri, 16 Jun 2017 13:24:09 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:56430 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751706AbdFPRYJ (ORCPT ); Fri, 16 Jun 2017 13:24:09 -0400 Received: from localhost ([127.0.0.1] helo=bazinga.breakpoint.cc) by Galois.linutronix.de with esmtp (Exim 4.80) (envelope-from ) id 1dLuxs-0006Rl-DL; Fri, 16 Jun 2017 19:23:20 +0200 From: Sebastian Andrzej Siewior To: Eric Dumazet Cc: netdev@vger.kernel.org, "David S. Miller" , Thomas Gleixner , Sebastian Andrzej Siewior Subject: [PATCH 2/2] net/core: remove explicit do_softirq() from busy_poll_stop() Date: Fri, 16 Jun 2017 19:24:00 +0200 Message-Id: <20170616172400.10809-2-bigeasy@linutronix.de> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170616172400.10809-1-bigeasy@linutronix.de> References: <20170616172400.10809-1-bigeasy@linutronix.de> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Since commit 217f69743681 ("net: busy-poll: allow preemption in sk_busy_loop()") there is an explicit do_softirq() invocation after local_bh_enable() has been invoked. I don't understand why we need this because local_bh_enable() will invoke do_softirq() once the softirq counter reached zero and we have softirq-related work pending. Signed-off-by: Sebastian Andrzej Siewior --- net/core/dev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index b1f8a89322bd..447d37fe89e6 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -5281,8 +5281,6 @@ static void busy_poll_stop(struct napi_struct *napi, void *have_poll_lock) if (rc == BUSY_POLL_BUDGET) __napi_schedule(napi); local_bh_enable(); - if (local_softirq_pending()) - do_softirq(); } void napi_busy_loop(unsigned int napi_id,