From patchwork Wed May 17 15:24:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Holger Brunck X-Patchwork-Id: 763666 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wSdb24fwnz9ryb for ; Thu, 18 May 2017 01:31:42 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753632AbdEQPbk (ORCPT ); Wed, 17 May 2017 11:31:40 -0400 Received: from mail-de.keymile.com ([195.8.104.250]:47372 "EHLO mail-de.keymile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753426AbdEQPbj (ORCPT ); Wed, 17 May 2017 11:31:39 -0400 Received: from secmail.keymile.com ([195.8.104.201]:40121 helo=totemomail) by mail-de.keymile.com with smtp (Exim 4.82_1-5b7a7c0-XX) (envelope-from ) id 1dB0pC-0000Oy-0r; Wed, 17 May 2017 17:25:18 +0200 Received: from 10.9.1.54 ([10.9.1.54]) by secmail.keymile.com (Totemo SMTP Server) with SMTP ID 790; Wed, 17 May 2017 17:26:28 +0200 (CEST) Received: from ch10641.keymile.net (ch10641.keymile.net [172.31.40.7]) by mailrelay.keymile.net (8.12.2/8.12.2) with ESMTP id v4HFPGnQ019300; Wed, 17 May 2017 17:25:17 +0200 (MEST) From: Holger Brunck To: netdev@vger.kernel.org Cc: Holger Brunck , Zhao Qiang Subject: [PATCH net-next 2/8] net/wan/fsl_ucc_hdlc: fix unitialized variable warnings Date: Wed, 17 May 2017 17:24:33 +0200 Message-Id: <20170517152439.8817-2-holger.brunck@keymile.com> X-Mailer: git-send-email 2.12.0.rc1 In-Reply-To: <20170517152439.8817-1-holger.brunck@keymile.com> References: <20170517152439.8817-1-holger.brunck@keymile.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This fixes the following compiler warnings: drivers/net/wan/fsl_ucc_hdlc.c: In function 'ucc_hdlc_poll': warning: 'skb' may be used uninitialized in this function [-Wmaybe-uninitialized] skb->mac_header = skb->data - skb->head; and drivers/net/wan/fsl_ucc_hdlc.c: In function 'ucc_hdlc_probe': drivers/net/wan/fsl_ucc_hdlc.c:1127:3: warning: 'utdm' may be used uninitialized in this function [-Wmaybe-uninitialized] kfree(utdm); Signed-off-by: Holger Brunck Cc: Zhao Qiang --- drivers/net/wan/fsl_ucc_hdlc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c index 0ae10a58ffca..6ef6d719545d 100644 --- a/drivers/net/wan/fsl_ucc_hdlc.c +++ b/drivers/net/wan/fsl_ucc_hdlc.c @@ -440,7 +440,7 @@ static int hdlc_tx_done(struct ucc_hdlc_private *priv) static int hdlc_rx_done(struct ucc_hdlc_private *priv, int rx_work_limit) { struct net_device *dev = priv->ndev; - struct sk_buff *skb; + struct sk_buff *skb = NULL; hdlc_device *hdlc = dev_to_hdlc(dev); struct qe_bd *bd; u16 bd_status; @@ -968,7 +968,7 @@ static int ucc_hdlc_probe(struct platform_device *pdev) struct device_node *np = pdev->dev.of_node; struct ucc_hdlc_private *uhdlc_priv = NULL; struct ucc_tdm_info *ut_info; - struct ucc_tdm *utdm; + struct ucc_tdm *utdm = NULL; struct resource res; struct net_device *dev; hdlc_device *hdlc;