From patchwork Thu May 4 15:15:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudarsana Reddy Kalluru X-Patchwork-Id: 758616 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wJdtJ2S6Vz9s3s for ; Fri, 5 May 2017 01:17:12 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com header.i=@CAVIUMNETWORKS.onmicrosoft.com header.b="NccQOef+"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753605AbdEDPRK (ORCPT ); Thu, 4 May 2017 11:17:10 -0400 Received: from mail-bl2nam02on0054.outbound.protection.outlook.com ([104.47.38.54]:55794 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752687AbdEDPPg (ORCPT ); Thu, 4 May 2017 11:15:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8KW9aJ0Zx/WJrkFVavqkSq6DtyeLG5pnI7vCja39ejs=; b=NccQOef+NSwAeZu/U8kuylcaI1YbS++rANdoTP83lj/PsavpvskKj1vNQsLk1kJHDOjXeAiOfStmRbN0k5YvGppXuLc2/9LXmHzxupivgE6vHvtNk6o3dcrjGIg8K4zpQ8FepMO1azUUVvP6jvLkxBLQoHuQXNRywA9d+LJ7Pgo= Received: from CO2PR07CA0044.namprd07.prod.outlook.com (10.174.192.12) by BY2PR0701MB1942.namprd07.prod.outlook.com (10.163.155.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1075.11; Thu, 4 May 2017 15:15:34 +0000 Received: from BY2FFO11OLC014.protection.gbl (2a01:111:f400:7c0c::192) by CO2PR07CA0044.outlook.office365.com (2603:10b6:100::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1075.11 via Frontend Transport; Thu, 4 May 2017 15:15:34 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BY2FFO11OLC014.mail.protection.outlook.com (10.1.15.48) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.1047.9 via Frontend Transport; Thu, 4 May 2017 15:15:33 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Thu, 4 May 2017 08:15:25 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id v44FFBAY004456; Thu, 4 May 2017 08:15:11 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id v44FFBdT004455; Thu, 4 May 2017 08:15:11 -0700 From: Sudarsana Reddy Kalluru To: CC: , Subject: [PATCH net v2 3/3] qede: Fix possible misconfiguration of advertised autoneg value. Date: Thu, 4 May 2017 08:15:05 -0700 Message-ID: <20170504151505.4407-4-sudarsana.kalluru@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20170504151505.4407-1-sudarsana.kalluru@cavium.com> References: <20170504151505.4407-1-sudarsana.kalluru@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39850400002)(39840400002)(39450400003)(39400400002)(39410400002)(2980300002)(428002)(189002)(199003)(9170700003)(87636003)(8676002)(76176999)(50986999)(356003)(101416001)(478600001)(1076002)(105586002)(42186005)(2906002)(33646002)(189998001)(47776003)(2351001)(8936002)(106466001)(81166006)(86362001)(305945005)(50226002)(5003940100001)(107886003)(50466002)(38730400002)(48376002)(110136004)(5660300001)(4326008)(2950100002)(6916009)(36756003)(6666003)(80596001)(54906002); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0701MB1942; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; MLV:sfv; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11OLC014; 1:xmj1ejmvpSSGi1Pjd2RsRD6G70Zct7R95J6W1khKRUu0StrB9sTz0rEapR9h1OFxa44dyToHCI+1i2xMFXxBBNLyt3PwCxH3FUvZG4iPxm8g6auCZ4emz/c1ncKapktrzC38cSqgn+YvxF+z38k30NIlBg2EfbuFjywNLhjyTRKHyPABQGU3OUQAakkZxgUceyUQoRlnMdZvEBZSAMpvdHvjYPiXN1OCo31DMaqpxsLEyZyJwQAASJx8pvcLYW4DbT7ncLDBORYHLCZJxSWBAaOKjRa7IqrRvL36rYl3vQAO3DMCcJgaW4vz0gcg6J+CTiN/SwLSVC0aAgd5Xge699Q7Fyknik5pmBvbWGC1qQENtV4fzsWNShRYcd8rg59B7EMYzACZCbppm5MYUbiLqDOo2r6/j9wCrb2mvCMTAHS4eEWiiJNFc6RoYLmfKjAjWBOSN+b0rIv7qS2HcUHbl7FkXffCNVOdD7WGXL/rTN383JASmvAMBqwMFIhfzxcL0weonD7zV2lK8EN26MHY0lIEMp1SbGH0qeH5EPEk0n91oLhWn90Oy3ypbAk8AZKo X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f262d855-cf12-47d4-426d-08d493006924 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(201703131423075)(201703031133081)(201702281549075); SRVR:BY2PR0701MB1942; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0701MB1942; 3:bZ7zz3/ZhbFOlfgE244QEC+CeYKciAwiAqQ3M0HRJFnpKJifb+ejp82vJOclUVn92MKM1RXySAzWjjEjWY35wySCYegGFXkEYZcP56I4PEp4pfTfNKbhyp8rJl/pUvq6SGbdVjyhtS+CzZI8lMN5vJBYeSDkMTiYtFdDgehmaV08h2Wc80atzxyyBfVj61jpyOh94GIupKK1YcxNdZ/80+28oao7mD5dmlE23iO6DPQfd5dkJU+o56Z3OhRMlnL8FoEWyQqHTegF7C901q5U51EM00hzGQqP4zx1XerEO+tE5BdBcWSMVJijjB7ZPjT0fCu7aSwtvseItPo5bgiAFiAGnMSttDrSn/W2nqV21eNJTin61xFk1SX2DbveQsTlxO4RAX+vciJzfKkHneOsrF+vBptlEZu4O78QILabLpSwmNxN09LPYerZ2G2HVqEtu/XG293Nw52v+mvdoNx82F0vkO8T5f09OKL+16RMOkiICUHZ3Xl3hUP8Wtx/g7UN X-Microsoft-Exchange-Diagnostics: 1; BY2PR0701MB1942; 25:4bq9fLd+712sKvrgopM213Blpbuu0dYV626PgfGFmvCUu9uXeb57EGk3wTEEjuls5i/Ol8cpnpJ3fQwHK/yp0FEtEDPhAK3oI0UTsYH20UhaNUr+MI+n4j2EvAf9Vhe8bP4P7hnZHgn/AVhq6hnW6+msWka2/SsqVpV0VwHazcBdvDXDyqri7UcSQ59hVxmoBFvevJPtsZTi4zV3OFFjts1Ux0jgqOdZmcfKglzUokTneh8utBOZV/3cvCepImJ6fUy/GQc855ze0eUTdiVptXvYcISN5p9UaSJ0rvovf/kQlAhAb0AzJFb9/ZidLDdYF/qH8GJJ3AT2eUTHnAZ0VxbHFcgXS1Sf9kHHWfvxA5AsaYK2JB65QZ+Z0YAM8IjeFLq8gqrxJzHtfVVo//kJFk8TXSP5pOsCuA8lDm0zSLUaQHVJkFaGOalXgvY0vwC8bZ/bfr9OSxn61OQ1u8V3CYgltrGzxRpuzNARgvfH1Z0=; 31:yi4TLnwGe6jUsroqFPUm2uBeitYwlXhr53MkAzEqeuDyJO/BEA6Xh25Sh4MrJ0yO6YmknsU2ZgzH1UL9U+GplKq+x6Ew6rN3kKwGfdVUkJAsAEEU2GEpJzHF2Qx+kcXsYdez8UEV/PFu8dGV1dbTtd+ZXQCXE/vtKODrai2yq8h8Qg6I6MQTEDIcHQ6YrC63jnxS0XgCWsvVktJc/JZN4kTBAxVUnXNQxL1k2stLxtSZ1JtUGalO3ca+gnF5CFZaKZXx3kVuZeBu6I5onPbRIcfWCpnZ/fn1K/nyaOqG4vI= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0701MB1942; 20:B8y3rx5xA8DD/T4AbK+oHG9xSbxgsHtg9eelHqfLpunt1T4NH6pqCpCaTi6KMQ+fPrm+ccMzlABQbBQGFrH8zGHn7uCRDX4X1PxIkmJW2kO/UEEakm3VbM/WWHsR6bjkwP5E3kDY+g9whAubA0KeSHwNadgv+uh4JD20ERLMvU/em8U/l8QYmegpszptN0sGD0v+JxgbijKyCv+I6N8clgDvpn3ZC4XgfxIlRjDAoAk/AnKCCsot9VsBBvkc2AiZ8jxXZj1Ja144gyoCCuIcR/u7RcfMjeEL6nYITuZZZWqUzkg99SFZ8ecaeGkXOhmR/i6uFQyClsQKJBEYp+gBvvUX1F30kPNagn4kgwIik31cCA4Y0h3qOMoL2FyCgyM9fnfwoAveRy2LvbR3Lfxcc124UmnS5rfx/Q7cDtk1xIS/CE1kB+TAwGGp9d35pMy/WbbGECLddx6xbR/JEjckoK91R0OwmE9qWeJ0/mOUSJ4XGFU2KqkRcIXMIziGKS8e X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(13017025)(5005006)(8121501046)(13015025)(13023025)(13024025)(13018025)(10201501046)(3002001)(93006095)(93001095)(6041248)(20161123555025)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(6072148); SRVR:BY2PR0701MB1942; BCL:0; PCL:0; RULEID:; SRVR:BY2PR0701MB1942; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0701MB1942; 4:tUmFa+YID3idKlH45TQu0fiX/ow2/CNPLh4x2PaWgf6T0BA0RW+Xewt+W2ppZ4kWG3bF6gjeXGv45dKeNGWVoA1ybHxHaKMneIAw701ZBd5POQDlDHsdGZIFcQWTHGeknbXUu1Z+UxJC1lztKUemSxy8Ju4gPjE9W5sxPSxCEClqyU9NNak4O4T3WW0Vm1mmZHZOeEmnyEpAUv00mCYqBdpXgSdpqtQeNc3ItHvbEYDJjYJaMj2rjbjPOglAKomQXZoFh2XTtlD76bAS+qkC+heZRhysyR/xBgmHbOgKf+9+XggK5nBJ0474PqXWfGan5K1CGtvufl4MpOA554djG8sgDfAXGRCG2ua95CahzTL0rIkT4Tm7PPVcgTkr2CyC1mPVBczAOKl4vV1w83BGM7grOoYLSz8rxPqq0cCLoM5TrchlpwvGg8SUENUFg73eVo3cXMU7WzG3fVfn3d/01l29J+DGycuxOGZ3gWsQ9YyQ2eiTx+U41H0bN+cUbmSgmDXSUgc/aFN8eys4FKS9n2hF2WgQW7sLmUwkY0bmcP72QfrRmC5ccLVuI4SYEbQB4GYMKNnRl/bD1Y4Hk8WaP4orEqn56eMRQRPCuinpIOY5VZliMJ90leFKZ8g4FYcklCpY1qydXVIiORXzG8svTZbO5lwZj7LidhnXXcReQMvXKIEfmirCyaod3SJLGI2v6llMuGdZ+FJyyALluWeBaiEU8KU4nOYltpymTDTv8UX0yLpw+SW/ytkJkPC87tTqPweJW7Zbfq0+7rRFcyXIBP76SjBgMsIiHZHDkL6T9180Svo6rO3GTgE5rBUkMAA5y3RIsIzZdVLVtCt+MUTdiSuCsE0F1CCyXNEamuimYkS0Y4ThbUyoPVH+el4eQZy+ X-Forefront-PRVS: 02973C87BC X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR0701MB1942; 23:RTap2kR5bw+NxpzTxUJhakpxlRvxCyll40UpFTK?= =?us-ascii?Q?noXVOoKL+j0URwo+n35LvqmNdt0s6bDwEjmNOI2eKPo5Bfh6ITfgoTY5MEOn?= =?us-ascii?Q?FbjazTEO0q9hoFLLk5IU4MEeW2Luu2WqgT3+BBn3DnBCv25zaK6OI3k5xLlZ?= =?us-ascii?Q?eNQhhBpJ+Od7BjAf48WkGUZtA6N/lAxXv5TvepiZDLoXhq9FXw3yoX4QJNLF?= =?us-ascii?Q?RMzXzsNvui6tMxbhOKxEOgqL3zwJLkkNy5+GJA76dMk38UukT2thVBBr/UAM?= =?us-ascii?Q?KdW9xlbk1nIkbsS35YGpeeVfiX4w8WN6SPQacWmqQEReEV7bVQLXc5rzhwV6?= =?us-ascii?Q?tEBsWsve1YDTgDO30FFffo2sygvM+p+GSXwKPBaQPLbzTSsZEy2BK8oOkZka?= =?us-ascii?Q?eQXWNBe4LJ5uwoM/YLHL4NREi9u8D1umJhXnHWoj9626m7h0I79f1pwJDNuk?= =?us-ascii?Q?ldJe46B/T5cTWcne0zkrgxtX/2v0qQo/+Ff0YyWHSQQ0wvuzXoG7G8AbqEGZ?= =?us-ascii?Q?mPk2q8eGzrtgPB7IYgT1VzZhqi9DCnYYrfjPoWD9GKBfcae6BN7/lEFY8A/J?= =?us-ascii?Q?WEYUjDN3Z/CsItjjXC7PwCg/Ti6Ja8af5GAcF9HEzFoKFYgIDQ0vzzbZlfra?= =?us-ascii?Q?TnB7ms5hk8Wn2cM+97fQ73Ul7rHlaQLRGMahu4m2byULxm7sFTZs+B5dm4Lc?= =?us-ascii?Q?VrI4bUET4a5tQBVa9o0IVtwYsxHRVRIaHzdB4ivsmpClfFPdtdGknJUTNSvi?= =?us-ascii?Q?j4Bg0o/gA0MF0aT/0A40HKz/afFu9Ty0hAKE/adVV+YXJ54yVPh2q/1J3FI+?= =?us-ascii?Q?+AMKhQlAgUZSX0v2O8EhqGn+xOhAHz8idIjrYVjbXtUS+z2ohdk+0L+o1XFs?= =?us-ascii?Q?Iq9ROmDr5jUTUJpG8KyT6bxnuBiR/wDIdGHufteOMSPR+iYJkLF5S6dlBBAD?= =?us-ascii?Q?VaQumQX3mMIqXndaSbkDeP9FjI50kS6Cwcu3/nlOP5jOAbIV3huRBtKJjNm1?= =?us-ascii?Q?5jEO4VtPOmtvwMHeuQTxvVNfgnNxqMGc03LsxtqHFZtvivmiZJxH/au1gfs6?= =?us-ascii?Q?bnLbvY9IyCjmBQWILU7lkEZ6PYETd94IH2hD5jfT3tlGGtaOkzA+avX2hyAf?= =?us-ascii?Q?5v7lsEnAQgU6t1sMcFyOJBQf+UjK9j+++?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0701MB1942; 6:6mDpPp9Mr+9KnUCDmrcsTlpDutINSrF+6IV3sW0szKafYeL/hcGO2vJFwc7IC6OiLOx4JYyFaxIAzuD9CD8CH330dMaHG3Su8gDipgfTFus4bqhfE9WreJCjcPUp0bEQEGcneR+mG2tFCDRzjvUVpBCdPsO9p/nbYZaUFdfVrkM62cyR32pdofXLNiKBYFlWn63rJ4Mncge2fOQroTkOQakrfCxxtV2Zcs+NCYk/f5Csy8xroYtRKVfbUWdSRXmfqORRPe6zbnOoMjQMWm5q47z+uDb515st9+a2t7Ki3xYjf4iqTsFCyuBRZ9Hr9KsEk4rV2PK+Jt/4EHMAU31Ega9k8TzHYf+ksAuJb+KLnk5nmOw8xha1t6x+2vA/wnLAiS/wCkG96Xbh6n3QvWYExZa94Qf1qIddHJxb59qOeH2xONxp5BZWZplYIWsSkTDJZT7cMnvzVB9nATTrDKX0Q+5Qq86oH7nvLVQoce1O4y/vJqM8g1eMYlu4RWWMdKVL9dLSKpItw40sh67Ckx7frQ==; 5:4oJV51DnrgfKz4IDdD0c4b9hIRoL214yyOIr+tw/UjGbrKOQJ8pH5/jeG+6SkC3QB58Sx3WxD+vTZ8lvn7PCFWgGXJT8QpxeFPN+SnEKWuVTjtBjZlyS7o03X4mQ9CbjxkthJIUg8VEEHeBNGQSMzQ==; 24:jA7/9I038gb60bAI0m6EMT6ZCT8vZvUJVSNbnmvvu0t+DJgqOuAqcOaQV+KNQBi80n8aMn1sNDOPcTcvqBmFt4wlpsvgiSdkWt4SwBtyf/c= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY2PR0701MB1942; 7:w0hsqILPkULl4qQzYzZw4/ts6ZMy2mhBYkbUM0w9eZa4v6xc5v294/UOQ4g9AnciRM89CXelxn8A57CEzHcmNH4nRJdaCZu84OCYaHdvThzayFuyoO+N/COEF2W7ahbgxHw+1aK3Fcth9OCwvvYcbbWy4uo3hDRUHa/DLg8pZny0QPa4jIf+GqXtz+3CX5mrSDhRBfkXQSLH81Rt4cc0C6T5XgYwGL8sa8lCmdU6SWYwc+gi+tLGb1pBzfbVaszvNp07wf6yiVTHwQ5LRe2YKCDbvqDoMRFWsF75HntiF2mTyytwG/Jn/N4GFTvcEp0p+AX7srPAKl6qM8SU6+OKQw== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2017 15:15:33.7165 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0701MB1942 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fail the configuration of advertised speed-autoneg value if the config update is not supported. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c index b22753c..172b292 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c +++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c @@ -493,6 +493,11 @@ static int qede_set_link_ksettings(struct net_device *dev, params.override_flags |= QED_LINK_OVERRIDE_SPEED_ADV_SPEEDS; params.override_flags |= QED_LINK_OVERRIDE_SPEED_AUTONEG; if (base->autoneg == AUTONEG_ENABLE) { + if (!(current_link.supported_caps & QED_LM_Autoneg_BIT)) { + DP_INFO(edev, "Auto negotiation is not supported\n"); + return -EOPNOTSUPP; + } + params.autoneg = true; params.forced_speed = 0; QEDE_ETHTOOL_TO_DRV_CAPS(params.adv_speeds, cmd, advertising)