From patchwork Fri Mar 17 18:23:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Manlunas, Felix" X-Patchwork-Id: 740416 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3vlDHz62vjz9ryj for ; Sat, 18 Mar 2017 05:23:59 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com header.i=@CAVIUMNETWORKS.onmicrosoft.com header.b="G7xB/Vir"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751275AbdCQSXt (ORCPT ); Fri, 17 Mar 2017 14:23:49 -0400 Received: from mail-cys01nam02on0088.outbound.protection.outlook.com ([104.47.37.88]:16448 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751100AbdCQSXr (ORCPT ); Fri, 17 Mar 2017 14:23:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=5dt4vw9ILICp3hdUSFaWeJSHdWmKfhZPHlP8Cn/IEGk=; b=G7xB/VirsL+3it9xGjSIykHZb5bGweeK0FgHzGyoCA3og1xk+Fz3uj9ntJWYqlgN5ssM/Km4Jv1V2i7rXP5ONokowHC7TiLadccStFQuayD1NIdr7GxNRxr3gMMTvuh6XvL8sUNfxh9/2LNxdZCGWCOM3teyvrPvsnheOZYzOIk= Authentication-Results: davemloft.net; dkim=none (message not signed) header.d=none; davemloft.net; dmarc=none action=none header.from=cavium.com; Received: from localhost (73.71.186.126) by CY4PR07MB3175.namprd07.prod.outlook.com (10.172.115.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.947.12; Fri, 17 Mar 2017 18:23:25 +0000 Date: Fri, 17 Mar 2017 11:23:08 -0700 From: Felix Manlunas To: davem@davemloft.net Cc: netdev@vger.kernel.org, raghu.vatsavayi@cavium.com, derek.chickles@cavium.com, satananda.burla@cavium.com, ricardo.farrington@cavium.com Subject: [PATCH net-next] liquidio: add debug error messages to report command timeout Message-ID: <20170317182308.GA2319@felix-thinkpad.cavium.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [73.71.186.126] X-ClientProxiedBy: CY4PR13CA0043.namprd13.prod.outlook.com (10.173.156.157) To CY4PR07MB3175.namprd07.prod.outlook.com (10.172.115.141) X-MS-Office365-Filtering-Correlation-Id: 28ffdc7c-551d-4650-d152-08d46d62b387 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:CY4PR07MB3175; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3175; 3:lIPIWMFsRWZuVkZhGDCJeO7Y6vmrP6X0VVPXxo1hXoI5nnFWob7d4dei0+IawuasH0tCxiLvmSrXR44M5KxyzUuu7oAXpAwcmjzDJ00FZAoKQ0iGKppK6hYoaa1QjOZILoshRZoTygNEzHGvD3QRd4t2v04HwbOcGLkg5SLOaaMeZwLevq6UM7jYJf65+z/zsCg6UWqP435K52BJsJaHcmDBZyzcpb5lKruS8XzvheTSWlWMOJFBa5F/AHvSBMlKkBndF38luJpYta588YKcQA==; 25:S/QzZksjUv7iQAlfQQTb1FT4QyNd6DVfKolKdZuPR2gMRQYz1RCGZ7Is1oY3hGAxpc2Zg4ldgwBE9f8dyhJpIecsM1ml6YT9fyOdk02dkPxzUa3btLTo3Lt4fQ8RRLlr2fFUdrfcAltZnL99uE6ag7gsG/qT2WDKzeM0Nyq/KOi4losiid1nQ9BTYgxP5MPOXQ+kIGNhkFJr6Jwq7sCiDsuD/YVZAIT+tKVCzzrCUcsVhktJ70myE8nIe/68AmJAVreTmgdkAy7JdUwUbVnIzxIBdY6i1Aq88dtPJrnquKsoL5HWoDv6bhImqqFKhGmcUP9aDaCiXPKL6ku2w7cVTROdGcSeYSjqbZaJ5f3Yg8AHYh7QSVkacDXRp4c64oxlJAjaGoF5cDgwwpuH/PIxKcIsZoa/MhHuo71OIGrLZ9RLw7gdb2ySFWbKpXV7VDotjGQ+1/6AZaMWdcDYZY3ygw== X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3175; 31:mVWR2oygQGJ3eBuT0FEpufbY7PsnuiICOM3Iye478WoA8PhhpwxKQ6fKmqdCORDmgnUGanuZTbOtq6zI4DMjv74MRrH+mQ1YEEQixXi0y04tnXuDw6AwAtnXynuTGHV/3LnvyHy/nSuw2eepTTDXtXGFQCaVEn+hOrhTAvvvKRG6LQzeRIi9cOQuNit3gXh8a0m9bVSQAnDhldlqZWSw3gN0PICKM2pKXKO9t0VKgDeFk/P1GAFOr2w7MgNYvKfMy81u5N4+7Av5kPXq69+Ojg==; 20:xukEjbaHNwlx7FhOcMCBOOecewgrHCsH9cEPNOVrcdi6SyZ6/P1j1JxkyjEIHRPfAZanCzN4ATv1fL0Hip+tbxf4CP1EX4lVIMx3sVS0suIHuNN7m9rgU1uPtfd+gh8wHpNTWPTtiq6KLeAaHWGXLkDjKkNS3O1u9OZvGEnU5oTPM2Hks/evVNe6wBFRZn3+idBdtIkrIKhlhbvTPgq0piQSUlKTf2fF5YmVPeztNLA941CB2++kB8E0l3g/6p7p+XapN7pGEpdteAY1c137ZUT3rSUxTNYoj9s2Nnjnv+B/UoAT4RkCmhLwuUKvOckcUiQurQVXCFbtn2TsHCjmq2cwdKl4RaTxcH2kxYzCr45uEU8zsOJ5ylFhuP0uJ/cdBLYy3L87AdiO0bvLnoM5wGYhxeA5CfBWI+iCA2pJDWPt+J7miQ5p0EeZMmaq5jDmJZfuglM0cZmWf+HY7a08Ie6vJkg9gYCXCtmJNLUKk85krRaP22zmU4Z9uDu12F7N X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123562025)(20161123555025)(20161123558025)(20161123564025)(20161123560025)(6072148); SRVR:CY4PR07MB3175; BCL:0; PCL:0; RULEID:; SRVR:CY4PR07MB3175; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3175; 4:NxQHNaxZz+vsytDsuJVlc8lTP6L0D0Oy3u3I2GT16eFT8f8ZRHDe6Q/NSiXXPDhthGrk5kAS9d6LgzLDcxEtRZ+PxowNGJ2MpsjPlr7XN8JcArrNmKS0I0vPUFVsZYwkOTLm71UzeOKzSzRlDYrD2tEefqS6VBD+/VbtfQmEdLVb6G2PI/dYh5lLgvdJWXLEMBgUVdVzwotxEPR0ok5W9qc8rhv3p6/XLyXvYgn1hL1qbzzBYaAV5rjDIpXEEr3gzVta/sSlA/+vtvba/n2O//ZmejrPBYzXxuVa1b7FW0zyTES6X8c3zL+iuguDxSGvNG1aNFhf7pK7psIqkY9PH/Naf+SYuaj0CllaU/F0HaehTnl9/RcT4WLrsyuXMCZQgvguUCmKe/8LWVcuRGUj2c7Srv9KHy7R/xny8saXrUnnptIHONUUF1etQWh2HBLlGAN69ZQQeTv1AGU9s3Op4xAwxAedIEKJ7RwAK4PDIDFiZwdfNCiz5selSkQIwTusmsHMdp2k/kvqN3/LtWn0bLtzfGdBX37nntoat14tx9VrNXH6XCYIu2ZUbbRPniBG9Hg9yDyK6EhcMwbgBJn15wED7grWO26nWgf+AZxkgIs= X-Forefront-PRVS: 0249EFCB0B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6069001)(6009001)(39450400003)(39410400002)(4001350100001)(50986999)(6496005)(2361001)(86362001)(2351001)(189998001)(23726003)(305945005)(6486002)(8676002)(38730400002)(25786008)(110136004)(54356999)(33656002)(107886003)(7736002)(6666003)(76506005)(575784001)(4326008)(6916009)(1076002)(5660300001)(66066001)(42186005)(83506001)(15650500001)(50466002)(53936002)(3846002)(47776003)(2906002)(6116002)(81166006)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3175; H:localhost; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3175; 23:TCmjk/QyIZVCIFgqs53fINWOCWPJdKIH7rICeGLoz?= =?us-ascii?Q?Tc2CpGRsvjiJlXlGf+pk6MtirVzQ7CU32MCvIk4hHD6ICoEHUECiTm6Xanvz?= =?us-ascii?Q?J+EDUqHxfVeB2bZUCtz2eYJf3ChN4mFlN+owZTo+4a+AptPPI0ggSOPdKzQn?= =?us-ascii?Q?hrzARrQT+B2gbbd2oUvyuW/6HNGcy6nAUQmbhmbWRG97uw3YMtZOgEh9u6dd?= =?us-ascii?Q?RVukcszG34iEEtYYnKXdgr2INxxt90ZIbjjuT2PJeC0fMZuiMpx0lCtmpbBE?= =?us-ascii?Q?OIOfHu8jl+gTRMFeRFVM1tMLCvmnrjGubWCjoTCtR+mV5RlNXdiP1jJuHeHH?= =?us-ascii?Q?fQwRKTKB1PcEy8x+Dsn9h2CHmZYB9FBqk53IenQg9LcmUx3uAIQP0bLZeMjP?= =?us-ascii?Q?D8GYouHxoZPgqWlSy9muBrLB9lncEstwugs6hyQarpUyTgRJF6ZwHCc+QpOC?= =?us-ascii?Q?BgNL5f3qor4ToJpD+7oZQET9oCgz86YjtXZIJgoS4MjCm4SnK1efooE1Z8wI?= =?us-ascii?Q?A4a066ANmZZwwKf3VgS9AC3eqChxbhM5l0KnHWdJt3aTLuufhhAS9C2MfBLg?= =?us-ascii?Q?J0/5DF50KKkqVijWysnVVur3f0mQaT8h8eBlfJ4gBJJ7Mc+VdkEOx2eMkbsP?= =?us-ascii?Q?RuawTSizUBGhUI8rGpxPMWjlWjJROT3iRsOepB43DWtGslJ9TlJY2phanMcX?= =?us-ascii?Q?IbLRaePWKoJ590krte1V8/gklfJ0HO0qfUCwl8MDBy8KdmZwqHKLa1cQ00t0?= =?us-ascii?Q?/7OEI6lWjCY0mOOxFs3HNmGBjq6hEKYkTfBlXDh0XV/PsRZKjWgv7J2qxlyb?= =?us-ascii?Q?4f8ORHEdpNftnNKyTSR+wns7Nnm4lxfcRXzn+G55p+7zahJCqiNDLsukIZkb?= =?us-ascii?Q?Qrv45d/V0IRTSWmfc/sFqBSIc1UxHVbnPKXsS8260QP+GbevKanPNquTyqTH?= =?us-ascii?Q?aXZjfdU5HZn+Gn0debVGCiEcJXD7EAoyr7bU/jnCIqIb7Z48lshRIkTgEee1?= =?us-ascii?Q?zl6ADrQOxvXr+GXZ/OZOsGH2EfX1q4t3U97iMoie5nqVzhkek9SY3tG3RVh/?= =?us-ascii?Q?Ei3Hp0=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3175; 6:PYaF4NsiYTe3sPNUAydYZkTqFSKpDu5Q8qGzQLDevnjbbIOcoxYE09URAA9RJV/yczQlRFvQvwRKTdHj58K+axXrLwvjsvTi6vejd90WvL6a4EydYASrrxTqxtc0Qe/8YfjDPgsT+5rUwOUEWlR+PoGBcKoDxPPWbIaO3Ddod4lLJ0gjheTnOO96LKfjuOJm0W2Y24IPBOq8Sf2w15nlNwAdGY5hdVFh3QzAuOXnk0RP0ABPUDcAihmFlZmQWBZ/M1VHOdUMNPUFk+jc4D4JAS0Zm7FvSn7LfENVCHTQ6Ax+8R3s541F6UZinVeFcP2uHAgXIg2qPml6WEzAGW8f2P99DjHEXfQA9mIEK+lsAmLg9nMlH0VcPFoxUitxU0/FUQYeVXff+ByXj8KVgUmvIA==; 5:ir3IvtYep8qgglntrTyu8/+IUuyhVaA5b0tdMDtcQJ6qdWzILKtp1HGQ2o1WBNdD30KQTKh5WFBGNn3PsvQU37hQN/eOJRTjB36nPEL06io2cIf/MpPLg4hDJ7Sh6pViV5ZvW8Tq6aE/6ZdWATWRLg==; 24:xxeBwnkX5E63KnkK+F6P/nyprb0y82mHfsBq4KLBziBb62nwniXBjHhluGRhCdnDyN4og7enllbVPMf1pjLiDPrMk7CQ4pm7K8IZIlAy61U= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3175; 7:54AXcqIcSZ6TMFZuDKmMtqXRWWRRknbjE2lv3LRGK7zhxoKK3zRqSWyxIcNZFyDqIBtz32PvMQ3uT/zapsiuXTESadH9yD2NQ7I6S3HNf6tQJRnc1Q+BWPw2RYs13AoGJEO3mJfiUKOpezSDor7h4lVTz7D6WvUNGX0abzMZJvZs1mKOOgP69S4Otz7EzKj1OUnZ6HLpp+n31W0Y45eFXjIFzXWCmrX3dcSbG3Ada6u4eaT0qdSbRJi5eO4D9v9NyA/K32c5odwfx5QmMzh912Z2vUgR/4UigeHoupc+00bcyg1lsDckGdXqzKgayvQ1NT66e4FYm3gKtlMv4N9ipA== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2017 18:23:25.0416 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3175 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Rick Farrington Add timeout error message in lio_process_ordered_list(). Add host failure status in existing error message in if_cfg_callback(). Signed-off-by: Rick Farrington Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 4 ++-- drivers/net/ethernet/cavium/liquidio/response_manager.c | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c index be9c0e3..046d816 100644 --- a/drivers/net/ethernet/cavium/liquidio/lio_main.c +++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c @@ -2209,8 +2209,8 @@ static void if_cfg_callback(struct octeon_device *oct, oct = lio_get_device(ctx->octeon_id); if (resp->status) - dev_err(&oct->pci_dev->dev, "nic if cfg instruction failed. Status: %llx\n", - CVM_CAST64(resp->status)); + dev_err(&oct->pci_dev->dev, "nic if cfg instruction failed. Status: 0x%llx (0x%08x)\n", + CVM_CAST64(resp->status), status); WRITE_ONCE(ctx->cond, 1); snprintf(oct->fw_info.liquidio_firmware_version, 32, "%s", diff --git a/drivers/net/ethernet/cavium/liquidio/response_manager.c b/drivers/net/ethernet/cavium/liquidio/response_manager.c index 2fbaae9..a50ee98 100644 --- a/drivers/net/ethernet/cavium/liquidio/response_manager.c +++ b/drivers/net/ethernet/cavium/liquidio/response_manager.c @@ -113,6 +113,8 @@ int lio_process_ordered_list(struct octeon_device *octeon_dev, } } else if (force_quit || (sc->timeout && time_after(jiffies, (unsigned long)sc->timeout))) { + dev_err(&octeon_dev->pci_dev->dev, "%s: cmd failed, timeout (%ld, %ld)\n", + __func__, (long)jiffies, (long)sc->timeout); status = OCTEON_REQUEST_TIMEOUT; }