From patchwork Tue Feb 14 12:08:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manuel Lauss X-Patchwork-Id: 727797 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3vN1S34Jh0z9s1y for ; Tue, 14 Feb 2017 23:09:23 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="T+uK4soe"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753394AbdBNMIl (ORCPT ); Tue, 14 Feb 2017 07:08:41 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:33441 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751853AbdBNMII (ORCPT ); Tue, 14 Feb 2017 07:08:08 -0500 Received: by mail-wr0-f193.google.com with SMTP id i10so27405657wrb.0 for ; Tue, 14 Feb 2017 04:08:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=XnoWvlwL+XAHyFdGQI3vqj1F4QpbMJ4/ngIk2oK5WQQ=; b=T+uK4soe7ZvjSQ5kzHP7VT8mL6DvoBWM0J4iv9zaw+51/VJwryq2x9e8fvbG/yIVpc pclTJI8hG8cUX1si/3xnXYMTCk0V0W//FzheoQWV5R+k2+3ZLDH3/kuqpGRfArgvxHoQ Np1vOSGweDtnN6m1l8VV7f9Qbl3PJmQQrnHOk9ZiO9oADvRxRJ+SF+528lcBLvopG7xg k4UQhNRWn52y3n+tQFoB3ZrEzCs++YlUuAjjJcX7wyJW7xgGLPD26Mx6q3+tVXbwI0AK zYEaRwJblDzuIMw3SFMTALogx/x7898TA+qBoN7bljppQfgyzDwkQjedJK90hQeturDX NLOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=XnoWvlwL+XAHyFdGQI3vqj1F4QpbMJ4/ngIk2oK5WQQ=; b=MUrcYxQv97CzuI/6Fg52dIiy90TdRPp2ZfVxnep2lg0uVhXpEjhhzDl91w/LStbI1A qCu06gmFCf6xxU3uDTPjQaPoR3cCisDC+zPpUJ3JjaHubw94eB5MVW2ALga73er1ebpa sRttUhbpjyozAf6zkDCrX4X8uINLyqrUVYyihhHvUQH06usPLprZAsu4axnc1BZHwgiz wBdhUN6yU6IvHFAn1L2ZJLUVS8Ljjf1KQ9aDmk6R/tr2YfEm+Su8mmW+JQKsFpuuBR+0 Q8oPd5DNIhGDVgHCV2QroIx0FDEZ+o9JPPakMjuQ0xYhOBDRSkTPb0it0aHGcrhtNxWd kb3g== X-Gm-Message-State: AMke39mKvum4ai5AhXQpAUseEWx+PgqU0CtyDGxVUdWABpVllSX2OjPnOlYnk2S91rD0dg== X-Received: by 10.223.162.133 with SMTP id s5mr26432987wra.157.1487074086926; Tue, 14 Feb 2017 04:08:06 -0800 (PST) Received: from dargo.Speedport_W_724V_Typ_A_05011603_05_020 (p200300C023CC14391746B39401FFCB78.dip0.t-ipconnect.de. [2003:c0:23cc:1439:1746:b394:1ff:cb78]) by smtp.gmail.com with ESMTPSA id m84sm1037585wmf.10.2017.02.14.04.08.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Feb 2017 04:08:06 -0800 (PST) From: Manuel Lauss To: netdev@vger.kernel.org, Samuel Ortiz Cc: Manuel Lauss Subject: [PATCH 1/2] net: irda: au1k_ir: remove unused timer Date: Tue, 14 Feb 2017 13:08:03 +0100 Message-Id: <20170214120804.248871-1-manuel.lauss@gmail.com> X-Mailer: git-send-email 2.11.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org remove the unused timer. I suppose it was intended as a timeout detector, but never properly implemented. Signed-off-by: Manuel Lauss --- drivers/net/irda/au1k_ir.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/net/irda/au1k_ir.c b/drivers/net/irda/au1k_ir.c index 44e4f386a5dc..bc2a63f5ca8c 100644 --- a/drivers/net/irda/au1k_ir.c +++ b/drivers/net/irda/au1k_ir.c @@ -169,8 +169,6 @@ struct au1k_private { u32 speed; u32 newspeed; - struct timer_list timer; - struct resource *ioarea; struct au1k_irda_platform_data *platdata; struct clk *irda_clk; @@ -178,8 +176,6 @@ struct au1k_private { static int qos_mtt_bits = 0x07; /* 1 ms or more */ -#define RUN_AT(x) (jiffies + (x)) - static void au1k_irda_plat_set_phy_mode(struct au1k_private *p, int mode) { if (p->platdata && p->platdata->set_phy_mode) @@ -620,8 +616,6 @@ static int au1k_irda_start(struct net_device *dev) /* power up */ au1k_irda_plat_set_phy_mode(aup, AU1000_IRDA_PHY_MODE_SIR); - aup->timer.expires = RUN_AT((3 * HZ)); - aup->timer.data = (unsigned long)dev; return 0; } @@ -642,7 +636,6 @@ static int au1k_irda_stop(struct net_device *dev) } netif_stop_queue(dev); - del_timer(&aup->timer); /* disable the interrupt */ free_irq(aup->irq_tx, dev);