From patchwork Mon Jan 16 13:20:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 715679 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3v2DQl2df9z9srZ for ; Tue, 17 Jan 2017 00:21:34 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751294AbdAPNV0 (ORCPT ); Mon, 16 Jan 2017 08:21:26 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:52653 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751081AbdAPNVY (ORCPT ); Mon, 16 Jan 2017 08:21:24 -0500 Received: from wuerfel.lan ([78.43.21.235]) by mrelayeu.kundenserver.de (mreue005 [212.227.15.129]) with ESMTPA (Nemesis) id 0Mb5Ch-1cA4EZ0jEp-00KiyF; Mon, 16 Jan 2017 14:21:16 +0100 From: Arnd Bergmann To: Florian Fainelli Cc: Arnd Bergmann , "David S. Miller" , Philippe Reynes , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] cpmac: remove hopeless #warning Date: Mon, 16 Jan 2017 14:20:54 +0100 Message-Id: <20170116132113.2056012-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:ohbg7Mss6kOcVhw6WHVGEMeh8YZbD1ifK16SSV2sWU3kwIbAkrp 8o1nNHPnVQYmd3NrF7efCraixAJAaQpZmq3ZELkQ5GbyMwAvf7pMZttRdCy8QAK4/N7kvjj lnWaLA7cZ/wvQhOxUmW4K8Jx2NgWKwR1JafLi61qJpJxkkBqJpuM33sSe+bPTt5DyTDvZIa YjYN99E76zDphrhJ5abbw== X-UI-Out-Filterresults: notjunk:1; V01:K0:Y/04CqhDR1w=:IJzUqPmCetx70wmPgMjxfw uPQqQgwHU+Zg1J47Z2yFogMjq2001VyHhlXC9nxknpkgPTZP1EJKDxcU5Go1S67ALvn5rzKRG Odu4EAuu/C7jcTQ8DI6uo1pg8pjfkZlG+MDT3wvB4L25t95t05dwBAoTjuFnmbhG34zLDiwLT Ynz41Ge4BjOGwLJfrXmMbYLyavzCrLKkplIOXa5eOA0pHSETnF5jIR+Y4eHW04dMxSFn7Xtk4 cZTQ+xzX2Z0tm5aM7vHo5g36vLwLu7cj+RdIhbg0vVQQA2llqADxSfyBLB9buKLtXILzBDRv2 q1EU4I3ZiZqYv69oQl2Sbx45GEDCphVx/kKClSqUahcRYYNw3tNZXX4ql3UTkAPJQttT6iB6I IC5NeUR0RZrdLePrpfG6d4tzXw90olP4ocerB0+4Ttk6xmZhPKB7HqdLUZwPNLhjrgp9lXSAL x/gr9/EI8BlYB+Dmhr8gunp9ZO0TPxdhLn6eLJIlTZ6FL5dbbDjl0lURDncO0pF6NUz9hK7kl QFEKfyJnXvj+aNwpGW6ZdgAoDUq5mOKz3+sWlKrSVOsYnraIjOI+Io3JThe+DcPbk/fq9OJMX PPqcwLzhtrMwdRkTM3HH0Vd7KWtjrSlU1KL6hQih73Rpg1kkOV7jhj34aQ48U5ondK+qQRzYM QzEdVuOzyzdb5JwyxJ2Rc+2mPvVy409sAuqZi1tmKN2coypaxM362dVJZAj/PUIZmDTM= Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The #warning was present 10 years ago when the driver first got merged. As the platform is rather obsolete by now, it seems very unlikely that the warning will cause anyone to fix the code properly. kernelci.org reports the warning for every build in the meantime, so I think it's better to just turn it into a code comment to reduce noise. Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/ti/cpmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/cpmac.c b/drivers/net/ethernet/ti/cpmac.c index 77c88fcf2b86..9b8a30bf939b 100644 --- a/drivers/net/ethernet/ti/cpmac.c +++ b/drivers/net/ethernet/ti/cpmac.c @@ -1210,7 +1210,7 @@ int cpmac_init(void) goto fail_alloc; } -#warning FIXME: unhardcode gpio&reset bits + /* FIXME: unhardcode gpio&reset bits */ ar7_gpio_disable(26); ar7_gpio_disable(27); ar7_device_reset(AR7_RESET_BIT_CPMAC_LO);