| Message ID | 20161219141610.30934-2-romain.perier@free-electrons.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Mon, Dec 19, 2016 at 03:16:06PM +0100, Romain Perier wrote: > Currently, the function mv88e6xxx_smi_init() returns -EINVAL if the bit > zero of sw_addr is 0x1. However, on some platforms, ethernet switches > are configured in Multi chip addressing mode and available at MDIO > address 0x1. Hi Romain What branch is this against? net-next? Please see: https://www.spinics.net/lists/netdev/msg409156.html It would be nicer to use Volodymyr, since it has been reviewed. Volodymyr, what happened to your version 2? Did David accept it? Andrew
Hi Andrew, Le 19/12/2016 à 15:38, Andrew Lunn a écrit : > On Mon, Dec 19, 2016 at 03:16:06PM +0100, Romain Perier wrote: >> Currently, the function mv88e6xxx_smi_init() returns -EINVAL if the bit >> zero of sw_addr is 0x1. However, on some platforms, ethernet switches >> are configured in Multi chip addressing mode and available at MDIO >> address 0x1. > > Hi Romain > > What branch is this against? net-next? Until last friday it was based onto next-20161216, I rebased onto the torvalds's tree this morning (so ~4.10-pre-rc1). > > Please see: > > https://www.spinics.net/lists/netdev/msg409156.html Oh, it's already fixed, good. I did not see this patch :) > > It would be nicer to use Volodymyr, since it has been reviewed. As the fix is already there, I will use it, sure. Thanks, Romain
On Mon, Dec 19, 2016 at 03:56:34PM +0100, Romain Perier wrote: > Hi Andrew, > > Le 19/12/2016 à 15:38, Andrew Lunn a écrit : > >On Mon, Dec 19, 2016 at 03:16:06PM +0100, Romain Perier wrote: > >>Currently, the function mv88e6xxx_smi_init() returns -EINVAL if the bit > >>zero of sw_addr is 0x1. However, on some platforms, ethernet switches > >>are configured in Multi chip addressing mode and available at MDIO > >>address 0x1. > > > >Hi Romain > > > >What branch is this against? net-next? > > Until last friday it was based onto next-20161216, I rebased onto > the torvalds's tree this morning (so ~4.10-pre-rc1). This patchset is 80% networking. So please see: Documentation/networking/netdev-FAQ.txt > Oh, it's already fixed, good. I did not see this patch :) > > > > >It would be nicer to use Volodymyr, since it has been reviewed. > > > As the fix is already there, I will use it, sure. Im not sure what happened to it. It might of fallen through the cracks. Lets see what Volodymyr says. It might need resubmitting once netdev reopens. Andrew
On Mon, Dec 19, 2016 at 04:04:32PM +0100, Volodymyr Bendiuga wrote: > Hi Andrew, > > No, it did not get accepted. Or at least I did not see > David accepting it. Let me know if I should resubmit it. Hi Volodymyr Please do resend it. Probably netdev will reopen sometime after the 25th. Don't forget to include the reviewed-by i gave. Thanks Andrew
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index f7222dc..b5f0e1e 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -4240,10 +4240,6 @@ static void mv88e6xxx_phy_destroy(struct mv88e6xxx_chip *chip) static int mv88e6xxx_smi_init(struct mv88e6xxx_chip *chip, struct mii_bus *bus, int sw_addr) { - /* ADDR[0] pin is unavailable externally and considered zero */ - if (sw_addr & 0x1) - return -EINVAL; - if (sw_addr == 0) chip->smi_ops = &mv88e6xxx_smi_single_chip_ops; else if (mv88e6xxx_has(chip, MV88E6XXX_FLAGS_MULTI_CHIP))
Currently, the function mv88e6xxx_smi_init() returns -EINVAL if the bit zero of sw_addr is 0x1. However, on some platforms, ethernet switches are configured in Multi chip addressing mode and available at MDIO address 0x1. Signed-off-by: Romain Perier <romain.perier@free-electrons.com> --- drivers/net/dsa/mv88e6xxx/chip.c | 4 ---- 1 file changed, 4 deletions(-)