From patchwork Thu Dec 1 18:32:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Brandt X-Patchwork-Id: 701627 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3tV5WK35gFz9tB1 for ; Fri, 2 Dec 2016 05:33:01 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755609AbcLASc5 (ORCPT ); Thu, 1 Dec 2016 13:32:57 -0500 Received: from relmlor2.renesas.com ([210.160.252.172]:64631 "EHLO relmlie1.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752602AbcLASc4 (ORCPT ); Thu, 1 Dec 2016 13:32:56 -0500 Received: from unknown (HELO relmlir1.idc.renesas.com) ([10.200.68.151]) by relmlie1.idc.renesas.com with ESMTP; 02 Dec 2016 03:32:55 +0900 Received: from relmlac4.idc.renesas.com (relmlac4.idc.renesas.com [10.200.69.24]) by relmlir1.idc.renesas.com (Postfix) with ESMTP id 93EAB4434B; Fri, 2 Dec 2016 03:32:55 +0900 (JST) Received: by relmlac4.idc.renesas.com (Postfix, from userid 0) id 83FE4480A6; Fri, 2 Dec 2016 03:32:55 +0900 (JST) Received: from relmlac4.idc.renesas.com (localhost [127.0.0.1]) by relmlac4.idc.renesas.com (Postfix) with ESMTP id 7D47F480A5; Fri, 2 Dec 2016 03:32:55 +0900 (JST) Received: from relmlii2.idc.renesas.com [10.200.68.66] by relmlac4.idc.renesas.com with ESMTP id DAA08700; Fri, 2 Dec 2016 03:32:55 +0900 X-IronPort-AV: E=Sophos;i="5.33,282,1477926000"; d="scan'208";a="227500262" Received: from unknown (HELO rtamta01.rta.renesas.com) ([143.103.48.75]) by relmlii2.idc.renesas.com with ESMTP; 02 Dec 2016 03:32:54 +0900 Received: from localhost.localdomain (unknown [172.27.49.71]) by rtamta01.rta.renesas.com (Postfix) with ESMTP id D76575C5; Thu, 1 Dec 2016 18:32:47 +0000 (UTC) From: Chris Brandt To: David Miller , Sergei Shtylyov Cc: Simon Horman , Geert Uytterhoeven , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Chris Brandt Subject: [PATCH v3] sh_eth: remove unchecked interrupts for RZ/A1 Date: Thu, 1 Dec 2016 13:32:14 -0500 Message-Id: <20161201183214.30196-1-chris.brandt@renesas.com> X-Mailer: git-send-email 2.10.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When streaming a lot of data and the RZ/A1 can't keep up, some status bits will get set that are not being checked or cleared which cause the following messages and the Ethernet driver to stop working. This patch fixes that issue. irq 21: nobody cared (try booting with the "irqpoll" option) handlers: [] sh_eth_interrupt Disabling IRQ #21 Fixes: db893473d313a4ad ("sh_eth: Add support for r7s72100") Signed-off-by: Chris Brandt Acked-by: Sergei Shtylyov --- v3: * add RZ/A1 to subject line v2: * switched from modifying eesr_err_check to modifying eesipr_value --- drivers/net/ethernet/renesas/sh_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index 05b0dc5..1a92de7 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -518,7 +518,7 @@ static struct sh_eth_cpu_data r7s72100_data = { .ecsr_value = ECSR_ICD, .ecsipr_value = ECSIPR_ICDIP, - .eesipr_value = 0xff7f009f, + .eesipr_value = 0xe77f009f, .tx_check = EESR_TC1 | EESR_FTC, .eesr_err_check = EESR_TWB1 | EESR_TWB | EESR_TABT | EESR_RABT |