diff mbox

ethtool: mark mask values as ULL values

Message ID 20161129230847.10163-1-jacob.e.keller@intel.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Jacob Keller Nov. 29, 2016, 11:08 p.m. UTC
If compiling with signed checks enabled, there will be warnings
generated by the ETHTOOL_RX_FLOW_SPEC_RING(_VF) masks. These are
currently marked as signed constants, which will generate warnings when
masking with unsigned values. Avoid this by marking them explicitly as
unsigned values.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
---
 include/uapi/linux/ethtool.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

David Miller Nov. 30, 2016, 9:24 p.m. UTC | #1
From: Jacob Keller <jacob.e.keller@intel.com>
Date: Tue, 29 Nov 2016 15:08:47 -0800

> If compiling with signed checks enabled, there will be warnings
> generated by the ETHTOOL_RX_FLOW_SPEC_RING(_VF) masks. These are
> currently marked as signed constants, which will generate warnings when
> masking with unsigned values. Avoid this by marking them explicitly as
> unsigned values.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>

Applied, thanks.
diff mbox

Patch

diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
index ed650eef9e54..a716112b2b01 100644
--- a/include/uapi/linux/ethtool.h
+++ b/include/uapi/linux/ethtool.h
@@ -891,8 +891,8 @@  struct ethtool_rx_flow_spec {
  * space for this at this time. If a future patch consumes the next
  * byte it should be aware of this possiblity.
  */
-#define ETHTOOL_RX_FLOW_SPEC_RING	0x00000000FFFFFFFFLL
-#define ETHTOOL_RX_FLOW_SPEC_RING_VF	0x000000FF00000000LL
+#define ETHTOOL_RX_FLOW_SPEC_RING	0x00000000FFFFFFFFULL
+#define ETHTOOL_RX_FLOW_SPEC_RING_VF	0x000000FF00000000ULL
 #define ETHTOOL_RX_FLOW_SPEC_RING_VF_OFF 32
 static inline __u64 ethtool_get_flow_spec_ring(__u64 ring_cookie)
 {