From patchwork Wed Aug 17 05:44:03 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leon Romanovsky X-Patchwork-Id: 659909 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3sDdT93YWVz9sRB for ; Wed, 17 Aug 2016 15:44:13 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753616AbcHQFoK (ORCPT ); Wed, 17 Aug 2016 01:44:10 -0400 Received: from mail.kernel.org ([198.145.29.136]:33746 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750903AbcHQFoJ (ORCPT ); Wed, 17 Aug 2016 01:44:09 -0400 Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 458E220160; Wed, 17 Aug 2016 05:44:07 +0000 (UTC) Received: from localhost (unknown [193.47.165.251]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BD223200EC; Wed, 17 Aug 2016 05:44:05 +0000 (UTC) Date: Wed, 17 Aug 2016 08:44:03 +0300 From: Leon Romanovsky To: Mark Brown Cc: Saeed Mahameed , kernel-build-reports@lists.linaro.org, linaro-kernel@lists.linaro.org, linux-next@vger.kernel.org, netdev@vger.kernel.org Subject: Re: next-20160816 build: 1 failures 2 warnings (next-20160816) Message-ID: <20160817054403.GD5489@leon.nu> References: <20160816163841.GU9347@sirena.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160816163841.GU9347@sirena.org.uk> User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Aug 16, 2016 at 05:38:41PM +0100, Mark Brown wrote: > On Tue, Aug 16, 2016 at 10:37:20AM +0100, Build bot for Mark Brown wrote: > > Today's -next fails to build an ARM allmodconfig due to: > > > arm-allmodconfig > > ../drivers/net/ethernet/mellanox/mlx5/core/debugfs.c:300:61: error: 'outb' undeclared (first use in this function) > > which appears to be caused by 535e20f083e6 ({net,IB}/mlx5: QP/XRCD > commands via mlx5 ifc). outb() just isn't available as standard on ARM, > it's not something that's meaningful for the hardware. Thanks Mark for catching it. It puzzles me how it passed all other compilations (internals and externals) without failures. On my machine (x86-64), old and new versions compile without errors. This failure isn't related to OUT assembly instruction, but to typo in pointer name declaration. It was declared as "u32 *out", but "outb" was used. diff --git a/drivers/net/ethernet/mellanox/mlx5/core/debugfs.c b/drivers/net/ethernet/mellanox/mlx5/core/debugfs.c index e587911..e94a953 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/debugfs.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/debugfs.c @@ -297,7 +297,7 @@ static u64 qp_read_field(struct mlx5_core_dev *dev, struct mlx5_core_qp *qp, *is_str = 0; /* FIXME: use MLX5_GET rather than mlx5_qp_context manual struct */ - ctx = (struct mlx5_qp_context *)MLX5_ADDR_OF(query_qp_out, outb, qpc); + ctx = (struct mlx5_qp_context *)MLX5_ADDR_OF(query_qp_out, out, qpc); switch (index) { case QP_PID: