From patchwork Tue Aug 9 12:55:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: kernel test robot X-Patchwork-Id: 657254 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3s7vSS2ffcz9t1F for ; Tue, 9 Aug 2016 22:57:12 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932506AbcHIM5I (ORCPT ); Tue, 9 Aug 2016 08:57:08 -0400 Received: from mga01.intel.com ([192.55.52.88]:46350 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932240AbcHIM5F (ORCPT ); Tue, 9 Aug 2016 08:57:05 -0400 Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP; 09 Aug 2016 05:57:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,494,1464678000"; d="scan'208";a="152972308" Received: from bee.sh.intel.com (HELO bee) ([10.239.97.14]) by fmsmga004.fm.intel.com with ESMTP; 09 Aug 2016 05:57:02 -0700 Received: from kbuild by bee with local (Exim 4.84_2) (envelope-from ) id 1bX6aN-000NKx-E3; Tue, 09 Aug 2016 20:56:47 +0800 Date: Tue, 9 Aug 2016 20:55:59 +0800 From: kbuild test robot To: Ursula Braun Cc: kbuild-all@01.org, davem@davemloft.net, netdev@vger.kernel.org, linux-s390@vger.kernel.org, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, utz.bacher@de.ibm.com, ubraun@linux.vnet.ibm.com Subject: [PATCH] smc: fix boolreturn.cocci warnings Message-ID: <20160809125559.GA8952@lkp-ib03> References: <201608092041.K2P08ijT%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1470737580-43012-15-git-send-email-ubraun@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org net/smc/smc_wr.c:274:10-11: WARNING: return of 0/1 in function 'smc_wr_tx_has_pending' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci CC: Ursula Braun Signed-off-by: Fengguang Wu --- smc_wr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/net/smc/smc_wr.c +++ b/net/smc/smc_wr.c @@ -271,9 +271,9 @@ bool smc_wr_tx_has_pending(struct smc_li continue; tx_pend = &link->wr_tx_pends[i].priv; if (filter(tx_pend, data)) - return 1; + return true; } - return 0; + return false; } /****************************** receive queue ********************************/