From patchwork Sun Aug 7 11:19:01 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phil Sutter X-Patchwork-Id: 656452 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3s6dMg0dXzz9sdg for ; Sun, 7 Aug 2016 21:18:39 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751633AbcHGLQY (ORCPT ); Sun, 7 Aug 2016 07:16:24 -0400 Received: from orbyte.nwl.cc ([151.80.46.58]:47111 "EHLO mail.nwl.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751574AbcHGLQY (ORCPT ); Sun, 7 Aug 2016 07:16:24 -0400 Received: from mail.nwl.cc (orbyte.nwl.cc [127.0.0.1]) by mail.nwl.cc (Postfix) with ESMTP id 8FB06647E7; Sun, 7 Aug 2016 13:16:21 +0200 (CEST) Received: from base (localhost [IPv6:::1]) by mail.nwl.cc (Postfix) with ESMTP id 6D056647E4; Sun, 7 Aug 2016 13:16:21 +0200 (CEST) From: Phil Sutter To: Stephen Hemminger Cc: Mark Bloch , netdev@vger.kernel.org Subject: [PATCH] tc/m_gact: Fix action_a2n() return code check Date: Sun, 7 Aug 2016 13:19:01 +0200 X-Mailer: git-send-email 2.9.0 Message-Id: <20160807111621.6D056647E4@mail.nwl.cc> X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The function returns zero on success. Reported-by: Mark Bloch Fixes: 69f5aff63c770b ("tc: use action_a2n() everywhere") Signed-off-by: Phil Sutter --- tc/m_gact.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tc/m_gact.c b/tc/m_gact.c index c0a938c716b6a..2bfd9a7c317e4 100644 --- a/tc/m_gact.c +++ b/tc/m_gact.c @@ -73,7 +73,7 @@ get_act(char ***argv_p) { int n; - if (!action_a2n(**argv_p, &n, false)) { + if (action_a2n(**argv_p, &n, false)) { fprintf(stderr, "bad action type %s\n", **argv_p); return -10; }