From patchwork Tue Aug 2 10:38:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baole Ni X-Patchwork-Id: 654664 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3s3Yb71tLTz9t3Q for ; Tue, 2 Aug 2016 21:17:55 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754763AbcHBLRv (ORCPT ); Tue, 2 Aug 2016 07:17:51 -0400 Received: from mga02.intel.com ([134.134.136.20]:26194 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754762AbcHBLPz (ORCPT ); Tue, 2 Aug 2016 07:15:55 -0400 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 02 Aug 2016 04:15:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,459,1464678000"; d="scan'208";a="1028245081" Received: from shsibuild003.sh.intel.com ([10.239.146.225]) by orsmga002.jf.intel.com with ESMTP; 02 Aug 2016 04:15:53 -0700 From: Baole Ni To: 3chas3@gmail.com, tj@kernel.org, lenb@kernel.org, x86@kernel.org, hpa@zytor.com Cc: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0067/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:38:14 +0800 Message-Id: <20160802103814.18222-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/atm/adummy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/atm/adummy.c b/drivers/atm/adummy.c index f9b983a..e5768cd 100644 --- a/drivers/atm/adummy.c +++ b/drivers/atm/adummy.c @@ -64,7 +64,7 @@ static ssize_t __show_signal(struct device *dev, struct atm_dev *atm_dev = container_of(dev, struct atm_dev, class_dev); return sprintf(buf, "%d\n", atm_dev->signal); } -static DEVICE_ATTR(signal, 0644, __show_signal, __set_signal); +static DEVICE_ATTR(signal, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, __show_signal, __set_signal); static struct attribute *adummy_attrs[] = { &dev_attr_signal.attr,