From patchwork Thu Jun 9 00:44:51 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vivien Didelot X-Patchwork-Id: 632585 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3rQ67j68RRz9sBM for ; Thu, 9 Jun 2016 10:46:41 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424841AbcFIAp1 (ORCPT ); Wed, 8 Jun 2016 20:45:27 -0400 Received: from mail.savoirfairelinux.com ([208.88.110.44]:48642 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424755AbcFIApW (ORCPT ); Wed, 8 Jun 2016 20:45:22 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id BFAC9620E2C; Wed, 8 Jun 2016 20:45:20 -0400 (EDT) Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id JfgFMYE9kI4g; Wed, 8 Jun 2016 20:45:18 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id 31E6C620E23; Wed, 8 Jun 2016 20:45:17 -0400 (EDT) X-Virus-Scanned: amavisd-new at mail.savoirfairelinux.com Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 2w7F35YGQ0Cc; Wed, 8 Jun 2016 20:45:17 -0400 (EDT) Received: from ketchup.mtl.sfl (unknown [192.168.48.170]) by mail.savoirfairelinux.com (Postfix) with ESMTPSA id D8DED620E1A; Wed, 8 Jun 2016 20:45:16 -0400 (EDT) From: Vivien Didelot To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Andrew Lunn , Florian Fainelli , Vivien Didelot Subject: [PATCH net-next 3/8] net: dsa: mv88e6xxx: use already declared variables Date: Wed, 8 Jun 2016 20:44:51 -0400 Message-Id: <20160609004456.5441-4-vivien.didelot@savoirfairelinux.com> X-Mailer: git-send-email 2.8.3 In-Reply-To: <20160609004456.5441-1-vivien.didelot@savoirfairelinux.com> References: <20160609004456.5441-1-vivien.didelot@savoirfairelinux.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In the MDIO probing function, dev is already assigned to &mdiodev->dev and np is already assigned to mdiodev->dev.of_node, so use them. Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c index cb8b1b7..cfa30ae 100644 --- a/drivers/net/dsa/mv88e6xxx.c +++ b/drivers/net/dsa/mv88e6xxx.c @@ -3726,7 +3726,7 @@ int mv88e6xxx_probe(struct mdio_device *mdiodev) if (!ps->info) return -ENODEV; - ps->reset = devm_gpiod_get(&mdiodev->dev, "reset", GPIOD_ASIS); + ps->reset = devm_gpiod_get(dev, "reset", GPIOD_ASIS); if (IS_ERR(ps->reset)) { err = PTR_ERR(ps->reset); if (err == -ENOENT) { @@ -3741,13 +3741,13 @@ int mv88e6xxx_probe(struct mdio_device *mdiodev) !of_property_read_u32(np, "eeprom-length", &eeprom_len)) ps->eeprom_len = eeprom_len; - err = mv88e6xxx_mdio_register(ps, mdiodev->dev.of_node); + err = mv88e6xxx_mdio_register(ps, np); if (err) return err; dev_set_drvdata(dev, ds); - err = dsa_register_switch(ds, mdiodev->dev.of_node); + err = dsa_register_switch(ds, np); if (err) { mv88e6xxx_mdio_unregister(ps); return err;