From patchwork Thu Feb 4 13:55:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amitoj Kaur Chawla X-Patchwork-Id: 578956 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 7B51A14056B for ; Fri, 5 Feb 2016 00:56:03 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=R+R5yjvU; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754021AbcBDNzZ (ORCPT ); Thu, 4 Feb 2016 08:55:25 -0500 Received: from mail-pf0-f181.google.com ([209.85.192.181]:36195 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752888AbcBDNzS (ORCPT ); Thu, 4 Feb 2016 08:55:18 -0500 Received: by mail-pf0-f181.google.com with SMTP id n128so45568831pfn.3; Thu, 04 Feb 2016 05:55:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=Wr0C3ZeAqj+FHHt7ubVWWbbejxQRSuSXzdfdkQAtelM=; b=R+R5yjvUYXbY9ns01hSDoa5zC0Jv6pCfi5l0e5xmIIrgc6P/drhwm08L6kOjBjw264 ++HCoQAffZP9/grdn2gbpUO+Mh63reNzIibN1c5QV6zMuyLw+gcxRmvGXTNgt+aKOUyE g/roFj7hwBKX2M6hAWZCwxfEBAOWIBpRRW7lMYqUgvpcxUfP9BynfSY4B7fPJLJIe0jd O397sPIU5UjnSPtZAQy4YCuyd5M/uZ6N+wMG433ZGswcmODerrLKMQbq4/nvwQ+jRgSV kejZOm4kNZEZ7DY+FhRo3ngBEWireFoLHRhBIGP+cXTELaNtJV9sw/wWooCwLFJcQdnK bxnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-type:content-disposition:user-agent; bh=Wr0C3ZeAqj+FHHt7ubVWWbbejxQRSuSXzdfdkQAtelM=; b=Wz4LfpFs0iuSixabUNmJZa6YTzH/tkulKQqA7+iKX9q8GHavVyViAqqLXnyDlLUVPN 3OziEbKgL63SnXZRSjro2HgmjEfq2nHgFEYQRZ0Cq61EUHassbxQTIgo0gMlVAhqCMJx pcTBNuAPivVLUjU9Y0Eb1ueYYVhKeEkcYS1NtFNi0ESoLq/X2GaSxbo2JA2oSFQUBrLu QHGlBr/WnboVPuSIyu1sfBqGtgBO6TLIyZYo0zUMOOWydJze+fjsQ5xp+IXy47B6FlGP FCJAkqoV9d17s9x0NZfhd2OwWBCKXuKSXXrMijYmPTd7TnMtS0eIInLbweMrxH4ZRFri 5O/w== X-Gm-Message-State: AG10YOTvi8l5sPbGLdsiwzNEvXmtcGkZ49Sws5z4q0wrCFibDssJuadWeI3TSld9kh31sA== X-Received: by 10.66.187.145 with SMTP id fs17mr11041024pac.81.1454594117469; Thu, 04 Feb 2016 05:55:17 -0800 (PST) Received: from localhost ([122.162.240.204]) by smtp.gmail.com with ESMTPSA id ah10sm17472358pad.23.2016.02.04.05.55.16 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 04 Feb 2016 05:55:16 -0800 (PST) Date: Thu, 4 Feb 2016 19:25:13 +0530 From: Amitoj Kaur Chawla To: derek.chickles@caviumnetworks.com, satananda.burla@caviumnetworks.com, felix.manlunas@caviumnetworks.com, raghu.vatsavayi@caviumnetworks.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: julia.lawall@lip6.fr Subject: [PATCH 1/3] net: cavium: liquidio: Return correct error code Message-ID: <20160204135512.GA8297@amitoj-Inspiron-3542> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The return value of vmalloc on failure of allocation of memory should be -ENOMEM and not -1. Found using Coccinelle. A simplified version of the semantic patch used is: // @@ expression *e; identifier l1; position p,q; @@ e@q = vmalloc(...); if@p (e == NULL) { ... goto l1; } l1: ... return -1 + -ENOMEM ; // --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 2 +- drivers/net/ethernet/cavium/liquidio/octeon_droq.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c index f683d97..0bf03b1 100644 --- a/drivers/net/ethernet/cavium/liquidio/lio_main.c +++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c @@ -1685,7 +1685,7 @@ static int octeon_setup_droq(struct octeon_device *oct, int q_no, int num_descs, dev_dbg(&oct->pci_dev->dev, "Creating Droq: %d\n", q_no); /* droq creation and local register settings. */ ret_val = octeon_create_droq(oct, q_no, num_descs, desc_size, app_ctx); - if (ret_val == -1) + if (ret_val < 0) return ret_val; if (ret_val == 1) { diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_droq.c b/drivers/net/ethernet/cavium/liquidio/octeon_droq.c index 4dba86e..174072b 100644 --- a/drivers/net/ethernet/cavium/liquidio/octeon_droq.c +++ b/drivers/net/ethernet/cavium/liquidio/octeon_droq.c @@ -983,5 +983,5 @@ int octeon_create_droq(struct octeon_device *oct, create_droq_fail: octeon_delete_droq(oct, q_no); - return -1; + return -ENOMEM; }