| Message ID | 20151007102638.335e9762@endymion.delvare |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On 10/07/2015 01:26 AM, Jean Delvare wrote: > "Y" was the right answer for MDIO_OCTEON when this option was only > available on CAVIUM_OCTEON_SOC. But now that the option is visible on > all (64-bit) systems, this piece of advice no longer makes sense. This > helper module is selected automatically by drivers which need it > anyway. > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > Fixes: a6d6786452 ("net: mdio-octeon: Modify driver to work on both ThunderX and Octeon") > Cc: Florian Fainelli <f.fainelli@gmail.com> > Cc: Sunil Goutham <sgoutham@cavium.com> > Cc: Radha Mohan Chintakuntla <rchintakuntla@cavium.com> > Cc: David Daney <david.daney@cavium.com> > Cc: David S. Miller <davem@davemloft.net> Jean, good catch: Acked-by: David Daney <david.daney@cavium.com> > --- > drivers/net/phy/Kconfig | 2 -- > 1 file changed, 2 deletions(-) > > --- linux-4.3-rc4.orig/drivers/net/phy/Kconfig 2015-09-20 23:32:34.000000000 +0200 > +++ linux-4.3-rc4/drivers/net/phy/Kconfig 2015-10-07 10:18:46.260452322 +0200 > @@ -168,8 +168,6 @@ config MDIO_OCTEON > busses. It is required by the Octeon and ThunderX ethernet device > drivers. > > - If in doubt, say Y. > - > config MDIO_SUN4I > tristate "Allwinner sun4i MDIO interface support" > depends on ARCH_SUNXI > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Jean Delvare <jdelvare@suse.de> Date: Wed, 7 Oct 2015 10:26:38 +0200 > "Y" was the right answer for MDIO_OCTEON when this option was only > available on CAVIUM_OCTEON_SOC. But now that the option is visible on > all (64-bit) systems, this piece of advice no longer makes sense. This > helper module is selected automatically by drivers which need it > anyway. > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > Fixes: a6d6786452 ("net: mdio-octeon: Modify driver to work on both ThunderX and Octeon") Applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- linux-4.3-rc4.orig/drivers/net/phy/Kconfig 2015-09-20 23:32:34.000000000 +0200 +++ linux-4.3-rc4/drivers/net/phy/Kconfig 2015-10-07 10:18:46.260452322 +0200 @@ -168,8 +168,6 @@ config MDIO_OCTEON busses. It is required by the Octeon and ThunderX ethernet device drivers. - If in doubt, say Y. - config MDIO_SUN4I tristate "Allwinner sun4i MDIO interface support" depends on ARCH_SUNXI
"Y" was the right answer for MDIO_OCTEON when this option was only available on CAVIUM_OCTEON_SOC. But now that the option is visible on all (64-bit) systems, this piece of advice no longer makes sense. This helper module is selected automatically by drivers which need it anyway. Signed-off-by: Jean Delvare <jdelvare@suse.de> Fixes: a6d6786452 ("net: mdio-octeon: Modify driver to work on both ThunderX and Octeon") Cc: Florian Fainelli <f.fainelli@gmail.com> Cc: Sunil Goutham <sgoutham@cavium.com> Cc: Radha Mohan Chintakuntla <rchintakuntla@cavium.com> Cc: David Daney <david.daney@cavium.com> Cc: David S. Miller <davem@davemloft.net> --- drivers/net/phy/Kconfig | 2 -- 1 file changed, 2 deletions(-)