| Message ID | 20150825.155500.290194488854444995.davem@davemloft.net |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On 8/25/15 3:55 PM, David Miller wrote: > From: kbuild test robot <fengguang.wu@intel.com> > Date: Wed, 26 Aug 2015 06:42:39 +0800 > >> sparse warnings: (new ones prefixed by >>) >> >>>> net/rds/ib_recv.c:382:28: sparse: incorrect type in initializer (different base types) >> net/rds/ib_recv.c:382:28: expected int [signed] can_wait >> net/rds/ib_recv.c:382:28: got restricted gfp_t >> net/rds/ib_recv.c:828:23: sparse: cast to restricted __le64 > > Fixed by: > > ==================== > [PATCH] rds: Fix improper gfp_t usage. > >>> net/rds/ib_recv.c:382:28: sparse: incorrect type in initializer (different base types) > net/rds/ib_recv.c:382:28: expected int [signed] can_wait > net/rds/ib_recv.c:382:28: got restricted gfp_t > net/rds/ib_recv.c:828:23: sparse: cast to restricted __le64 > > Reported-by: kbuild test robot <fengguang.wu@intel.com> > Signed-off-by: David S. Miller <davem@davemloft.net> > --- Thanks Dave. I was just creating the patch after noticing the error from kbuild on my tree. Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
==================== [PATCH] rds: Fix improper gfp_t usage. >> net/rds/ib_recv.c:382:28: sparse: incorrect type in initializer (different base types) net/rds/ib_recv.c:382:28: expected int [signed] can_wait net/rds/ib_recv.c:382:28: got restricted gfp_t net/rds/ib_recv.c:828:23: sparse: cast to restricted __le64 Reported-by: kbuild test robot <fengguang.wu@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net> --- net/rds/ib_recv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rds/ib_recv.c b/net/rds/ib_recv.c index 3afdcbd..ed9b41e 100644 --- a/net/rds/ib_recv.c +++ b/net/rds/ib_recv.c @@ -379,7 +379,7 @@ void rds_ib_recv_refill(struct rds_connection *conn, int prefill, gfp_t gfp) struct ib_recv_wr *failed_wr; unsigned int posted = 0; int ret = 0; - int can_wait = gfp & __GFP_WAIT; + bool can_wait = !!(gfp & __GFP_WAIT); u32 pos; /* the goal here is to just make sure that someone, somewhere