From patchwork Wed Apr 8 12:58:15 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Cox X-Patchwork-Id: 459241 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id ADF68140157 for ; Wed, 8 Apr 2015 22:58:30 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753515AbbDHM61 (ORCPT ); Wed, 8 Apr 2015 08:58:27 -0400 Received: from 251.110.2.81.in-addr.arpa ([81.2.110.251]:32914 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753070AbbDHM6Z (ORCPT ); Wed, 8 Apr 2015 08:58:25 -0400 Received: from localhost.localdomain (proxy [81.2.110.250]) by lxorguk.ukuu.org.uk (8.14.8/8.14.1) with ESMTP id t38DDshL016223; Wed, 8 Apr 2015 14:14:00 +0100 Subject: [PATCH] ppp_synctty: remove unneeded NULL check From: Alan To: netdev@vger.kernel.org, trivial@kernel.org Date: Wed, 08 Apr 2015 13:58:15 +0100 Message-ID: <20150408125807.30123.91282.stgit@localhost.localdomain> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fix a random whine found by coverity. Had it been NULL it would have showered us with oopses long before. Signed-off-by: Alan Cox --- 0 files changed -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ppp/ppp_synctty.c b/drivers/net/ppp/ppp_synctty.c index 925d3e2..b5592b8 100644 --- a/drivers/net/ppp/ppp_synctty.c +++ b/drivers/net/ppp/ppp_synctty.c @@ -549,7 +549,7 @@ ppp_sync_txmunge(struct syncppp *ap, struct sk_buff *skb) ap->last_xmit = jiffies; - if (skb && ap->flags & SC_LOG_OUTPKT) + if (ap->flags & SC_LOG_OUTPKT) ppp_print_buffer ("send buffer", skb->data, skb->len); return skb;