From patchwork Sun Aug 17 12:49:41 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreea-Cristina Bernat X-Patchwork-Id: 380589 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 149A814011D for ; Sun, 17 Aug 2014 22:50:26 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751343AbaHQMtw (ORCPT ); Sun, 17 Aug 2014 08:49:52 -0400 Received: from mail-wg0-f46.google.com ([74.125.82.46]:61432 "EHLO mail-wg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751133AbaHQMtv (ORCPT ); Sun, 17 Aug 2014 08:49:51 -0400 Received: by mail-wg0-f46.google.com with SMTP id m15so3918680wgh.5 for ; Sun, 17 Aug 2014 05:49:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=mGy0o4n1kZRyfTS8Kz3XOCF6wCMguQhgfKMGDMnYAxk=; b=YQgvm4OiBJYeiM1NIvYSrVggexmgJo4Eb/HTDCPIaz0CHfzTxrZWCRK7h1WqGQXbNr sr5ZX6VXX1Gy7GI5Welhoa72lITC/m1q9rJ1clxlhREcuMUa7607iCsVVuTlBXBmO798 wR8JmMMMp+vy9VehGny7j7Zm55rT9pmLVRNfbjEa0WUAYrbkQ+mfb/hzK5qr5wrxlM2n DgXd4b9+mxZ4chXmCwG2TBzuMsrfEBd4/SqjUeEFB1kSk+NvSI/gRZF6tNPEr6W7wdba 6dLyZ2jZjljSmwH+qjSEeOeBuQoyXW/T5udUfCxLyFJbYoaW+u6pRArojrC6tR4E3K0F 9uRA== X-Received: by 10.194.173.234 with SMTP id bn10mr34921193wjc.81.1408279789397; Sun, 17 Aug 2014 05:49:49 -0700 (PDT) Received: from ada ([109.100.66.168]) by mx.google.com with ESMTPSA id ja13sm27074092wic.8.2014.08.17.05.49.47 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 17 Aug 2014 05:49:48 -0700 (PDT) Date: Sun, 17 Aug 2014 15:49:41 +0300 From: Andreea-Cristina Bernat To: davem@davemloft.net, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: paulmck@linux.vnet.ibm.com Subject: [PATCH] net/ipv4/igmp.c: Replace rcu_dereference() with rcu_access_pointer() Message-ID: <20140817124941.GA14000@ada> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The "rcu_dereference()" call is used directly in a condition. Since its return value is never dereferenced it is recommended to use "rcu_access_pointer()" instead of "rcu_dereference()". Therefore, this patch makes the replacement. The following Coccinelle semantic patch was used: @@ @@ ( if( (<+... - rcu_dereference + rcu_access_pointer (...) ...+>)) {...} | while( (<+... - rcu_dereference + rcu_access_pointer (...) ...+>)) {...} ) Signed-off-by: Andreea-Cristina Bernat --- net/ipv4/igmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c index 6748d42..94a96ad 100644 --- a/net/ipv4/igmp.c +++ b/net/ipv4/igmp.c @@ -2537,7 +2537,7 @@ static int igmp_mc_seq_show(struct seq_file *seq, void *v) querier = "NONE"; #endif - if (rcu_dereference(state->in_dev->mc_list) == im) { + if (rcu_access_pointer(state->in_dev->mc_list) == im) { seq_printf(seq, "%d\t%-10s: %5d %7s\n", state->dev->ifindex, state->dev->name, state->in_dev->mc_count, querier); }