diff mbox

[iproute2] iplink_bond_slave: show mii_status only once

Message ID 20140228135815.2C101E66B4@unicorn.suse.cz
State Accepted, archived
Delegated to: stephen hemminger
Headers show

Commit Message

Michal Kubecek Feb. 28, 2014, 1:58 p.m. UTC
With "ip -d link show", bonding slave mii status is displayed
twice, once as a number and once as a name.

Fixes: 730d3f61 ("iplink: add support for bonding slave")
Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
---
 ip/iplink_bond_slave.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Stephen Hemminger Feb. 28, 2014, 6:14 p.m. UTC | #1
On Fri, 28 Feb 2014 14:58:15 +0100 (CET)
Michal Kubecek <mkubecek@suse.cz> wrote:

> With "ip -d link show", bonding slave mii status is displayed
> twice, once as a number and once as a name.
> 
> Fixes: 730d3f61 ("iplink: add support for bonding slave")
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
> ---
>  ip/iplink_bond_slave.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/ip/iplink_bond_slave.c b/ip/iplink_bond_slave.c
> index bb4e1d6..8f3fc6c 100644
> --- a/ip/iplink_bond_slave.c
> +++ b/ip/iplink_bond_slave.c
> @@ -43,7 +43,6 @@ static void print_slave_mii_status(FILE *f, struct rtattr *tb)
>  {
>  	unsigned int status = rta_getattr_u8(tb);
>  
> -	fprintf(f, "mii_status %d ", status);
>  	if (status >= sizeof(slave_mii_status) / sizeof(slave_mii_status[0]))
>  		fprintf(f, "mii_status %d ", status);
>  	else

Applied
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/ip/iplink_bond_slave.c b/ip/iplink_bond_slave.c
index bb4e1d6..8f3fc6c 100644
--- a/ip/iplink_bond_slave.c
+++ b/ip/iplink_bond_slave.c
@@ -43,7 +43,6 @@  static void print_slave_mii_status(FILE *f, struct rtattr *tb)
 {
 	unsigned int status = rta_getattr_u8(tb);
 
-	fprintf(f, "mii_status %d ", status);
 	if (status >= sizeof(slave_mii_status) / sizeof(slave_mii_status[0]))
 		fprintf(f, "mii_status %d ", status);
 	else