From patchwork Wed Jan 29 17:35:48 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dave Jones X-Patchwork-Id: 315164 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id EFCAD2C0300 for ; Thu, 30 Jan 2014 04:36:06 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752388AbaA2RgB (ORCPT ); Wed, 29 Jan 2014 12:36:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49482 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751241AbaA2RgA (ORCPT ); Wed, 29 Jan 2014 12:36:00 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0THZv99024109 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 29 Jan 2014 12:35:57 -0500 Received: from gelk.kernelslacker.org (ovpn-113-24.phx2.redhat.com [10.3.113.24]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0THZo5L032759 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 29 Jan 2014 12:35:56 -0500 Received: from gelk.kernelslacker.org (localhost [127.0.0.1]) by gelk.kernelslacker.org (8.14.7/8.14.7) with ESMTP id s0THZnWs025072; Wed, 29 Jan 2014 12:35:49 -0500 Received: (from davej@localhost) by gelk.kernelslacker.org (8.14.7/8.14.7/Submit) id s0THZmPd025071; Wed, 29 Jan 2014 12:35:48 -0500 X-Authentication-Warning: gelk.kernelslacker.org: davej set sender to davej@redhat.com using -f Date: Wed, 29 Jan 2014 12:35:48 -0500 From: Dave Jones To: netdev@vger.kernel.org Cc: stefano.brivio@polimi.it Subject: [rfc] b43: possible missing break in b43_wa_all Message-ID: <20140129173548.GA18873@redhat.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org I'm going through all the 'missing break in switch' bugs in coverity, and most of them look like intentional/false positives, but this one looks odd to me. It seems the intent is to B43_WARN_ON only if we don't know the phy, so it seems strange to do it after we've just initialized type 7. If this is agreed to be a bug, I'll submit the below patch properly, but I want to be sure this isn't something like "type 7 is work in progress" It's been this way since 2007 though. I guess no-one runs with CONFIG_B43_DEBUG on. Dave --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/wireless/b43/wa.c b/drivers/net/wireless/b43/wa.c index 9b1a038be08b..47f0ec887e1f 100644 --- a/drivers/net/wireless/b43/wa.c +++ b/drivers/net/wireless/b43/wa.c @@ -587,6 +587,7 @@ void b43_wa_all(struct b43_wldev *dev) b43_wa_txpuoff_rxpuon(dev); b43_wa_txlna_gain(dev); b43_wa_rssi_adc(dev); + break; default: B43_WARN_ON(1); }