From patchwork Sun Jan 19 19:37:12 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 312391 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 215622C00AB for ; Mon, 20 Jan 2014 06:37:29 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752105AbaASThS (ORCPT ); Sun, 19 Jan 2014 14:37:18 -0500 Received: from mail-pb0-f42.google.com ([209.85.160.42]:57383 "EHLO mail-pb0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751727AbaASThQ (ORCPT ); Sun, 19 Jan 2014 14:37:16 -0500 Received: by mail-pb0-f42.google.com with SMTP id jt11so4080918pbb.29 for ; Sun, 19 Jan 2014 11:37:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=fKl7k9rZnhPlRgB8SFRViVDl0MJ6V51G3EVlXDDjBW0=; b=ge4yTVw+NWH/nB8XfOO8aYXp48UWmsxtYp4pVK3/mJOqlbL9sKgKPhdvEjgMelJZW6 Xm5WLYwlzNuDoEtcLE15O7twkuGJ2WwqQgmMJlPuiNLynselgIkMNJXg2yfF/AWCFXeg nWPf6Wdg0UN5a7dYWCtDuUeYAAykD1qigBs15C5yxc25HWcG3QuoYuNg9/AGuCT+/Y3r AprsSt8DGmPSWkTRLeXMk8Sm7tMveIs3crrkTuy0TnUHzBzgnKjV7jFrk2GMS/ceHlve TRIGV8aJMRkjTVgpEUUN7nxoUANbAOuJz7h0nW5rAlaruW1VrAlB5ax6WmITSCpV4gqi /zag== X-Gm-Message-State: ALoCoQlHK4o99cxHqRZt/JdbvKQyemmz1TJ4kaPon1ekXwsnxr3ETys5ibE39V38vlw0xPfrZp3V X-Received: by 10.66.217.133 with SMTP id oy5mr14785723pac.46.1390160234719; Sun, 19 Jan 2014 11:37:14 -0800 (PST) Received: from nehalam.linuxnetplumber.net (static-50-53-83-51.bvtn.or.frontiernet.net. [50.53.83.51]) by mx.google.com with ESMTPSA id qq5sm38728521pbb.24.2014.01.19.11.37.14 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 19 Jan 2014 11:37:14 -0800 (PST) Date: Sun, 19 Jan 2014 11:37:12 -0800 From: Stephen Hemminger To: David Miller Cc: netdev@vger.kernel.org Subject: [ PATCH net-next vw] qlcnic: fix sparse warnings Message-ID: <20140119113712.18f75ba9@nehalam.linuxnetplumber.net> In-Reply-To: <20140118.230924.161581406065831782.davem@davemloft.net> References: <20140118172113.16adb69f@nehalam.linuxnetplumber.net> <20140118.230924.161581406065831782.davem@davemloft.net> X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Fengguang Wu Subject: [PATCH net-next] qlcnic: fix sparse warnings Previous patch changed prototypes, but forgot functions. Signed-off-by: Fengguang Wu Acked-by: Stephen Hemminger --- v2 - fix indentation drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c 2014-01-18 13:41:07.000000000 -0800 +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c 2014-01-19 10:55:19.207423506 -0800 @@ -2066,8 +2066,8 @@ void qlcnic_83xx_change_l2_filter(struct qlcnic_83xx_sre_macaddr_change(adapter, mac, vlan_id, QLCNIC_MAC_ADD); } -void qlcnic_83xx_configure_mac(struct qlcnic_adapter *adapter, u8 *mac, - u8 type, struct qlcnic_cmd_args *cmd) +static void qlcnic_83xx_configure_mac(struct qlcnic_adapter *adapter, u8 *mac, + u8 type, struct qlcnic_cmd_args *cmd) { switch (type) { case QLCNIC_SET_STATION_MAC: @@ -2170,7 +2170,7 @@ static void qlcnic_83xx_handle_link_aen( qlcnic_advert_link_change(adapter, link_status); } -irqreturn_t qlcnic_83xx_handle_aen(int irq, void *data) +static irqreturn_t qlcnic_83xx_handle_aen(int irq, void *data) { struct qlcnic_adapter *adapter = data; struct qlcnic_mailbox *mbx; @@ -3517,7 +3517,7 @@ int qlcnic_83xx_flash_test(struct qlcnic return 0; } -int qlcnic_83xx_shutdown(struct pci_dev *pdev) +static int qlcnic_83xx_shutdown(struct pci_dev *pdev) { struct qlcnic_adapter *adapter = pci_get_drvdata(pdev); struct net_device *netdev = adapter->netdev; @@ -3892,8 +3892,8 @@ int qlcnic_83xx_init_mailbox_work(struct return 0; } -pci_ers_result_t qlcnic_83xx_io_error_detected(struct pci_dev *pdev, - pci_channel_state_t state) +static pci_ers_result_t qlcnic_83xx_io_error_detected(struct pci_dev *pdev, + pci_channel_state_t state) { struct qlcnic_adapter *adapter = pci_get_drvdata(pdev); @@ -3914,7 +3914,7 @@ pci_ers_result_t qlcnic_83xx_io_error_de return PCI_ERS_RESULT_NEED_RESET; } -pci_ers_result_t qlcnic_83xx_io_slot_reset(struct pci_dev *pdev) +static pci_ers_result_t qlcnic_83xx_io_slot_reset(struct pci_dev *pdev) { struct qlcnic_adapter *adapter = pci_get_drvdata(pdev); int err = 0; @@ -3937,7 +3937,7 @@ disconnect: return PCI_ERS_RESULT_DISCONNECT; } -void qlcnic_83xx_io_resume(struct pci_dev *pdev) +static void qlcnic_83xx_io_resume(struct pci_dev *pdev) { struct qlcnic_adapter *adapter = pci_get_drvdata(pdev);