From patchwork Sat Jan 4 00:42:33 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: David Miller X-Patchwork-Id: 306760 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id EA2092C0099 for ; Sat, 4 Jan 2014 11:42:43 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754212AbaADAmf (ORCPT ); Fri, 3 Jan 2014 19:42:35 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:35419 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753866AbaADAme (ORCPT ); Fri, 3 Jan 2014 19:42:34 -0500 Received: from localhost (cpe-74-71-55-169.nyc.res.rr.com [74.71.55.169]) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 30AF65825E2; Fri, 3 Jan 2014 16:42:34 -0800 (PST) Date: Fri, 03 Jan 2014 19:42:33 -0500 (EST) Message-Id: <20140103.194233.1475063659612788745.davem@davemloft.net> To: therbert@google.com Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com Subject: Re: [PATCH 0/2 v3] ipv4: Cache dst in tunnels From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.1 (shards.monkeyblade.net [0.0.0.0]); Fri, 03 Jan 2014 16:42:34 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Tom Herbert Date: Thu, 2 Jan 2014 11:48:18 -0800 (PST) > Version 3 of caching routes in tunnels. Applied, but I really have to wonder when I have to fix up things like this: net/ipv4/ip_tunnel.c: In function ‘ip_tunnel_init’: net/ipv4/ip_tunnel.c:1062:20: warning: assignment from incompatible pointer type [enabled by default] --> --- a/net/ipv4/ip_tunnel.c +++ b/net/ipv4/ip_tunnel.c @@ -1059,7 +1059,7 @@ int ip_tunnel_init(struct net_device *dev) u64_stats_init(&ipt_stats->syncp); } - tunnel->dst_cache = alloc_percpu(struct ip_tunnel_dst *); + tunnel->dst_cache = alloc_percpu(struct ip_tunnel_dst); if (!tunnel->dst_cache) { free_percpu(dev->tstats); return -ENOMEM;