From patchwork Thu Dec 26 18:12:41 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 305302 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 9D5B72C009B for ; Fri, 27 Dec 2013 05:12:50 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753585Ab3LZSMr (ORCPT ); Thu, 26 Dec 2013 13:12:47 -0500 Received: from mail-pd0-f179.google.com ([209.85.192.179]:52348 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753468Ab3LZSMq (ORCPT ); Thu, 26 Dec 2013 13:12:46 -0500 Received: by mail-pd0-f179.google.com with SMTP id r10so8269169pdi.38 for ; Thu, 26 Dec 2013 10:12:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-type:content-transfer-encoding; bh=INcOP0jRk9lsXxpJPPJtLA/CddpQaETzpEsmUr4efZU=; b=iBi1bs3ao/5dxOw6qY1WXSzSkyREK59zuWyuGazT/eLDzmGQqMvCgldx9vvaspCpiM dTHz+10cVj1y7Oc5fbgPcXohhk1msAt/IiFfIC0C0UxV+OEAzOybH7o6vnV8SnLsAL74 9AzbyaWKodLBtcepcd/YLgHNCl26hQoQN2jZmIcITf3zsoJYN8SMDjJpOdgeJMQHo6N+ 7ovsaQMGiplObruwhkCeL3oIuQG39HsK18OVZpKWOobTXIAzxPD+IkFVYACSiPu6Wss0 A91TDw2UgO+vG2hESKFQE6iIF2vfUmqqy+6fzAhqLzd3DgmFWa+56olcVHQMsuBM9lOK v6Dw== X-Gm-Message-State: ALoCoQkDHYUal/SAfNwWdJn/2Edkq7eknkKprxMR3GY58Dr+S0IEuYDPZWO8yr8rQtShE7TvW2rD X-Received: by 10.66.4.130 with SMTP id k2mr45710693pak.95.1388081565824; Thu, 26 Dec 2013 10:12:45 -0800 (PST) Received: from nehalam.linuxnetplumber.net (static-50-53-83-51.bvtn.or.frontiernet.net. [50.53.83.51]) by mx.google.com with ESMTPSA id gg10sm56688821pbc.46.2013.12.26.10.12.45 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 26 Dec 2013 10:12:45 -0800 (PST) Date: Thu, 26 Dec 2013 10:12:41 -0800 From: Stephen Hemminger To: Ben Hutchings , David Miller Cc: netdev@vger.kernel.org Subject: [PATCH net-next] mdio: unused ethtool functions Message-ID: <20131226101241.5f38e392@nehalam.linuxnetplumber.net> X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Use it or lose it. Signed-off-by: Stephen Hemminger --- drivers/net/mdio.c | 28 ---------------------------- include/linux/mdio.h | 3 --- 2 files changed, 31 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/net/mdio.c 2013-12-24 15:37:35.779661759 -0800 +++ b/drivers/net/mdio.c 2013-12-24 15:38:26.054970175 -0800 @@ -342,34 +342,6 @@ void mdio45_ethtool_gset_npage(const str EXPORT_SYMBOL(mdio45_ethtool_gset_npage); /** - * mdio45_ethtool_spauseparam_an - set auto-negotiated pause parameters - * @mdio: MDIO interface - * @ecmd: Ethtool request structure - * - * This function assumes that the PHY has an auto-negotiation MMD. It - * will enable and disable advertising of flow control as appropriate. - */ -void mdio45_ethtool_spauseparam_an(const struct mdio_if_info *mdio, - const struct ethtool_pauseparam *ecmd) -{ - int adv, old_adv; - - WARN_ON(!(mdio->mmds & MDIO_DEVS_AN)); - - old_adv = mdio->mdio_read(mdio->dev, mdio->prtad, MDIO_MMD_AN, - MDIO_AN_ADVERTISE); - adv = ((old_adv & ~(ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM)) | - mii_advertise_flowctrl((ecmd->rx_pause ? FLOW_CTRL_RX : 0) | - (ecmd->tx_pause ? FLOW_CTRL_TX : 0))); - if (adv != old_adv) { - mdio->mdio_write(mdio->dev, mdio->prtad, MDIO_MMD_AN, - MDIO_AN_ADVERTISE, adv); - mdio45_nway_restart(mdio); - } -} -EXPORT_SYMBOL(mdio45_ethtool_spauseparam_an); - -/** * mdio_mii_ioctl - MII ioctl interface for MDIO (clause 22 or 45) PHYs * @mdio: MDIO interface * @mii_data: MII ioctl data structure --- a/include/linux/mdio.h 2013-12-24 15:37:35.779661759 -0800 +++ b/include/linux/mdio.h 2013-12-24 15:38:26.054970175 -0800 @@ -70,9 +70,6 @@ extern int mdio45_nway_restart(const str extern void mdio45_ethtool_gset_npage(const struct mdio_if_info *mdio, struct ethtool_cmd *ecmd, u32 npage_adv, u32 npage_lpa); -extern void -mdio45_ethtool_spauseparam_an(const struct mdio_if_info *mdio, - const struct ethtool_pauseparam *ecmd); /** * mdio45_ethtool_gset - get settings for ETHTOOL_GSET