diff mbox

Add missing braces to do_tcp_setsockopt

Message ID 20130905174333.GA3021@redhat.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Dave Jones Sept. 5, 2013, 5:43 p.m. UTC 
Signed-off-by: Dave Jones <davej@fedoraproject.org>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Neal Cardwell Sept. 5, 2013, 5:55 p.m. UTC | #1 
On Thu, Sep 5, 2013 at 1:43 PM, Dave Jones <davej@redhat.com> wrote:
> Signed-off-by: Dave Jones <davej@fedoraproject.org>

Acked-by: Neal Cardwell <ncardwell@google.com>

neal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Dave Jones Sept. 5, 2013, 5:58 p.m. UTC | #2 
On Thu, Sep 05, 2013 at 01:55:48PM -0400, Neal Cardwell wrote:
 > On Thu, Sep 5, 2013 at 1:43 PM, Dave Jones <davej@redhat.com> wrote:
 > > Signed-off-by: Dave Jones <davej@fedoraproject.org>
 > 
 > Acked-by: Neal Cardwell <ncardwell@google.com>
 > 
 > neal

Crap, I forgot the 

introduced in eed530b6c67624db3f2cf477bac7c4d005d8f7ba ("tcp: early retransmit")

Dave, shall I resend ?

	Dave

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller Sept. 5, 2013, 6:18 p.m. UTC | #3 
From: Dave Jones <davej@redhat.com>
Date: Thu, 5 Sep 2013 13:58:47 -0400

> On Thu, Sep 05, 2013 at 01:55:48PM -0400, Neal Cardwell wrote:
>  > On Thu, Sep 5, 2013 at 1:43 PM, Dave Jones <davej@redhat.com> wrote:
>  > > Signed-off-by: Dave Jones <davej@fedoraproject.org>
>  > 
>  > Acked-by: Neal Cardwell <ncardwell@google.com>
>  > 
>  > neal
> 
> Crap, I forgot the 
> 
> introduced in eed530b6c67624db3f2cf477bac7c4d005d8f7ba ("tcp: early retransmit")
> 
> Dave, shall I resend ?

I'll take care of it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index b2f6c74..95544e4 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -2454,10 +2454,11 @@  static int do_tcp_setsockopt(struct sock *sk, int level,
 	case TCP_THIN_DUPACK:
 		if (val < 0 || val > 1)
 			err = -EINVAL;
-		else
+		else {
 			tp->thin_dupack = val;
 			if (tp->thin_dupack)
 				tcp_disable_early_retrans(tp);
+		}
 		break;
 
 	case TCP_REPAIR: