From patchwork Thu Aug 29 20:24:47 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Shtylyov X-Patchwork-Id: 270935 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 517F12C00A4 for ; Fri, 30 Aug 2013 06:24:56 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756241Ab3H2UYw (ORCPT ); Thu, 29 Aug 2013 16:24:52 -0400 Received: from mail-la0-f52.google.com ([209.85.215.52]:52273 "EHLO mail-la0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752356Ab3H2UYv (ORCPT ); Thu, 29 Aug 2013 16:24:51 -0400 Received: by mail-la0-f52.google.com with SMTP id ev20so816808lab.11 for ; Thu, 29 Aug 2013 13:24:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:to:subject:cc:from:organization:date :mime-version:content-type:content-transfer-encoding:message-id; bh=IWaHhw6GwOW0EQoKVWzxkvIlIl623YxqNvFokkma1B4=; b=Cytm7ri4I6lJ3XM3yNgCopv0VwZDSaZcmKMClpvEbKeAZ6Wl8iqGn6dQGn9x4eqnhE fOpuG7RarxsoP61WXd1YyXfPLfzWojR4rcqZmupYtSwIWTMNpjDoktNNcCNXH36bcsR7 tK83V7r+0l2HBvJXxPwSUSi+nccmK1MXsVmCaB80kRO/r9WByk/4RuvLP3KO6fiIbfGQ 2DCHh48TAjf5SlxwLEhu8ACR29B46ZeNYRqfYvNnbmG9jc3aQ6GgJCVTWmdzfu492sYc XRh0NinEVmzO+rEb5oS/WcNF8fJL7JxvSaHTsEDZBffMpShxvRjMrLSgIiGH4pJOfrn7 OZ6Q== X-Gm-Message-State: ALoCoQkAoW1C4l+xjOFzjPmtP0Rmjnqx0XfbMLuHVbcgt7/7iDLl5NK1h3yH0aVQmKPBW9Kqc/jW X-Received: by 10.112.72.229 with SMTP id g5mr4712528lbv.10.1377807888611; Thu, 29 Aug 2013 13:24:48 -0700 (PDT) Received: from wasted.dev.rtsoft.ru (ppp91-76-155-81.pppoe.mtu-net.ru. [91.76.155.81]) by mx.google.com with ESMTPSA id ur6sm12308424lbc.5.1969.12.31.16.00.00 (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 29 Aug 2013 13:24:47 -0700 (PDT) To: netdev@vger.kernel.org Subject: [PATCH] sh_eth: no need to call ether_setup() Cc: nobuhiro.iwamatsu.yj@renesas.com, linux-sh@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Date: Fri, 30 Aug 2013 00:24:47 +0400 MIME-Version: 1.0 Message-Id: <201308300024.48415.sergei.shtylyov@cogentembedded.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org There's no need to call ether_setup() in the driver since prior alloc_etherdev() call already arranges for it. Suggested-by: Denis Kirjanov Signed-off-by: Sergei Shtylyov Reviewed-by: Simon Horman --- drivers/net/ethernet/renesas/sh_eth.c | 3 --- 1 file changed, 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: net-next/drivers/net/ethernet/renesas/sh_eth.c =================================================================== --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c +++ net-next/drivers/net/ethernet/renesas/sh_eth.c @@ -2639,9 +2639,6 @@ static int sh_eth_drv_probe(struct platf SET_NETDEV_DEV(ndev, &pdev->dev); - /* Fill in the fields of the device structure with ethernet values. */ - ether_setup(ndev); - mdp = netdev_priv(ndev); mdp->num_tx_ring = TX_RING_SIZE; mdp->num_rx_ring = RX_RING_SIZE;