From patchwork Wed Jun 5 15:37:00 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 249125 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 098782C131B for ; Thu, 6 Jun 2013 01:37:11 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756060Ab3FEPhG (ORCPT ); Wed, 5 Jun 2013 11:37:06 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:56982 "EHLO mail-pb0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756053Ab3FEPhE (ORCPT ); Wed, 5 Jun 2013 11:37:04 -0400 Received: by mail-pb0-f45.google.com with SMTP id mc8so1954950pbc.32 for ; Wed, 05 Jun 2013 08:37:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type:content-transfer-encoding :x-gm-message-state; bh=KEjWyhLQQBm7wJKOGlAKflO7CfS2EIL/8wo8Ae0aGVQ=; b=fPI8066EKBijmpElX6dkeB5JLOisT8dn2mgC/4t/9/I5OiBHUpWYXSjxWwJydP752B M6JrB5F6SWlIvtjx3cwf3qCF+hhwWef8x6qtHNGA0qhFt6/lPk1q6N/ZqsNVNn7mYXjr GcM+ku1Aitg3jqNEG6cfa/eFUBTnQofaVK8F9xGyRW4UJEegpqAYmbYYnAZQgWNq64rC MqYiFXqOT4r5lv8yBhdmQ+/rL2pat16DhVYqc2gaMElO79+oAr/VkUwbBEw9o6XdbxCf jd2j4W6VNvLNutltYEC0rFSRhiz8TE+ql8HHu6IO5ooHv9MXx2JBx+R7O+1VQYNLVOCj e52A== X-Received: by 10.68.75.110 with SMTP id b14mr34303672pbw.89.1370446624266; Wed, 05 Jun 2013 08:37:04 -0700 (PDT) Received: from nehalam.linuxnetplumber.net (static-50-53-71-109.bvtn.or.frontiernet.net. [50.53.71.109]) by mx.google.com with ESMTPSA id dr6sm73175930pac.11.2013.06.05.08.37.03 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 05 Jun 2013 08:37:03 -0700 (PDT) Date: Wed, 5 Jun 2013 08:37:00 -0700 From: Stephen Hemminger To: Stephen Hemminger Cc: davem@davemloft.net, netdev@vger.kernel.org Subject: [PATCH net] vxlan: fix crash on module removal Message-ID: <20130605083700.2a09e379@nehalam.linuxnetplumber.net> In-Reply-To: <1370406254-6341-3-git-send-email-stephen@networkplumber.org> References: <1370406254-6341-1-git-send-email-stephen@networkplumber.org> <1370406254-6341-3-git-send-email-stephen@networkplumber.org> X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-Gm-Message-State: ALoCoQmwwpGBDFGHGybHOpsPqawBsARewk1zulmKKrwJe0oCsqXunzY2hMSm8ihuDtVPi0lpJ6jS Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org If vxlan is removed with active vxlan's it would crash because rtnl_link_unregister (which calls vxlan_dellink), was invoked before unregister_pernet_device (which calls vxlan_stop). Signed-off-by: Stephen Hemminger --- See "vxlan: move IGMP join/leave to work queue" for the net-next version of this drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 3b1d2ee..5cc3b48 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -1677,8 +1677,8 @@ module_init(vxlan_init_module); static void __exit vxlan_cleanup_module(void) { - rtnl_link_unregister(&vxlan_link_ops); unregister_pernet_device(&vxlan_net_ops); + rtnl_link_unregister(&vxlan_link_ops); rcu_barrier(); } module_exit(vxlan_cleanup_module);