From patchwork Sun Mar 3 23:36:24 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Francois Romieu X-Patchwork-Id: 224574 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 2F2602C030B for ; Mon, 4 Mar 2013 10:36:52 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754706Ab3CCXgs (ORCPT ); Sun, 3 Mar 2013 18:36:48 -0500 Received: from violet.fr.zoreil.com ([92.243.8.30]:60392 "EHLO violet" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753252Ab3CCXgr (ORCPT ); Sun, 3 Mar 2013 18:36:47 -0500 Received: from violet.fr.zoreil.com (localhost [127.0.0.1]) by violet (8.13.8/8.13.8) with ESMTP id r23NaOQB028933; Mon, 4 Mar 2013 00:36:24 +0100 Received: (from romieu@localhost) by violet.fr.zoreil.com (8.13.8/8.13.8/Submit) id r23NaOYi028932; Mon, 4 Mar 2013 00:36:24 +0100 Date: Mon, 4 Mar 2013 00:36:24 +0100 From: Francois Romieu To: Dave Jones Cc: netdev@vger.kernel.org, Bruce Allan Subject: Re: e1000e disabling already-disabled device Message-ID: <20130303233624.GA28784@electric-eye.fr.zoreil.com> References: <20130303162124.GA31371@redhat.com> Mime-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130303162124.GA31371@redhat.com> User-Agent: Mutt/1.4.2.2i X-Organisation: Land of Sunshine Inc. Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Dave Jones : [...] > ------------[ cut here ]------------ > WARNING: at drivers/pci/pci.c:1397 pci_disable_device+0x90/0xa0() > Hardware name: 2356JK8 > Device e1000e > disabling already-disabled device > Modules linked in: > dm_crypt arc4 iwldvm mac80211 ipv6 iTCO_wdt xfs iTCO_vendor_support libcrc32c coretemp kvm_intel kvm crc32c_intel ghash_clmulni_intel microcode snd_hda_codec_hdmi snd_hda_codec_realtek btusb bluetooth iwlwifi pcspkr snd_hda_intel cfg80211 snd_hda_codec snd_pcm lpc_ich mfd_core e1000e snd_page_alloc ptp pps_core thinkpad_acpi hwmon led_class rfkill wmi nfsd auth_rpcgss nfs_acl lockd sunrpc i915 i2c_algo_bit drm_kms_helper drm i2c_core video > Pid: 19776, comm: kworker/u:11 Not tainted 3.8.0+ #6 > Call Trace: > [] warn_slowpath_common+0x75/0xa0 > [] warn_slowpath_fmt+0x46/0x50 > [] pci_disable_device+0x90/0xa0 > [] __e1000_shutdown+0x262/0x8a0 [e1000e] > [] e1000_suspend+0x23/0x50 [e1000e] > [] ? sub_preempt_count+0x79/0xd0 > [] pci_pm_suspend+0x77/0x140 > [] ? pci_pm_poweroff+0xf0/0xf0 > [] dpm_run_callback+0x58/0x90 > [] __device_suspend+0xed/0x280 > [] async_suspend+0x1f/0xa0 Could it be that runtime power management is also enabled, you have no link and thus end running both runtime_suspend and suspend at different times ? I wonder why the driver disables the PCI device here btw. Ueimor --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index a177b8b..5c643c6 100644 --- a/drivers/net/ethernet/intel/e1000e/netdev.c +++ b/drivers/net/ethernet/intel/e1000e/netdev.c @@ -5986,8 +5986,6 @@ static int __e1000_shutdown(struct pci_dev *pdev, bool *enable_wake, */ e1000e_release_hw_control(adapter); - pci_disable_device(pdev); - return 0; } ---