From patchwork Sat Feb 16 17:38:15 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 221008 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E9A012C0318 for ; Sun, 17 Feb 2013 04:38:40 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753844Ab3BPRif (ORCPT ); Sat, 16 Feb 2013 12:38:35 -0500 Received: from mail-pb0-f54.google.com ([209.85.160.54]:57972 "EHLO mail-pb0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753710Ab3BPRie (ORCPT ); Sat, 16 Feb 2013 12:38:34 -0500 Received: by mail-pb0-f54.google.com with SMTP id rr4so1051439pbb.41 for ; Sat, 16 Feb 2013 09:38:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:date:from:to:cc:subject:message-id:x-mailer:mime-version :content-type:content-transfer-encoding:x-gm-message-state; bh=zSTifT+k8UDx2dUZNNpnXtXh+khGLyyfet8Np4tBrB8=; b=ntT3EB+c1Qb5XXDKkHU/0MUBEx/8bCWMiQM9Pe4XyYj5RgZGI9C5zgnZ0MN3PqdGme GG6JWrmTtI4TkHSjd+VGlcLE9hLK+rrEX4rQJ5CyoU4DEtuErauiXXsY7mOUTEsOkLEr LGPYZbSxcjcqisa7gmOt29E2OdnN2Gk64O6xwsCkENqPDwsUmZ61nKa142pWOTAvShaq AHLO2SqUBelRa3JLbhWRGoeIVDUl4TykdvqedQTsNsbSL7sJ2fyP2+GIBq2eM5CpYep1 AnCwLTFwvBCngMYT1dUbAnFsGcpNzQCSgy1Wkdv87RC3NOI7x38bmaN6ENogUV5ADZ0r zXHA== X-Received: by 10.68.244.1 with SMTP id xc1mr15780987pbc.165.1361036313657; Sat, 16 Feb 2013 09:38:33 -0800 (PST) Received: from nehalam.linuxnetplumber.net (static-50-53-71-109.bvtn.or.frontiernet.net. [50.53.71.109]) by mx.google.com with ESMTPS id e6sm97660886paw.16.2013.02.16.09.38.32 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 16 Feb 2013 09:38:33 -0800 (PST) Date: Sat, 16 Feb 2013 09:38:15 -0800 From: Stephen Hemminger To: Pravin B Shelar , "David S. Miller" Cc: netdev@vger.kernel.org Subject: [PATCH net-next] ipv6: fix warning in xfrm6_mode_tunnel_input Message-ID: <20130216093815.45e2d8b2@nehalam.linuxnetplumber.net> X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-Gm-Message-State: ALoCoQmFTGSLygg2volgqSAl6PO573aEEm+/CFoUtJLZGa9ceRXiu4WU75psdIV7fPsSLVxS70pv Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Should not use assignment in conditional: warning: suggest parentheses around assignment used as truth value [-Wparentheses] Problem introduced by: commit 14bbd6a565e1bcdc240d44687edb93f721cfdf99 Author: Pravin B Shelar Date: Thu Feb 14 09:44:49 2013 +0000 net: Add skb_unclone() helper function. Signed-off-by: Stephen Hemminger --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/net/ipv6/xfrm6_mode_tunnel.c 2013-02-16 09:09:41.388937316 -0800 +++ b/net/ipv6/xfrm6_mode_tunnel.c 2013-02-16 09:33:49.906203566 -0800 @@ -69,7 +69,8 @@ static int xfrm6_mode_tunnel_input(struc if (!pskb_may_pull(skb, sizeof(struct ipv6hdr))) goto out; - if (err = skb_unclone(skb, GFP_ATOMIC)) + err = skb_unclone(skb, GFP_ATOMIC); + if (err) goto out; if (x->props.flags & XFRM_STATE_DECAP_DSCP)