From patchwork Sun Sep 23 06:09:52 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Miller X-Patchwork-Id: 186182 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A67DA2C008D for ; Sun, 23 Sep 2012 16:10:53 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753692Ab2IWGJ4 (ORCPT ); Sun, 23 Sep 2012 02:09:56 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:37933 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753640Ab2IWGJ4 (ORCPT ); Sun, 23 Sep 2012 02:09:56 -0400 Received: from localhost (cpe-66-108-116-58.nyc.res.rr.com [66.108.116.58]) by shards.monkeyblade.net (Postfix) with ESMTPSA id BFA275841FB; Sat, 22 Sep 2012 23:09:57 -0700 (PDT) Date: Sun, 23 Sep 2012 02:09:52 -0400 (EDT) Message-Id: <20120923.020952.2024265275496412823.davem@davemloft.net> To: jengelh@inai.de Cc: pablo@netfilter.org, netdev@vger.kernel.org Subject: Re: [PATCH 1/2] netlink: kill netlink_set_nonroot From: David Miller In-Reply-To: References: <1346934712-3056-1-git-send-email-pablo@netfilter.org> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jan Engelhardt Date: Sun, 23 Sep 2012 07:00:42 +0200 (CEST) > > On Thursday 2012-09-06 14:31, pablo@netfilter.org wrote: > >> /* optional Netlink kernel configuration parameters */ >> struct netlink_kernel_cfg { >> unsigned int groups; >> void (*input)(struct sk_buff *skb); >> struct mutex *cb_mutex; >> void (*bind)(int group); >>+ unsigned int flags; >> }; > > Putting flags next to groups would reduce the hole there. Works for me: -------------------- [PATCH] netlink: Rearrange netlink_kernel_cfg to save space on 64-bit. Suggested by Jan Engelhardt. Signed-off-by: David S. Miller --- include/linux/netlink.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/netlink.h b/include/linux/netlink.h index b3dc992..f80c56a 100644 --- a/include/linux/netlink.h +++ b/include/linux/netlink.h @@ -183,10 +183,10 @@ extern void netlink_table_ungrab(void); /* optional Netlink kernel configuration parameters */ struct netlink_kernel_cfg { unsigned int groups; + unsigned int flags; void (*input)(struct sk_buff *skb); struct mutex *cb_mutex; void (*bind)(int group); - unsigned int flags; }; extern struct sock *__netlink_kernel_create(struct net *net, int unit,