| Message ID | 20120702122531.GA29681@hmsreliant.think-freely.org |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Neil Horman <nhorman@tuxdriver.com> Date: Mon, 2 Jul 2012 08:25:31 -0400 > On Sun, Jul 01, 2012 at 07:44:25PM -0400, Neil Horman wrote: >> On Sun, Jul 01, 2012 at 02:43:19PM -0700, David Miller wrote: >> > From: Neil Horman <nhorman@tuxdriver.com> >> > Date: Sun, 1 Jul 2012 08:47:50 -0400 >> > >> > > Perhaps we could modify the SubmittingPatches document to indicate that an >> > > Acked-by from a subsystem maintainer implicitly confers authority on the >> > > upstream receiver to request reasonable stylistic changes that don't affect the >> > > functionality of the patch in the interests of maintaining coding conventions. >> > >> > Yes, that would make sense. >> > >> >> >> I'll propose it in a few days. >> Neil >> > How does this language sound to you? Looks fine to me. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 07/02/2012 02:25 PM, Neil Horman wrote: ... > How does this language sound to you? ... > +tree maintanier may reapply the subsystem maintainers Acked-by: to the new s/maintanier/maintainer/ HTH, Jan -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jul 03, 2012 at 08:45:18PM +0200, Jan Ceuleers wrote: > On 07/02/2012 02:25 PM, Neil Horman wrote: > ... > > > How does this language sound to you? > ... > > > +tree maintanier may reapply the subsystem maintainers Acked-by: to the new > > s/maintanier/maintainer/ > > HTH, Jan Thanks Jan, I've fixed it in my local tree, it'll get rolled in the next version. Neil > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index c379a2a..1eaaeb1 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -414,6 +414,16 @@ the part which affects that maintainer's code. Judgement should be used here. When in doubt people should refer to the original discussion in the mailing list archives. +Note that an Acked-by: From a subsystem maintainer on a given patch confers +upon the tree maintainer integrating the path the authority to carry those Acks +forward through subsequent versions of a patch, as long as those versions do not +significantly impact the functionality of the patch. For example, say the isdn +subsystem maintainer sends an Acked-by: on version 1 of a patch bound for the +networking tree. The networking maintainer then requests that some comments in +the code be modified to comply with the CodingStyle document. The networking +tree maintanier may reapply the subsystem maintainers Acked-by: to the new +version as no significant changes were made to the patch functionality. + If a person has had the opportunity to comment on a patch, but has not provided such comments, you may optionally add a "Cc:" tag to the patch. This is the only tag which might be added without an explicit action by the