From patchwork Sun Jul 1 05:39:43 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Miller X-Patchwork-Id: 168354 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id EABE62C01C1 for ; Sun, 1 Jul 2012 15:40:33 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751255Ab2GAFjq (ORCPT ); Sun, 1 Jul 2012 01:39:46 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:46204 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751132Ab2GAFjq (ORCPT ); Sun, 1 Jul 2012 01:39:46 -0400 Received: from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net [74.93.104.98]) by shards.monkeyblade.net (Postfix) with ESMTPSA id 886455834D9; Sat, 30 Jun 2012 22:39:47 -0700 (PDT) Date: Sat, 30 Jun 2012 22:39:43 -0700 (PDT) Message-Id: <20120630.223943.43292530650353283.davem@davemloft.net> To: ja@ssi.bg Cc: netdev@vger.kernel.org Subject: Re: [PATCH] ipv4: Elide fib_validate_source() completely when possible. From: David Miller In-Reply-To: References: <20120629.020552.2190372012516348013.davem@davemloft.net> X-Mailer: Mew version 6.5 on Emacs 24.0.97 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Julian Anastasov Date: Sat, 30 Jun 2012 13:45:52 +0300 (EEST) > If we really want a change in behavior we should > at least update the accept_local info in > Documentation/networking/ip-sysctl.txt ? Thanks for pointing this out, that's what I will do. ==================== ipv4: Clarify in docs that accept_local requires rp_filter. Signed-off-by: David S. Miller --- Documentation/networking/ip-sysctl.txt | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt index 99d0e05..47b6c79 100644 --- a/Documentation/networking/ip-sysctl.txt +++ b/Documentation/networking/ip-sysctl.txt @@ -857,9 +857,14 @@ accept_source_route - BOOLEAN FALSE (host) accept_local - BOOLEAN - Accept packets with local source addresses. In combination with - suitable routing, this can be used to direct packets between two - local interfaces over the wire and have them accepted properly. + Accept packets with local source addresses. In combination + with suitable routing, this can be used to direct packets + between two local interfaces over the wire and have them + accepted properly. + + rp_filter must be set to a non-zero value in order for + accept_local to have an effect. + default FALSE route_localnet - BOOLEAN