From patchwork Thu Jun 7 22:56:54 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matt Carlson X-Patchwork-Id: 163687 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 802BCB6FA3 for ; Fri, 8 Jun 2012 08:58:35 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758122Ab2FGW6V (ORCPT ); Thu, 7 Jun 2012 18:58:21 -0400 Received: from mms2.broadcom.com ([216.31.210.18]:2758 "EHLO mms2.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758014Ab2FGW6U (ORCPT ); Thu, 7 Jun 2012 18:58:20 -0400 Received: from [10.9.200.133] by mms2.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.5)); Thu, 07 Jun 2012 15:59:09 -0700 X-Server-Uuid: 72204117-5C29-4314-8910-60DB108979CB Received: from mail-irva-13.broadcom.com (10.11.16.103) by IRVEXCHHUB02.corp.ad.broadcom.com (10.9.200.133) with Microsoft SMTP Server id 8.2.247.2; Thu, 7 Jun 2012 15:57:28 -0700 Received: from mcarlson (mcarlson [10.12.148.101]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 179E79F9F6; Thu, 7 Jun 2012 15:58:08 -0700 (PDT) Date: Thu, 7 Jun 2012 15:56:54 -0700 From: "Matt Carlson" To: "ethan zhao" cc: "Eric Dumazet" , "Matt Carlson" , "Christian Kujau" , LKML , netdev Subject: Re: tg3: transmit timed out, resetting Message-ID: <20120607225654.GA14247@mcarlson.broadcom.com> References: <20120606010255.GA9991@mcarlson.broadcom.com> <20120606021436.GA10714@mcarlson.broadcom.com> <1338955977.2760.3603.camel@edumazet-glaptop> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-WSS-ID: 63CFEDB73IK1141941-01-01 Content-Disposition: inline Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jun 06, 2012 at 12:52:32PM +0800, ethan zhao wrote: > Eric, > That is ask for confirmation from Matt Carlson of Broadcom. > > Ethan > > On Wed, Jun 6, 2012 at 12:12 PM, Eric Dumazet wrote: > > On Wed, 2012-06-06 at 10:29 +0800, ethan zhao wrote: > >> So no way to fix it via firmware update or Linux driver ? :< > > > > Yes, but you need to cooperate, or else it might take more time than > > necessary. > > > > Asking questions like that on lkml is not going to help very much. > > > > So, once again, we kindly ask you try a recent kernel and post > > register dump and some additional information when transmit timeouts > > happen. > > > > The 'latest kernel' is either linux-3.5.rc1, or one of David Miller > > tree : > > > > http://git.kernel.org/?p=linux/kernel/git/davem/net-next.git;a=summary > > > > or > > > > http://git.kernel.org/?p=linux/kernel/git/davem/net.git;a=summary > > > > Thanks Does the following patch fix your problem? [PATCH] tg3: Apply short DMA frag workaround to 5906 5906 devices also need the short DMA fragment workaround. This patch makes the necessary change. Signed-off-by: Matt Carlson --- drivers/net/ethernet/broadcom/tg3.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c index d55df32..2db4d70 100644 --- a/drivers/net/ethernet/broadcom/tg3.c +++ b/drivers/net/ethernet/broadcom/tg3.c @@ -14275,7 +14275,8 @@ static int __devinit tg3_get_invariants(struct tg3 *tp) } } - if (tg3_flag(tp, 5755_PLUS)) + if (tg3_flag(tp, 5755_PLUS) || + GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5906) tg3_flag_set(tp, SHORT_DMA_BUG); if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719)