| Message ID | 20120522130558.D828E6C7@duch.mimuw.edu.pl |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sun, May 20, 2012 at 01:45:10PM +0200, Marek Marczykowski wrote: > Netfront driver can be also useful in dom0, eg when all NICs are assigned to > some domU (aka driver domain). Then using netback in domU and netfront in dom0 > is the only way to get network access in dom0. > > Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com> Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > --- > drivers/net/xen-netfront.c | 6 ------ > 1 files changed, 0 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c > index 698b905..e31ebff 100644 > --- a/drivers/net/xen-netfront.c > +++ b/drivers/net/xen-netfront.c > @@ -1953,9 +1953,6 @@ static int __init netif_init(void) > if (!xen_domain()) > return -ENODEV; > > - if (xen_initial_domain()) > - return 0; > - > printk(KERN_INFO "Initialising Xen virtual ethernet driver.\n"); > > return xenbus_register_frontend(&netfront_driver); > @@ -1965,9 +1962,6 @@ module_init(netif_init); > > static void __exit netif_exit(void) > { > - if (xen_initial_domain()) > - return; > - > xenbus_unregister_driver(&netfront_driver); > } > module_exit(netif_exit); > -- > 1.7.4.4 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Marek Marczykowski <marmarek@invisiblethingslab.com> Date: Sun, 20 May 2012 13:45:10 +0200 > Netfront driver can be also useful in dom0, eg when all NICs are assigned to > some domU (aka driver domain). Then using netback in domU and netfront in dom0 > is the only way to get network access in dom0. > > Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com> Someone please review this and I can merge it in via the 'net' tree if it looks OK to XEN folks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2012-05-22 at 20:13 +0100, David Miller wrote: > From: Marek Marczykowski <marmarek@invisiblethingslab.com> > Date: Sun, 20 May 2012 13:45:10 +0200 > > > Netfront driver can be also useful in dom0, eg when all NICs are assigned to > > some domU (aka driver domain). Then using netback in domU and netfront in dom0 > > is the only way to get network access in dom0. > > > > Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com> > > Someone please review this and I can merge it in via the 'net' tree if > it looks OK to XEN folks. Konrad is "Xen folks" and has acked it already but FWIW: Acked-by: Ian Campbell <ian.campbell@citrix.com> Ian. > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Ian Campbell <Ian.Campbell@citrix.com> Date: Tue, 22 May 2012 20:30:28 +0100 > On Tue, 2012-05-22 at 20:13 +0100, David Miller wrote: >> From: Marek Marczykowski <marmarek@invisiblethingslab.com> >> Date: Sun, 20 May 2012 13:45:10 +0200 >> >> > Netfront driver can be also useful in dom0, eg when all NICs are assigned to >> > some domU (aka driver domain). Then using netback in domU and netfront in dom0 >> > is the only way to get network access in dom0. >> > >> > Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com> >> >> Someone please review this and I can merge it in via the 'net' tree if >> it looks OK to XEN folks. > > Konrad is "Xen folks" and has acked it already but FWIW: > > Acked-by: Ian Campbell <ian.campbell@citrix.com> Ok, but this patch doesn't appply cleanly at all to Linus's current tree nor my 'net' tree (which are equal right now). -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, May 22, 2012 at 03:38:47PM -0400, David Miller wrote: > From: Ian Campbell <Ian.Campbell@citrix.com> > Date: Tue, 22 May 2012 20:30:28 +0100 > > > On Tue, 2012-05-22 at 20:13 +0100, David Miller wrote: > >> From: Marek Marczykowski <marmarek@invisiblethingslab.com> > >> Date: Sun, 20 May 2012 13:45:10 +0200 > >> > >> > Netfront driver can be also useful in dom0, eg when all NICs are assigned to > >> > some domU (aka driver domain). Then using netback in domU and netfront in dom0 > >> > is the only way to get network access in dom0. > >> > > >> > Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com> > >> > >> Someone please review this and I can merge it in via the 'net' tree if > >> it looks OK to XEN folks. > > > > Konrad is "Xen folks" and has acked it already but FWIW: > > > > Acked-by: Ian Campbell <ian.campbell@citrix.com> > > Ok, but this patch doesn't appply cleanly at all to Linus's > current tree nor my 'net' tree (which are equal right now). Oh no! Marek, can you repin it please (along with all the Ack's on it). -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index 698b905..e31ebff 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -1953,9 +1953,6 @@ static int __init netif_init(void) if (!xen_domain()) return -ENODEV; - if (xen_initial_domain()) - return 0; - printk(KERN_INFO "Initialising Xen virtual ethernet driver.\n"); return xenbus_register_frontend(&netfront_driver); @@ -1965,9 +1962,6 @@ module_init(netif_init); static void __exit netif_exit(void) { - if (xen_initial_domain()) - return; - xenbus_unregister_driver(&netfront_driver); } module_exit(netif_exit);
Netfront driver can be also useful in dom0, eg when all NICs are assigned to some domU (aka driver domain). Then using netback in domU and netfront in dom0 is the only way to get network access in dom0. Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com> --- drivers/net/xen-netfront.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-)