From patchwork Tue May 8 14:36:29 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Michael S. Tsirkin" X-Patchwork-Id: 157695 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 676DAB6EEC for ; Wed, 9 May 2012 00:36:30 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755429Ab2EHOg2 (ORCPT ); Tue, 8 May 2012 10:36:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9480 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754857Ab2EHOg1 (ORCPT ); Tue, 8 May 2012 10:36:27 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q48EaPWE020556 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 8 May 2012 10:36:25 -0400 Received: from redhat.com (vpn-202-190.tlv.redhat.com [10.35.202.190]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with SMTP id q48EaM28018494; Tue, 8 May 2012 10:36:22 -0400 Date: Tue, 8 May 2012 17:36:29 +0300 From: "Michael S. Tsirkin" To: Ian Campbell Cc: David Miller , "netdev@vger.kernel.org" , "eric.dumazet@gmail.com" Subject: Re: [PATCH RFC 4/6] tun: orphan frags on xmit Message-ID: <20120508143627.GA24335@redhat.com> References: <248cee8310a8d41b58b988dfea94e75ee79c6647.1336397823.git.mst@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <248cee8310a8d41b58b988dfea94e75ee79c6647.1336397823.git.mst@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, May 07, 2012 at 04:54:46PM +0300, Michael S. Tsirkin wrote: > tun xmit is actually receive of the internal tun > socket. Orphan the frags same as we do for normal rx path. > > Signed-off-by: Michael S. Tsirkin If tun is built as a module, skb_copy_ubufs needs to be exported: ----> Signed-off-by: Michael S. Tsirkin --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 83b04d9..a809014 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -765,7 +765,7 @@ int skb_copy_ubufs(struct sk_buff *skb, gfp_t gfp_mask) skb_shinfo(skb)->tx_flags &= ~SKBTX_DEV_ZEROCOPY; return 0; } - +EXPORT_SYMBOL_GPL(skb_copy_ubufs); /** * skb_clone - duplicate an sk_buff