From patchwork Sun Mar 25 17:12:37 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tilman Schmidt X-Patchwork-Id: 148578 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 7C1ADB6EE8 for ; Mon, 26 Mar 2012 05:08:53 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756760Ab2CYSIw (ORCPT ); Sun, 25 Mar 2012 14:08:52 -0400 Received: from mail.pxnet.com ([89.1.7.7]:38165 "EHLO mail.pxnet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756574Ab2CYSIu (ORCPT ); Sun, 25 Mar 2012 14:08:50 -0400 X-Greylist: delayed 2996 seconds by postgrey-1.27 at vger.kernel.org; Sun, 25 Mar 2012 14:08:49 EDT Received: from xenon.ts.pxnet.com (p5DE8CC28.dip.t-dialin.net [93.232.204.40]) (user=ts author=<> mech=DIGEST-MD5 bits=0) by mail.pxnet.com (8.13.8/8.13.8) with ESMTP id q2PHIcm9030483 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 25 Mar 2012 19:18:41 +0200 Received: by xenon.ts.pxnet.com (Postfix, from userid 1000) id 67310140074; Sun, 25 Mar 2012 19:18:37 +0200 (CEST) Date: Sun, 25 Mar 2012 19:12:37 +0200 From: Tilman Schmidt To: Greg KH , Jiri Slaby CC: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, netdev@vger.kernel.org, hjlipp@web.de Subject: Re: [GIT PATCH] TTY/serial patches for 3.4-rc1 References: <20120319195649.GD9883@kroah.com> In-Reply-To: <20120319195649.GD9883@kroah.com> MIME-Version: 1.0 Message-Id: <20120325171837.67310140074@xenon.ts.pxnet.com> X-Scanned-By: MIMEDefang 2.70 on 89.1.7.7 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Jiri, Greg, On 19.03.2012 20:56, Greg KH wrote: > tty and serial merge for 3.4-rc1 [...] > Jiri Slaby (77): [...] > TTY: isdn/gigaset, do not set tty->driver_data to NULL It seems that the amendment we discussed on 05.03.2012 did not make it into this patch. It would be nice if the following patch could still be added on top of it. Thanks, Tilman From: Tilman Schmidt Date: Sun, 25 Mar 2012 12:21:57 +0200 Subject: [PATCH] isdn/gigaset: use gig_dbg() for debugging output The "TTY buffer in tty_port" patchset introduced an opencoded debug message in the Gigaset tty device if_close() function. Change it to use the gig_dbg() macro like everywhere else in the driver. Signed-off-by: Tilman Schmidt --- drivers/isdn/gigaset/interface.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/isdn/gigaset/interface.c b/drivers/isdn/gigaset/interface.c index b3d6ac1..a6d9fd2 100644 --- a/drivers/isdn/gigaset/interface.c +++ b/drivers/isdn/gigaset/interface.c @@ -176,7 +176,7 @@ static void if_close(struct tty_struct *tty, struct file *filp) struct cardstate *cs = tty->driver_data; if (!cs) { /* happens if we didn't find cs in open */ - printk(KERN_DEBUG "%s: no cardstate\n", __func__); + gig_dbg(DEBUG_IF, "%s: no cardstate", __func__); return; }