| Message ID | 20120119.203108.460927494189100272.yamato@redhat.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | stephen hemminger |
| Headers | show |
On Thu, 19 Jan 2012 20:31:08 +0900 (JST) Masatake YAMATO <yamato@redhat.com> wrote: > This is trivial patch for libnetlink.c in iproute2. > > In iproute2/include/linux/netlink.h NLM_F_DUMP is defines as: > > #define NLM_F_DUMP (NLM_F_ROOT|NLM_F_MATCH) > > It is not used in libnetlink.c. If used, the code becomes a bit easier > to read. > > > > Signed-off-by: Masatake YAMATO <yamato@redhat.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/lib/libnetlink.c b/lib/libnetlink.c index c8fc4ef..c581e11 100644 --- a/lib/libnetlink.c +++ b/lib/libnetlink.c @@ -99,7 +99,7 @@ int rtnl_wilddump_request(struct rtnl_handle *rth, int family, int type) memset(&req, 0, sizeof(req)); req.nlh.nlmsg_len = sizeof(req); req.nlh.nlmsg_type = type; - req.nlh.nlmsg_flags = NLM_F_ROOT|NLM_F_MATCH|NLM_F_REQUEST; + req.nlh.nlmsg_flags = NLM_F_DUMP|NLM_F_REQUEST; req.nlh.nlmsg_pid = 0; req.nlh.nlmsg_seq = rth->dump = ++rth->seq; req.g.rtgen_family = family; @@ -162,7 +162,7 @@ int rtnl_dump_request(struct rtnl_handle *rth, int type, void *req, int len) nlh.nlmsg_len = NLMSG_LENGTH(len); nlh.nlmsg_type = type; - nlh.nlmsg_flags = NLM_F_ROOT|NLM_F_MATCH|NLM_F_REQUEST; + nlh.nlmsg_flags = NLM_F_DUMP|NLM_F_REQUEST; nlh.nlmsg_pid = 0; nlh.nlmsg_seq = rth->dump = ++rth->seq; -- To unsubscribe from this list: send the line "unsubscribe netdev" in
This is trivial patch for libnetlink.c in iproute2. In iproute2/include/linux/netlink.h NLM_F_DUMP is defines as: #define NLM_F_DUMP (NLM_F_ROOT|NLM_F_MATCH) It is not used in libnetlink.c. If used, the code becomes a bit easier to read. Signed-off-by: Masatake YAMATO <yamato@redhat.com> --- the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html